From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:403:478a::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id IM3DF7Hh5GSIgwAASxT56A (envelope-from ) for ; Tue, 22 Aug 2023 18:26:25 +0200 Received: from aspmx1.migadu.com ([2001:41d0:403:478a::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id qPLAF7Hh5GS7awEA9RJhRA (envelope-from ) for ; Tue, 22 Aug 2023 18:26:25 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 0540C60980 for ; Tue, 22 Aug 2023 18:26:25 +0200 (CEST) Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=Fpky35ap; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org ARC-Seal: i=1; s=key1; d=yhetil.org; t=1692721585; a=rsa-sha256; cv=none; b=uxP5AyNBIg3hhJbZIONjsMveez2Txgc4K/9JzgVSoGFzGJ9ABjPhMgyHL94lzS2yzNnBGM 1x2sMXjIho2dXVhJeq1Db5s2vE6tBj9dv50UFH9oxBnN+hEfYG1PwfDfeyFSR+OcCeU6uO 9HLkKIBeM7Tmf3b4LJ0CrfUJdvtNSdlPltpfYIKtaQG7bMqWuQ8KjDeOSfLerYhb2Qe1O1 oLt46IxBI87ReXH6mMyftWGTmVgKoQc88cQ8U0nsAmAbuTcuFA7VncKZDuYFHC5fkdk/S0 f4j2W3z/1R/u0AzBb3jWCQPsZGspIlFSfnBikhGUiLSsnTYXwWBrd/W54n6ijw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=Fpky35ap; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1692721585; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=3qz1NlKbi0rR8pDwRBJGzCynabB2I3hiPcgXr0OMNlE=; b=XuTOrWMCpfqPxTO/8lzlLmlvgq2veeLK1xEJeHNViWZHiMUx0YsJbqtEqLNbggt+Y3/K0r x8FzMey1guo3Y2ghnm+Qha2RD7J5sdsVXLSMvA3xhAuKrog5mYJOLMxRhyOeZdCqSc/upG RNcEsOcChuFOy60HhALb9RB4rWNUf3dHHuae4aDtyYDGMaVWUoK+fOu/sUMMPWEZHylzdi QSFwusT2boN+d08XuP4vCIv72TkH2MRouk8VM0Zgx6Cfp0GB80LRS7eFIhEdfRysck/p/U PJsyS8JcZdx3wyf3qfsPWgVZnT6GgEUcQ2SAiWEy80om37lMfJytQJ3cBODjtw== Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qYUCh-00089Y-Do; Tue, 22 Aug 2023 12:26:03 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qYUCe-000896-PX for guix-patches@gnu.org; Tue, 22 Aug 2023 12:26:01 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qYUCd-0002Nd-Jh for guix-patches@gnu.org; Tue, 22 Aug 2023 12:26:00 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qYUCf-0004EU-SF for guix-patches@gnu.org; Tue, 22 Aug 2023 12:26:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#65119] [PATCH 0/8] Sharing service code between Home and System Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 22 Aug 2023 16:26:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 65119 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Andrew Tropin Cc: 65119@debbugs.gnu.org, =?UTF-8?Q?=E5=AE=8B=E6=96=87=E6=AD=A6?= , paren@disroot.org Received: via spool by 65119-submit@debbugs.gnu.org id=B65119.169272155316254 (code B ref 65119); Tue, 22 Aug 2023 16:26:01 +0000 Received: (at 65119) by debbugs.gnu.org; 22 Aug 2023 16:25:53 +0000 Received: from localhost ([127.0.0.1]:60270 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qYUCW-0004E5-Jd for submit@debbugs.gnu.org; Tue, 22 Aug 2023 12:25:53 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:46012) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qYUCU-0004Dh-Og for 65119@debbugs.gnu.org; Tue, 22 Aug 2023 12:25:51 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qYUCD-0002Ds-Vx; Tue, 22 Aug 2023 12:25:41 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To: From; bh=3qz1NlKbi0rR8pDwRBJGzCynabB2I3hiPcgXr0OMNlE=; b=Fpky35apD2ZPxfz+9rQp vRIbOjRL/L7QhPJmQK0iljVSrNMCqhqrVseR+AsEVIXmRbT/E/rmGpOPqCDqF/m6GmwMUADiNrMin TBqOzgni3pXSOy/ynBGuVtFuEa5avkRCqmGOX+cd+TwnAEFEllPBmJKlzsxXr/32vH1J2VUO+KuNT bnYWmQRjhVs13zQiFbNoiOBpwEvic16oZfgJt4k9sn04jfeQIZ48eDc4tECEke6jBirZf1/bSHIao S0hDVq5/mtbCfs0srguCfk8o1dX/ovNUcYheWOjwNpBW6DLYR2B5hvxR0w1UnkJ4Cqk6oNY8a3lhR v3wtQONlhNnwxQ==; From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <87ttt3a4tm.fsf@envs.net> <87r0nwh5om.fsf@trop.in> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: Quintidi 5 Fructidor an 231 de la =?UTF-8?Q?R=C3=A9volution, ?= jour du Saumon X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Tue, 22 Aug 2023 18:25:22 +0200 In-Reply-To: <87r0nwh5om.fsf@trop.in> (Andrew Tropin's message of "Mon, 21 Aug 2023 17:43:21 +0400") Message-ID: <87jztn3uz1.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Scanner: mx0.migadu.com X-Spam-Score: -6.90 X-Migadu-Queue-Id: 0540C60980 X-Migadu-Spam-Score: -6.90 X-TUID: aXLHXfUaIlue Hi Andrew, Andrew Tropin skribis: > Sorry for comming late to the party, I saw this message only a week ago > and didn't have time to make an extensive reply yet, so I will share my > quick thought on the most problematic part and maybe later will > formulate others thoughts in more details. > > define-service-type-mapping looks imperative and potentially very > problematic. Collecting those values in unknown order and applying this > implicit transformation making a good room for foot shooting. Imagine > someone would like to use his own (let's say) shepherd home service > implementation and will add this to one of the source files of their > channel: > > (define-service-type-mapping > shepherd-root-service-type =3D> my-home-shepherd-service-type) > > What happens if somebody will use his channel just for getting some > package? Very likely it would break the build or in the worst case it > will build with unexpected service implementation under the hood. Yes, this is always possible. Though it=E2=80=99s not very different from: (set! home-shepherd-service-type =E2=80=A6) Maybe the unintended effect is more likely to happen unwillingly though, maybe. Do you have other solutions in mind, be it for this specific issue or for system/home service mapping in general? > I had [1][2] and still have concerns about macros and records > composability and reusability. I personally don't like excessive usage > of them in general. By adding more macros, already quite complex guix > services mechanism becomes even more harder to learn, inspect, reason > about and work with. In addition to that it has a major technical issue > mentioned above. I'm strongly against this change and would suggest to > revert it. > > I hope it doesn't sound rude and I'm really thankful for your work on > this, but I just think it's not the right solution, at least yet, in its > current form. It does sound a bit rude. :-) I would have loved to get any feedback from you while we were discussing this in the course of reviewing the Syncthing and Dicod patches a couple of months ago (which I believe you were Cc=E2=80=99d on, as member of the Home team). I won=E2=80=99t argue about macros and records, it=E2=80=99s off-topic: mac= ros and records are part of the Schemer=E2=80=99s toolbox, we try and use them wise= ly, and Guix code has always used macros and records. We can discuss whether a specific macro or record type is suitable, of course, but general statements about them are unhelpful. Was it =E2=80=98for-home=E2=80=99 that triggered your comment? The patches do not introduce any new record type IIRC; what triggered your comment regarding records? I=E2=80=99m all for making changes to improve on this patch series. I=E2= =80=99m against reverting the patch series: the conditions for reverting are not met (info "(guix) Commit Access"). Thanks for your feedback, Ludo=E2=80=99.