From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:306:2d92::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id IMlfDHvH+GQ9xQAAG6o9tA:P1 (envelope-from ) for ; Wed, 06 Sep 2023 20:39:55 +0200 Received: from aspmx1.migadu.com ([2001:41d0:306:2d92::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id IMlfDHvH+GQ9xQAAG6o9tA (envelope-from ) for ; Wed, 06 Sep 2023 20:39:55 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 204B9444E7 for ; Wed, 6 Sep 2023 20:39:55 +0200 (CEST) Authentication-Results: aspmx1.migadu.com; dkim=none; spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org"; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1694025595; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post; bh=yOGIjYuKrTiovUacjNeIyJGtu/g+6UTd6kWc4f35iHc=; b=o0eySohk5R7P96GYcYTiBSVziRIjm2FQ+tDpiHE7o5+bZIvSw54gYuoVjTX+hTZ74mPIRd Y+MtHK3y5AvagZcRZe/5GYUtK0R1j9uYhJZT1CrY2JwqrHijtsgcTzHHxNyX/owenfqNxG 3Ta2j/61oLbhLErVi5l6wuVeWxApyKRGnF+kqnuPD/lJ83bJmhQclD5vEmrLPXrKwdoTH6 tZGg4YcHyntd8312REHUd7Zrdve30HmdZ9afUyrCPhfwOMToKOv/LflLJKtkGF0mGA39HH uhHi9+QnueRn6zsJDkGWgMtUnk5s3N8uNFcI9laVz3RpUTwfKHXYETjbUs/Esg== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1694025595; a=rsa-sha256; cv=none; b=Qmun0XGZcv0m4yu2zW+7ievru5US9oy2DoNLSgbDbT8wu9H+FhGGB/+NWviq31hjWSQey9 3YHgknG58Uf+b30XL2fka7FTDypDeQZwIv4d5NePWOpOpZE6dul/rjQEPyPh4UZ9KBTcPl hOKQYvncblMSSHX80cIKhblxBGujlwpU0Whk7ymXR4p+Z+zBU3NvFy3hftJLd0PNblbJ9T yRyzwLHK3livYyNpVyWJaZiw4FwjMi8qGAeNyBvkCPSZN3FCNllu/D5ZI4luaD4EWvqh2V cZnGTwSOmYbv9ZeZ5pjOB9PNWA0oYq+0q7TR2sHeYrLAymawngm1x+yvpgtFwA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org"; dmarc=none Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qdxRA-00017P-Ue; Wed, 06 Sep 2023 14:39:36 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qdxR8-000159-N2 for guix-devel@gnu.org; Wed, 06 Sep 2023 14:39:34 -0400 Received: from mira.cbaines.net ([212.71.252.8]) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qdxR6-0003Ym-6f for guix-devel@gnu.org; Wed, 06 Sep 2023 14:39:34 -0400 Received: from localhost (unknown [217.155.61.229]) by mira.cbaines.net (Postfix) with ESMTPSA id ACA7227BBE2; Wed, 6 Sep 2023 19:39:30 +0100 (BST) Received: from felis (localhost [127.0.0.1]) by localhost (OpenSMTPD) with ESMTP id 21314498; Wed, 6 Sep 2023 18:39:30 +0000 (UTC) References: <87o7ifb66o.fsf@cbaines.net> User-agent: mu4e 1.10.5; emacs 28.2 From: Christopher Baines To: Felix Lechner Cc: guix-devel@gnu.org Subject: Re: Process for reviewing patches as someone without commit access Date: Wed, 06 Sep 2023 19:19:39 +0100 In-reply-to: Message-ID: <87jzt3b0yn.fsf@cbaines.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" Received-SPF: pass client-ip=212.71.252.8; envelope-from=mail@cbaines.net; helo=mira.cbaines.net X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: guix-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+larch=yhetil.org@gnu.org Sender: guix-devel-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN X-Migadu-Scanner: mx2.migadu.com X-Spam-Score: -5.50 X-Migadu-Queue-Id: 204B9444E7 X-Migadu-Spam-Score: -5.50 X-TUID: D0jceNlkHoa6 --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Felix Lechner writes: > On Wed, Sep 6, 2023 at 9:47=E2=80=AFAM Christopher Baines wrote: >> >> Maybe we can use debbugs tags for this? > > Instead of pushing people into reviews and then again making the same > committers a bottleneck, I would offer some entry-level contributors > commit rights but require that they obtain approval for some steps. It > can be done on a trust basis. It's an idea, although one I'd discount based on how many breaking changes (including ones with wide impact like breaking guix pull) happen with the current criteria for granting commit access. I don't want to make reviewing changes more difficult, and I think setting up more people with commit access and continuing the trend that it's mostly people with commit access that review changes would increase the difficulty, compared to what I'm proposing here, which is trying to empower people who just do review whilst avoiding any of the complexity of merging and pushing the changes without breaking things. Now of course you could argue that it being easy to break things is a problem, and maybe it is, but often it's not strictly someone breaking something but simply a commit not being signed, or not being signed in a way that guix accepts. Here I think pushing changes is complicated for good reason. > That way, you can train a new generation of committers while getting > the work done. In my opinion, I want to see review and committing things become more separated, because the valuable thing is having good review. Committing and pushing someone elses changes isn't adding much value to Guix in and of itself, but good review of those changes does. If we end up with a big backlog of changes that are reviewed and ready to merge, then I'm all for training and helping more people do the committing and pushing, but I have a suspicion that it's the review bit that takes the time. Thanks, Chris --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQKlBAEBCgCPFiEEPonu50WOcg2XVOCyXiijOwuE9XcFAmT4x2BfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNF ODlFRUU3NDU4RTcyMEQ5NzU0RTBCMjVFMjhBMzNCMEI4NEY1NzcRHG1haWxAY2Jh aW5lcy5uZXQACgkQXiijOwuE9XcZExAAo46RkSchyN/lDtKsFHRDK8iCtXUSg43B JncI6CL1KsCTQR05BR8F0a+hbEWF6ggrYLVHQdjXK8uxWna2z1cHzAydJtkd2FHx VbqYOVMEa46Z7CKrONlzRp+CQG8ZsZJGwxWdZ6SvkKcDvOZ/ArInrfFt4COy05DQ ZBQ36PBPunGjFEvpmSTRu07z0ePou4cpN2W+rAK8Ht1YjsbD4VAtkM3VOlDpSE0+ J41E+PibSToA5GVtGitqGAIXlSA+qGjbstnGRfqVv9s2oAgiA3EGnqQoCrMiD+2o R8NFMs1aZ3HmnYAYRrupJA16YhlqcqKdRN8YfZvsuFkRLOHw1dYaWKhHOwZ4HCXB jh1Bfxl7b9QujEeb6A3p5BIQftyQQBD6NkrYxO2kC7Qy5hs35+bDFMbridgE6t2X Te03LgbQCi1bc9AjORBTQxDrgCNL3QjgCGPP3InpBWvc+KhgPJq4OA5C+WFs8IvR HGqEiz/PANiNOArRWzLJ2tFy4bkmjDEYtWq+NiINNjUByMwM7k1JL8DGKHkPgIu6 e6hHrxCzGjyPxw1GD2Tw6ZGHKp1veBnyr6+nlpfGbAA/vAlwwchLeBILYEHmu/oj 0h6zcrkfm+dZQjb44gw2CGBSHpao6YloktN5nPZ/WxksYF8lYGMMVFOfEE8Tulcl 7AFHlnuEMGc= =F5pA -----END PGP SIGNATURE----- --=-=-=--