From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:403:478a::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id 8ClBJ8ZUFGW3OwAAG6o9tA:P1 (envelope-from ) for ; Wed, 27 Sep 2023 18:13:58 +0200 Received: from aspmx1.migadu.com ([2001:41d0:403:478a::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id 8ClBJ8ZUFGW3OwAAG6o9tA (envelope-from ) for ; Wed, 27 Sep 2023 18:13:58 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 496EE5B71C for ; Wed, 27 Sep 2023 18:13:58 +0200 (CEST) Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20230601 header.b=k5Qwe9Ao; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1695831238; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=Frp/MYv2HWdA7dwBbirsWqyWUBSuvXpsNzDm7TOXtN8=; b=gFs2SDfM/47Za9aEiA/ZiMhky/cn77apVOSpupaPRK7VkUSehWzYThQiPxM3KuHpAcY5I4 tHkK3fhE7B0tMCONPTyT8/PA/bh8DxxCTxyibStVNUww/vaL2945vsVGrCd8HHyp6/mfpa m3iV/l8FlfKFYZJbhqopWPFEGVq5n1IK2pPI7NH+Q89vSavGqu9x9m/2wsOVRPuxNGZIzl Z1pq7HAXnL9j1qtnL0a3kvBPyvit/nWSimLetTLse9D2mF5tXzpheqYEqM09duP+Eqc6Wz lXT+dxUJbNP/D7NWkdLB/derMpheRraFAxCitIQkZ/7ThKJoNsr45UH1hMVJ1Q== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1695831238; a=rsa-sha256; cv=none; b=t4Guw30R/Zn760hkT4bSiqaUWszYFEdbEDk/2CoB3LORoOpzZyfDWGn3mOIAKMJg3mOnlD CpqFmDbg8FVXlAYuYyjsUBLZHlKZqTFW5CBiM07VcJVuKr98xWqFiMzqWP/y7VywTgQ2af 1naOYmT+6xnZx/VgrW1Eop68h8svKJnjdh1vqWXGNJTra4LrMB6UCw/xK9LZYy3Nw1ow1G p+MaFh2IGYJGpM5ZXvQv7zxfNhw1fa1wSpB4zGVZoDFMVHKdR7XNrnz63dpve/gpxsNn9O Y6z5JfrOs405X/NgxA8YbXEvr8h44F9LtZ+iMZOulfwSmO6E1Xcpxn+kMVXfiA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20230601 header.b=k5Qwe9Ao; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qlXAc-0007o1-Hw; Wed, 27 Sep 2023 12:13:51 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qlXAa-0007lx-Vb for guix-patches@gnu.org; Wed, 27 Sep 2023 12:13:48 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qlXAa-0005hs-Mc for guix-patches@gnu.org; Wed, 27 Sep 2023 12:13:48 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qlXAo-0001HY-A9 for guix-patches@gnu.org; Wed, 27 Sep 2023 12:14:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#66199] [PATCH] gnu: librepcb: Update to 1.0.0. Resent-From: pinoaffe Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 27 Sep 2023 16:14:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 66199 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Vinicius Monego Cc: 66199@debbugs.gnu.org Received: via spool by 66199-submit@debbugs.gnu.org id=B66199.16958312344906 (code B ref 66199); Wed, 27 Sep 2023 16:14:02 +0000 Received: (at 66199) by debbugs.gnu.org; 27 Sep 2023 16:13:54 +0000 Received: from localhost ([127.0.0.1]:52306 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qlXAf-0001H4-QA for submit@debbugs.gnu.org; Wed, 27 Sep 2023 12:13:54 -0400 Received: from mail-ed1-x52d.google.com ([2a00:1450:4864:20::52d]:45468) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qlXAb-0001Gn-Nh for 66199@debbugs.gnu.org; Wed, 27 Sep 2023 12:13:52 -0400 Received: by mail-ed1-x52d.google.com with SMTP id 4fb4d7f45d1cf-5345a3dfe3bso5516102a12.3 for <66199@debbugs.gnu.org>; Wed, 27 Sep 2023 09:13:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1695831210; x=1696436010; darn=debbugs.gnu.org; h=mime-version:message-id:in-reply-to:date:subject:cc:to:from :user-agent:references:from:to:cc:subject:date:message-id:reply-to; bh=Frp/MYv2HWdA7dwBbirsWqyWUBSuvXpsNzDm7TOXtN8=; b=k5Qwe9Ao8Fsm9viUWgkrRIpwAWh7MLfjiBepYjbhu22oxPGiUnp7oq+6L8jb0Gzs4K jkzFC2BpcKrkwTyDrN2m4KqqyDJWYGdQCg0vAIwKjs0R+xiDt7PNKhSQUxJy41/ovhfk VNjzzEig921wrLt/ai87UYe8hyXrWuhvAl6a8SuMxdKgFflzGYPCOqncZQoHvNzD43JO bUu9BbqyPPLjL59o+L+zKiAXQLtlsiDub3Mn27596JNDTGkcRHqiXEUi5bvLOK00ai7x 6WnEDKmVlLUPE+QiG34oETsKehLUiFF1rAP8hNFePBzuO2EVkZzritEA7gKnV8VgtGz9 ti+g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1695831210; x=1696436010; h=mime-version:message-id:in-reply-to:date:subject:cc:to:from :user-agent:references:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Frp/MYv2HWdA7dwBbirsWqyWUBSuvXpsNzDm7TOXtN8=; b=I16ii4b6kN1slzE5lVAubdwiD+PmMUJ5gtIHoIXI9nw2mY0egR4yKO5lCy2GuybaMu KHdIexEcyKfG9MsOY7uJjRHRswJfVHz7i4eXcA5uKjwYbGETII28bVp7w3q9tTVX7yeG DP9F3zhgNFqODe8X37zNtDdnVvWUJCqG5p1Aw7D/qX8G5Jen5ROqusVXNWIN9JlIT0p8 JSMskUOw11lcf0rzb0F0BueljjVO6SHVLGJgJCsbN/GEqsQkBftA30DMzRIhhN9GRbVK zdGHjQjd4sKToeMzcnMzoYnhOy0P5k/3MpSeBwl9pxu7zoL+O7TTlGbXxMFb1Ul/YjFk JgiQ== X-Gm-Message-State: AOJu0YxZMI+Z256CUTWHwXvQ0P3w6uPOgBtb3eAiE0UITy0tHQLPQt+6 xnEh/H9VwSc/KDi2xytvsExbAdXbYXQ= X-Google-Smtp-Source: AGHT+IGJc9WE7nZvQGpxuSk5SXE0GfIYUzk+hO5y2m5fTIdRfkXKeHAUxAaxtz5Gk2Wwb2aAUViZYw== X-Received: by 2002:a17:906:53ca:b0:9b2:9e44:222e with SMTP id p10-20020a17090653ca00b009b29e44222emr2604991ejo.19.1695831209452; Wed, 27 Sep 2023 09:13:29 -0700 (PDT) Received: from localhost (h120217.upc-h.chello.nl. [62.194.120.217]) by smtp.gmail.com with ESMTPSA id qw25-20020a1709066a1900b009b293d1f2eesm3652822ejc.107.2023.09.27.09.13.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 27 Sep 2023 09:13:29 -0700 (PDT) References: <3e28337e7ead18b49e5e2e99d0e3d1d22e3f9d47.1695673614.git.pinoaffe@gmail.com> <2f4f0210-ea10-27e0-55fc-ccd55e807576@posteo.net> <87h6nhdtbh.fsf@gmail.com> User-agent: mu4e 1.10.5; emacs 28.2 From: pinoaffe Date: Wed, 27 Sep 2023 18:06:36 +0200 In-reply-to: Message-ID: <87jzsbbnmf.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Scanner: mx0.migadu.com X-Migadu-Spam-Score: -4.92 X-Spam-Score: -4.92 X-Migadu-Queue-Id: 496EE5B71C X-TUID: MPbyoh58vmRG Thanks again! Vinicius Monego writes: > Em 26/09/2023 09:08, pinoaffe escreveu: >> Vinicius Monego writes: >>> The commit message should also mention the switch to >>> cmake-build-system, the "not overriding" of the configure phase, the >>> new inputs and the test skip.. >> I wasn't sure how to phrase / format this, is what I arrived at OK? > You can check the logs of e.g. commit > 19617735df2b1af3b169d8153ae543ad3e0fc1a1 for reference. Ah yes, I'll try to replicate that > 'googletest' should be a native input, it's a test requirement only. oh yes, of course, thanks! > [Comment on the LibrePCB update patch specifically]: This v2 is much > better, thanks. While investigating the build I also found a few more > things that could be improved: > > - The bundles that were unvendored can be deleted in a source snippet > (see e.g. the mixxx package). Done > - LibrePCB builds a test executable at > tests/unittests/librepcb-unittests. Instead of 'make test', that > file could be run manually when overriding the check phase. Done > - The license list should be updated as some of the bundles listed > there are not being provided anymore, or even better let it be only > gpl3+ because that's the license of the final product. I removed all of the licenses and license comments that were no longer relevant, but there's still some non-GPL3+ code involved, so I figured I'd keep those licenses around. > - I got two merge conflicts on > 06dc36ffb7cde821a4762b299d1c95b3788ba110, please rebase it to the > latest commit. Done > If the tests are too problematic that's fine, I can merge this patch > with the other changes later this week. > > Vinicius Kind regards, pinoaffe