From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:403:478a::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms8.migadu.com with LMTPS id 8HlkGC23K2VzWAEA9RJhRA:P1 (envelope-from ) for ; Sun, 15 Oct 2023 11:55:57 +0200 Received: from aspmx1.migadu.com ([2001:41d0:403:478a::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id 8HlkGC23K2VzWAEA9RJhRA (envelope-from ) for ; Sun, 15 Oct 2023 11:55:57 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 135916683C for ; Sun, 15 Oct 2023 11:55:57 +0200 (CEST) Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=jpoiret.xyz header.s=dkim header.b=Jmf7k8Z7; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1697363757; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=ggo3gUMyRNd+6wpMNj6ldrvx7OnnK7b3UYpubQfYwHM=; b=kMM65Bc0TPtu2QtPczz6CvUOBUBZBxnV36xjaYksEeS7ALAEF6UT9yTU0ImoLbURbGAJ+3 m/GQABsqoSowUhLLXHOU6y5AnmYwuC9mBMnfpX63PGls0TXpuw+T+cBgUVbs9LKEpNmXvf 9u7hjpQaEkLV3yjzDkc82GvS1U/8AAF2vT0qeCUUgo8C0JmAusmHmelu2eAV/pTN3QgQY8 XL5hgHEg8vJkDpZ2wpEmMsJ8LbdaoCTR695ElEYHTyrVszje7irOgUXApzQcElHJUFityS Lxz2pXWgUYWfjxjrQbb/wg9pftcDGI2wmmrylqk/6RYm/4Hh2AYbq5s5q6iEkA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1697363757; a=rsa-sha256; cv=none; b=mTcsugoUke5hAW6T3tnwmxaRbCc6lFE6oca5l1+jfnU25V/NvGxpgrrkanDQsayDpR2R2J xMh5edonINItagXB/jP9QVW9OpuUx5jdbvBJFMQouEtlyPOLgqI4wu4SoH44iy2qC/rrN7 30bt14twE7cPSMt9Ww90EFFZk0GKXjXGFkx5CGLvd03Uxi5o4Ayvv0HgMllDn2aNcYcjCQ Te0x+4UCU/oOQPJyrmgl4an/yNnSBuW+P3WfcD4KqcASsqjIWdD+yTu6mO8W2rbDxzCYJa osoWHwO+IrtGIBM7Dhm5p9u0tYvzsJnPcJta8madNlt2m4lb3i0Wkrllclzh3g== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=jpoiret.xyz header.s=dkim header.b=Jmf7k8Z7; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qrxqX-0006ZW-8K; Sun, 15 Oct 2023 05:55:41 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qrxqV-0006Tj-0l for guix-patches@gnu.org; Sun, 15 Oct 2023 05:55:39 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qrxqU-0004lq-Mv for guix-patches@gnu.org; Sun, 15 Oct 2023 05:55:38 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qrxqs-0005D9-It for guix-patches@gnu.org; Sun, 15 Oct 2023 05:56:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#66436] [PATCH v2] doc: Add some guidelines for reviewing. Resent-From: Josselin Poiret Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sun, 15 Oct 2023 09:56:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 66436 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Maxim Cournoyer , 66436@debbugs.gnu.org Cc: Ludovic =?UTF-8?Q?Court=C3=A8s?= , Maxim Cournoyer Received: via spool by 66436-submit@debbugs.gnu.org id=B66436.169736374620006 (code B ref 66436); Sun, 15 Oct 2023 09:56:02 +0000 Received: (at 66436) by debbugs.gnu.org; 15 Oct 2023 09:55:46 +0000 Received: from localhost ([127.0.0.1]:51231 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qrxqc-0005Cc-6l for submit@debbugs.gnu.org; Sun, 15 Oct 2023 05:55:46 -0400 Received: from jpoiret.xyz ([206.189.101.64]:46890) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qrxqZ-0005CT-O7 for 66436@debbugs.gnu.org; Sun, 15 Oct 2023 05:55:44 -0400 Received: from authenticated-user (jpoiret.xyz [206.189.101.64]) by jpoiret.xyz (Postfix) with ESMTPA id 5140118543D; Sun, 15 Oct 2023 09:55:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=jpoiret.xyz; s=dkim; t=1697363718; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=ggo3gUMyRNd+6wpMNj6ldrvx7OnnK7b3UYpubQfYwHM=; b=Jmf7k8Z7jIPIt6hJEbEwzQ1pQ3X8AYdNnOe46abVBcRlZrY4sORQzOpyWiC15AmnskKMOw UYzInUs8JaDgSk2kgZktQ7hNeXt1MHR9bQUyOG01+9vcxrXBqpo7o7k57Cy/b6Ub+PxYm8 cx3MSHW6Vqzd27DD/aYHoingcYsO89LtjpRlTdx+3VLGdq5pbxQayfyuqGqJOaojGzXO6M xltvkij4UKN57Ep2rDunkR6w1wAaMgU5W2aKexlJ/iWNE5Q3ew3y3HN6YVMiDmw72E0Bd9 3jORAfgjcWVOnDNnCxIm4BqEC3e7inye2ANbg976e3rPjOHmdHQwThZ2c0SM0w== In-Reply-To: <0a5e027af3c0b61f9ab9f3c66e73b7a769eef7fd.1696983695.git.maxim.cournoyer@gmail.com> References: <19f82d9bbef649c750ad067d23ebbaee6f9ae494.1696942467.git.maxim.cournoyer@gmail.com> <0a5e027af3c0b61f9ab9f3c66e73b7a769eef7fd.1696983695.git.maxim.cournoyer@gmail.com> Date: Sun, 15 Oct 2023 11:55:15 +0200 Message-ID: <87jzroyzuk.fsf@jpoiret.xyz> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spamd-Bar: + X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-to: Josselin Poiret X-ACL-Warn: , Josselin Poiret via Guix-patches From: Josselin Poiret via Guix-patches via Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Spam-Score: -6.77 X-Migadu-Queue-Id: 135916683C X-Migadu-Scanner: mx0.migadu.com X-Migadu-Spam-Score: -6.77 X-TUID: JVhkxFeJ3i3R --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Hi Maxim, Maxim Cournoyer writes: > +@cindex LGTM, Looks Good To Me > +When you deem the proposed change adequate and ready for inclusion > +within Guix, the following well understood/codified @acronym{LGTM, Looks > +Good To Me} phrases should be used to sign off as a reviewer, meaning > +you have reviewed the change and that it looks good to you: > + > +@itemize > +@item > +If the @emph{whole} series (containing multiple commits) looks good to > +you, reply with a @samp{This series LGTM!} to the cover page if it has > +one, or to the last patch of the series otherwise. > + > +@item > +If you instead want to mark a @emph{single commit} as reviewed (but not > +the whole series), simply reply with @samp{LGTM!} to that commit > +message. > +@end itemize Some mbox -> patches tools (like b4) are able to automatically apply trailers like "Reviewed-by: some ident <...>" found as replies to patch series [1]. I also like the very clear meaning of it: there's no way you would type this without meaning "Yes, I officially vouch that this patch series has been reviewed by me". Maybe this could be codified here? Otherwise, seem good to me. [1] `b4 am`'s -t option, see https://b4.docs.kernel.org/en/latest/maintainer/am-shazam.html Best, =2D-=20 Josselin Poiret --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQHEBAEBCgAuFiEEOSSM2EHGPMM23K8vUF5AuRYXGooFAmUrtwMQHGRldkBqcG9p cmV0Lnh5egAKCRBQXkC5FhcaiqBCC/4zDX0BupR681wVirKoJuOctDso8gn+obJQ 7T6ftm50NNzywQ1cwAb6cHlVptX2FpyKOcCPq1MhhyAuw2BgqCP0OeciiJWBcDO4 NE5jqjYovr47Au02v7Fez1PJ3hsJF4a/pSwvkGsHonjv3w46rT1NJla2TKw74ihP vYpBza6eKaso3XNMDMs+ur2D2EJ0UpAFdJurGpHtZ6pJgobrpRjnLpu9TI//FEBr V3Ijb0+alwMCzSApnGO/8xeO2VzUS7xOwyibt2NOBA9vH+05GNo53koU24kL3SGd 9NMhRCvJHRUod7MIBZfgsCFjuZF6G4fQ+hr1+BBoU8RSuO+PZTmStARfAf16OlPY JWN5FpPc3tPCmYYM72hT9Zc0a5Ymfp/mVsFDx6Q7R/epB1u8vEGN+7n5iCGGwhoi 9t8Ld0Tya3Si2dn1qglcuHsN+c6a6s5JYf2nk0pdLTzX1tBFVRCnQhmz9y7jKyHI u8qrlUL0e5lHjv7v0hNwEbua/4+RNTU= =8Qxd -----END PGP SIGNATURE----- --=-=-=--