From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:303:e16b::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms8.migadu.com with LMTPS id UNsdOXhNQWVwVwEAG6o9tA:P1 (envelope-from ) for ; Tue, 31 Oct 2023 19:54:49 +0100 Received: from aspmx1.migadu.com ([2001:41d0:303:e16b::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id UNsdOXhNQWVwVwEAG6o9tA (envelope-from ) for ; Tue, 31 Oct 2023 19:54:49 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id D50A45D82C for ; Tue, 31 Oct 2023 19:54:48 +0100 (CET) Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20230601 header.b=asjiCj7d; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1698778488; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=9xRKDmKD9bWsvBQoM36Cw/wb4GaXxs6b7UXebn1nw0A=; b=FiUT/4eO9E2BGdTplwbfiTOuql5jhRfe1PtbqVtKf4yyp2nmo3XTV096bi4y08woCECeAU jnUj7MQhmsyBthEf0jLun0zPzU5+o1cG0QN0JMMikb9qzKf5jWqYwbKAbrprl012RzK2OT qEgOMmV64A1nb/C5HaEJ7gXl3VpYibHCCTkL3hJDZZV+wqegcKc6Ikm03gEicU2dkPgoGF d+2DARGTK8GbDjIgRn9C2B5Blx7JI2KDsqIoN0Ec4UPUF6uNon9KRMnMxfGNMUjDYf1l1e rC0QnW+eToZ+N55fZC6zj1jG6OoweCwYa9SipwLRMqMyJ/t+AGeBCr2rfy8rJw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20230601 header.b=asjiCj7d; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none) ARC-Seal: i=1; s=key1; d=yhetil.org; t=1698778488; a=rsa-sha256; cv=none; b=nT6JojkWHqVLXpm1wbd5SxD9ZU6rNZN+EHD9AcckNDpJriNbkPLkMXpx/CzkNV1cQDdzF5 9hO+cc/+i/aIHx+mG1SyUVIBhFcxy5UIlMxviI7JBfUgGM4AtZ2gVDTulAxmK1aCMVSFR8 6tcdANzsCSV8r1RUaVAwNsBnjzCtYR+SKpQMiPJWCPJmD5NmcF3aLdmJVLRgTpxfNH+A+B 5xKkGGlmwB6v9O4bdra1zvzwiGter1n/l3GhP2kL78SlzvgWUdFcmHuE+FKGOJp0FNZe6b RNcp2HSdKEq7gn5EPK4Hezw0fUQzAehOh683RiZ2n1tZfrjCLJ0hRTU2t/wc9A== Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qxtsk-00019z-R2; Tue, 31 Oct 2023 14:54:30 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qxtsj-00019k-Qe for guix-patches@gnu.org; Tue, 31 Oct 2023 14:54:29 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qxtsj-0005Ke-EP for guix-patches@gnu.org; Tue, 31 Oct 2023 14:54:29 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qxttG-0004b1-EH for guix-patches@gnu.org; Tue, 31 Oct 2023 14:55:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#66436] [PATCH v2] doc: Add some guidelines for reviewing. Resent-From: Maxim Cournoyer Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 31 Oct 2023 18:55:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 66436 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Simon Tournier Cc: 66436@debbugs.gnu.org, Ludovic =?UTF-8?Q?Court=C3=A8s?= , =?UTF-8?Q?Cl=C3=A9ment?= Lassieur Received: via spool by 66436-submit@debbugs.gnu.org id=B66436.169877847417617 (code B ref 66436); Tue, 31 Oct 2023 18:55:02 +0000 Received: (at 66436) by debbugs.gnu.org; 31 Oct 2023 18:54:34 +0000 Received: from localhost ([127.0.0.1]:49172 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qxtso-0004a4-1J for submit@debbugs.gnu.org; Tue, 31 Oct 2023 14:54:34 -0400 Received: from mail-oi1-x231.google.com ([2607:f8b0:4864:20::231]:45336) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qxtsh-0004Zj-UV for 66436@debbugs.gnu.org; Tue, 31 Oct 2023 14:54:32 -0400 Received: by mail-oi1-x231.google.com with SMTP id 5614622812f47-3b2ec9a79bdso4154723b6e.3 for <66436@debbugs.gnu.org>; Tue, 31 Oct 2023 11:53:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1698778427; x=1699383227; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=9xRKDmKD9bWsvBQoM36Cw/wb4GaXxs6b7UXebn1nw0A=; b=asjiCj7dhNQSxtTh4CA8iBHh8fs+RJXDiOMK5pPkhr6EbTXHAsxk+6dAb9C1EWwxs9 CPiYikMhvgJ/MO9rp/P5Mhh9ndeeb56Fj1bph9KZJNDvkUll2sJXV3Re4DdaEjtGT45Q bOHc7BHZwhOmQCaA1utwo7PaO2mSF1laKzp+KdJNcF3Kmo7ZcSihYsOMRP6c/9Q6F0um hVS5EozQZeLyTxZNcXdL0LNSDwV9SpZ7ZEhmiZwVmVr6mnZTDClL79GW56yXW5qRaLjv Mabq/CxdiRre9t/udtPTiR4Wz5UaPBjgDdOoWuHW3o14AIKT2szcPcYzxw9p5nEf7y7z wxYA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1698778427; x=1699383227; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=9xRKDmKD9bWsvBQoM36Cw/wb4GaXxs6b7UXebn1nw0A=; b=eOjKXBLBH5NL6xmt3UhN6dM7tNtBd+dHo+i8i7R2BwaM7UaNO9ntbC6Co1/MB/2TAb k3D/XyA6SmkCu6G3cZZrI9dt5ZM/KJuZBkm5NRAku9OLo49xiB++40udeMFzMtHYnPrM MW4oE+8Tggt/SSb5mzz6l/4q+jzKrbEvYN8+TALrplXLaBey2HNv6jVUzAHyOZBhn8is g93HewpAG11XYmPZ/KTHPOQaiTuY24w1Xb6K/e/G30A5pdntY2fVYcX6DWyO3qUP/JDf d7ZIAiyeiiAgBHKYqNVpqw3yGfdrb2a2fb+f6HyrOaBWXTenWmDhgAOwEg03lZu4QE4W IU/w== X-Gm-Message-State: AOJu0Yw2XqBWW5zCWxYuTyERHn7Gcb+W6tZp9vn0LL+/Nc6O70paiPQ7 r5SIEdETZF+IQwIkmgAcOcg= X-Google-Smtp-Source: AGHT+IFI5JGUFFUniN/SUg4tYTdPApVl1PuF3eMs+yul80xOGyvM5Y4+LTxvSZJFHfGYcLgT7fwB8Q== X-Received: by 2002:aca:1705:0:b0:3b2:e12e:d2db with SMTP id j5-20020aca1705000000b003b2e12ed2dbmr14677544oii.39.1698778427334; Tue, 31 Oct 2023 11:53:47 -0700 (PDT) Received: from hurd (dsl-10-128-239.b2b2c.ca. [72.10.128.239]) by smtp.gmail.com with ESMTPSA id j16-20020a05620a0a5000b007742bc74184sm735830qka.110.2023.10.31.11.53.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 31 Oct 2023 11:53:46 -0700 (PDT) From: Maxim Cournoyer In-Reply-To: <86bkcov1j2.fsf@gmail.com> (Simon Tournier's message of "Tue, 24 Oct 2023 10:59:45 +0200") References: <19f82d9bbef649c750ad067d23ebbaee6f9ae494.1696942467.git.maxim.cournoyer@gmail.com> <0a5e027af3c0b61f9ab9f3c66e73b7a769eef7fd.1696983695.git.maxim.cournoyer@gmail.com> <87h6mlzp9g.fsf@lassieur.org> <87r0logap6.fsf@gmail.com> <86il6wv200.fsf@gmail.com> <86bkcov1j2.fsf@gmail.com> Date: Tue, 31 Oct 2023 14:53:45 -0400 Message-ID: <87jzr2pqrq.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Spam-Score: 4.40 X-Spam-Score: 4.40 X-Migadu-Queue-Id: D50A45D82C X-Migadu-Scanner: mx13.migadu.com X-TUID: k+LLaMoqWdWT Hi Simon, Simon Tournier writes: > Re, > > On Tue, 24 Oct 2023 at 10:49, Simon Tournier w= rote: > >>> --8<---------------cut here---------------start------------->8--- >>> +Perhaps the biggest action you can do to help GNU Guix grow as a proje= ct >>> +is to review the work contributed by others. You do not need to be a >>> +committer to do so; applying, reading the source, building, linting and >>> +running other people's series and sharing your comments about your >>> +experience will give some confidence to committers, and should result = in >>> +the proposed change being merged faster. >>> --8<---------------cut here---------------end--------------->8--- > > [...] > >> IMHO, it is worth to clearly state: >> >> 1. what helps the review process: >> >> =C2=AB applying, reading the source, building, linting and running o= ther >> people's series and sharing your comments about your experience will >> give some confidence to committers, and should result in the >> proposed change being merged faster. =C2=BB > > Although I do not know if it is the right place, I would mention that > =E2=80=9Cbuilding=E2=80=9D also means that the dependants still build or = clearly > indicate if something breaks. That's already mentioned in 'Submitting Patches': 9. Check that dependent packages (if applicable) are not affected by the change; =E2=80=98guix refresh --list-dependent PACKAGE=E2=80=99 wi= ll help you do that (*note Invoking guix refresh::). I don't think we should repeat it here :-) (also, we now have CI, which should be more apt at catching breakage here). -- Thanks, Maxim