From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:303:e16b::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms8.migadu.com with LMTPS id qBcpF4irR2W1DgEAauVa8A:P1 (envelope-from ) for ; Sun, 05 Nov 2023 15:49:44 +0100 Received: from aspmx1.migadu.com ([2001:41d0:303:e16b::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id qBcpF4irR2W1DgEAauVa8A (envelope-from ) for ; Sun, 05 Nov 2023 15:49:44 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 1CF9240348 for ; Sun, 5 Nov 2023 15:49:44 +0100 (CET) Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=ahXAEWxi; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1699195784; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=jqXnEfJpN9iQXxgxGNh3/C07uZPO3sdYWEQy5Lxns/c=; b=sGPN3th1cmSd3gPFhaUMp/l0JF3F5hWOWE41HZSXuPow/og/6xNFzdOX7rpa6swVxI0llV hstIyCkw7IYraIkt7XAofLt6Cdvkynwhy80+WM7mdZaG9uKqYtinlr1ucfClRuUs5LFJp+ ODuibrtTNtosMGA0ck6GX4LNgwmhW9VArKVtOnKHY6ZEw0U+Xkqa2q4zIHMfIvmxAUU2DS tsWK7OJrs5352SDTQhSIeiciFku72j58ybaQmbnzPY7yh1pFrrrYSYKz1dgCRuuGKbDpta JfNSd7O6BBSzXh+iYw0wdLXfnfqt8ZHJNWl7s0VDY/AM4oc8IOz/dxef03fd9A== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=ahXAEWxi; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org ARC-Seal: i=1; s=key1; d=yhetil.org; t=1699195784; a=rsa-sha256; cv=none; b=hroKHNaobHQRP/h/2NkPD6FuZBAnI6VNgRFJMSV18KZA+hsDA/pqN63FzPpjN7Y/i9mjc5 Rt33fLSDVtE9L+fjL02QBeH4ppbB2iY0xY7+7ZYO5RSAHap+ojW4/+wAru0zMAooZeOqJ7 AUthG0vY9Ia1V3dn8FDujhuLS0JYIFqPL6OReyP32zGUx2euslYM1IgGOHm0TE3+keoOL7 710MVku2McjmWrCTg4O4LmOuRZQICGGeD0Z8uK7GFxtOQNOFr4T4TPeENOG89AvEDAeg7u moL07KW62H67SMzBJnqLAGE0/mrf1fYix3Ap3XMsQ+FGteA1YHwGhtbg4LLzjw== Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qzeRP-0001Se-9L; Sun, 05 Nov 2023 09:49:31 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qzeRJ-0001Rb-Qw for guix-patches@gnu.org; Sun, 05 Nov 2023 09:49:25 -0500 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qzeRI-0004Xm-Uj for guix-patches@gnu.org; Sun, 05 Nov 2023 09:49:25 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qzeRt-00058a-NV for guix-patches@gnu.org; Sun, 05 Nov 2023 09:50:01 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#66475] [PATCH v2 1/4] git-download: Add support for Git Large File Storage (LFS). Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sun, 05 Nov 2023 14:50:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 66475 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Maxim Cournoyer Cc: Josselin Poiret , Simon Tournier , Mathieu Othacehe , Tobias Geerinckx-Rice , 66475@debbugs.gnu.org, Ricardo Wurmus , Christopher Baines Received: via spool by 66475-submit@debbugs.gnu.org id=B66475.169919579319726 (code B ref 66475); Sun, 05 Nov 2023 14:50:01 +0000 Received: (at 66475) by debbugs.gnu.org; 5 Nov 2023 14:49:53 +0000 Received: from localhost ([127.0.0.1]:36411 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qzeRk-000585-PD for submit@debbugs.gnu.org; Sun, 05 Nov 2023 09:49:53 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:33902) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qzeRj-00057r-2v for 66475@debbugs.gnu.org; Sun, 05 Nov 2023 09:49:51 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qzeR2-0004WZ-9l; Sun, 05 Nov 2023 09:49:08 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To: From; bh=jqXnEfJpN9iQXxgxGNh3/C07uZPO3sdYWEQy5Lxns/c=; b=ahXAEWxiBXd3HZkD5YbS iUoBDA6yaTuXPdby3y5b1R9cm1VKjzyDMuqZ8uDkCf7NWR0cBjgzCdxc+Kb1cuOOjQcaHsFh6mPEN DqCklC6Jzm6i/3xHIBJZuRO9BukMRCr59VVIuQaIj+nSEjBvBwoOKu0QFAskUSaX/IOVaX4R8W3al SU9slNNdVzGr/AIbzog/T93cJ5V3fD32cX2AIDRTV4Mk53Kdg9TuAhpIQoeowiYRo+GW69SFiVE/o h9E0QWR7pN9W3wcSfdE2nqLbGAyPVCdsd4T6gHL1Gxni9qO8PeAXanmsKTNCvpU9/eP2KJBsC+v47 eK+ljipbQXnqcg==; From: Ludovic =?UTF-8?Q?Court=C3=A8s?= In-Reply-To: (Maxim Cournoyer's message of "Tue, 31 Oct 2023 16:25:14 -0400") References: X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: Quintidi 15 Brumaire an 232 de la =?UTF-8?Q?R=C3=A9volution, ?= jour du Dindon X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Sun, 05 Nov 2023 15:49:03 +0100 Message-ID: <87jzqw1cio.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Spam-Score: -5.31 X-Spam-Score: -5.31 X-Migadu-Queue-Id: 1CF9240348 X-Migadu-Scanner: mx13.migadu.com X-TUID: uOfUB+egjMFI Hi Maxim, Maxim Cournoyer skribis: > * guix/build/git.scm (git-fetch) [lfs?]: New argument, doc and setup code. > (git-fetch-with-fallback) [lfs?]: New argument. Pass it to git-fetch. > * guix/git-download.scm (git-lfs-package): New procedure. > (git-fetch/in-band*): New procedure, made of the logic of git-fetch/in-ba= nd, > with new git-lfs specifics, with the following changes: > New #:git-lfs argument. > : Remove labels. Conditionally add git-lfs. > : Read "git lfs?" environment > variable and pass its value to the #:lfs? argument of git-fetch-with-fall= back. > Use INPUTS directly; update comment. > derivation>: Add "git lfs?" to #:env-vars. > (git-fetch/in-band): Express in terms of git-fetch/in-band*. > (git-fetch/lfs): New procedure. > * doc/guix.texi (origin Reference): Document it. > > Change-Id: I5b233b8642a7bdb8737b9d9b740e7254a89ccb25 > --- > > Changes in v2: > - Do not add lfs? to ; instead add a git-fetch/lfs proced= ure. I haven=E2=80=99t tested it but it looks great to me, thank you! Ludo=E2=80=99.