From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:303:e16b::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms8.migadu.com with LMTPS id sGegHxwGbWXoTAEA9RJhRA:P1 (envelope-from ) for ; Sun, 03 Dec 2023 23:50:04 +0100 Received: from aspmx1.migadu.com ([2001:41d0:303:e16b::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id sGegHxwGbWXoTAEA9RJhRA (envelope-from ) for ; Sun, 03 Dec 2023 23:50:04 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 38C435CA47 for ; Sun, 3 Dec 2023 23:50:04 +0100 (CET) Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=Ian2fm9R; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Seal: i=1; s=key1; d=yhetil.org; t=1701643804; a=rsa-sha256; cv=none; b=mSOXwlfDMYmE8nlDatKc6jkoqqKCq9Z69VdvcWM4rUPtQJ2eV3G741ftf7xpKRrr4eYmOf VL/6TRGK9TmhhSoD7kOjsI4+gKNhulBRiN3NF5qkOX5rEPuEAxrIkGGoFRrUg8W99E5/iQ fcp4ZPEBgae/W0176KccB7WL7b+Nj08EPsfHbvM45m8akwSliYE9tSlKoD4lWtr5qYga0m dnGYEKRuLiNhb6AwLmUv4b/EB1JtaeHPM8sZ7MIcSosZl3w0OP0Tjei13TzEknJnty+aPm pj2+39jLg7t2DkrIT/uCMZvKx1woiJkevIAAEf0OnC17dK20DnsE8po5YSuLmQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=Ian2fm9R; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1701643804; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=R8qWmeXsmWzd+2oVCKXz15ZoqHINzeGUzh8qY4yU8i8=; b=QZ/HNERTBZ5F6C+JzpoDylLHtvS+CePkkdws3SK8vsAbugn30jK5Vs5N4tKyxl35CLiI4h kHai+wuYRI4VIUSvqWeMUfr62c7Dy69OSj3QFBgnGeHmWpeCYIYslObft1yZTQZ1Q7izBB Uxy6Z2+PxAkNNd4++rNYJNde/I2pPXEbGmSoxq8WRoGMWbag/+Gl236PPC0o5iL9iT3otU eIc9L06i9E955cVWtsHIBAu9J+pOwWBPE/BE4uNYZ6pBS5QF9sBk18CvJ/pe2BI5F0laEH vzdFeOBcF2tnts0mWEx14h7CSeYCT2XSB9rq7LX18P2xnNagUgT/d6KmmOnzFw== Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1r9vHg-00040M-6e; Sun, 03 Dec 2023 17:49:56 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r9vHd-0003zZ-Gk for guix-patches@gnu.org; Sun, 03 Dec 2023 17:49:53 -0500 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1r9vHb-0004UL-Iz for guix-patches@gnu.org; Sun, 03 Dec 2023 17:49:53 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1r9vHl-0002Bz-Mf for guix-patches@gnu.org; Sun, 03 Dec 2023 17:50:01 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#67505] [PATCH] build/go: Don't use set! Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sun, 03 Dec 2023 22:50:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 67505 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Efraim Flashner Cc: 67505@debbugs.gnu.org, Katherine Cox-Buday Received: via spool by 67505-submit@debbugs.gnu.org id=B67505.17016437648362 (code B ref 67505); Sun, 03 Dec 2023 22:50:01 +0000 Received: (at 67505) by debbugs.gnu.org; 3 Dec 2023 22:49:24 +0000 Received: from localhost ([127.0.0.1]:33013 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r9vHA-0002Am-G7 for submit@debbugs.gnu.org; Sun, 03 Dec 2023 17:49:24 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:35418) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r9vH8-0002AY-MT for 67505@debbugs.gnu.org; Sun, 03 Dec 2023 17:49:23 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r9vGs-0004PY-Jy; Sun, 03 Dec 2023 17:49:07 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To: From; bh=R8qWmeXsmWzd+2oVCKXz15ZoqHINzeGUzh8qY4yU8i8=; b=Ian2fm9RVkdMTSSH0wun RkiV4TNWm8VpA8GZHy6aJaN3kP4/plcxorTl5FsGrOOZ1RWEj2GkyOVJRqDVpNhi8m4dLtYn6E2V6 v07L3xuwMwonIm6iPrWTF26CEz+mQl29UOeK4nSbYUEwGWU69dSDesY6EPxy/mJDnH+wAWcPKSJhn RdB8V6IXbbr/NhFxVSgH0b8vPydUhR90QLqe4GaUcPzRJPoaCP4TjUtthRf+OihdZOxURnHEnGE4s eFxzbIJO5dfRYH5LpFxJJgE2No9zZc0SlIDwYN2sC7pOnwSpaw9t2XtZcPjZVw8uVNfsFIqbLm1dD 7niO6sBOMXPsSA==; From: Ludovic =?UTF-8?Q?Court=C3=A8s?= In-Reply-To: <92508cd851b013f54a799350082f49b157c7aebf.1701167049.git.efraim@flashner.co.il> (Efraim Flashner's message of "Tue, 28 Nov 2023 12:24:15 +0200") References: <92508cd851b013f54a799350082f49b157c7aebf.1701167049.git.efraim@flashner.co.il> Date: Sun, 03 Dec 2023 23:49:03 +0100 Message-ID: <87jzpuewbk.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN X-Migadu-Scanner: mx13.migadu.com X-Migadu-Spam-Score: -6.84 X-Spam-Score: -6.84 X-Migadu-Queue-Id: 38C435CA47 X-TUID: +vkWf9zFdX2+ Efraim Flashner skribis: > This causes build failures on powerpc-linux. > > * guix/build/go-build-system.scm (unpack): When the unpack-path is unset > use the import-path but don't redefine the unpack-path. > > Change-Id: I2b5a36eb738abb14307941d388038139dbaf2bdf [...] > - (when (string-null? unpack-path) > - (set! unpack-path import-path)) > - (let ((dest (string-append (getenv "GOPATH") "/src/" unpack-path))) > + (let ((dest (string-append (getenv "GOPATH") "/src/" > + (if (string-null? unpack-path) > + import-path > + unpack-path)))) Could you adjust indentation of the =E2=80=98if=E2=80=99 arms? Otherwise LGTM, thanks! Ludo=E2=80=99.