From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2.migadu.com ([2001:41d0:700:3204::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms8.migadu.com with LMTPS id iG1VGUOal2VT5wAAkFu2QA (envelope-from ) for ; Fri, 05 Jan 2024 06:57:23 +0100 Received: from aspmx1.migadu.com ([2001:41d0:403:58f0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2.migadu.com with LMTPS id EA8bEUOal2V0fwAAe85BDQ (envelope-from ) for ; Fri, 05 Jan 2024 06:57:23 +0100 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1704434243; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post; bh=Dj7unDJT/B1FXSg186cTULPsFZfcnq/JnjKURAwyo7o=; b=blRRjIOkQyelMCVnws2pTHvJEQ4MyBJUnQz+JuMCrqnUVvU5m5AxGkcNAtqzwQeiXVK65u 8pYw32VAZOs20Efapo9+eFIa91MXloJ4UuqpQvid13heHyJpvze+noYGD2iFMHgufMlKvw Ms5HdK/6sDSapXE9X4riUI7B5cNX110g4x/X6i+vjHpKZu2Pl+kUC/vsvr+8YKCoWjM5/+ FwRk7/HMcB1BjVJfqcldnsyHoRR+SpHKrMHKmQXz0lopVA4RHMTLNuReqBr6VVwBvro9lt 2yCET92h8BNpKAs4PkZBRoh46KsMFl6mSPWtnv5+CbRZ/umX/mR/XkvWJ023vg== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1704434243; a=rsa-sha256; cv=none; b=mXnlCh7v1uTsZC7OcAmTk0h3hL0a9iED8/7Kq+7H6JSqa8FJwgrs9n1XEzyqE1VcvaqVKP lWJhpwc/51TP9ZXutIyLGW7GuJpZ2o7+ek2huLSHGvwcMXzF3jnDbUwNdxMvEwkPqn4w1n 6jCN6YR486Rj3T1St93hvXfhUcmjuKvgboi+dmt8TZZr/Sn5ScVTsJMJUbqLg4dsp2kfZp /02paT1RyRf6K4YVmGl5pRV38AVBs7y8/78YZkWbKVF/Ca4xTO6r2NtwHytFGBcK/LjXAs NdZeZbPqcaI6WKgs649ccxS79PVZXNhZBOosJh9RIGQjGarsGUNYQ7eN7DJQ5Q== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=none Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 905D9396BA for ; Fri, 5 Jan 2024 06:57:21 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rLdCY-0002gn-9F; Fri, 05 Jan 2024 00:57:02 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rLdCU-0002gH-Vr for guix-patches@gnu.org; Fri, 05 Jan 2024 00:56:58 -0500 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rLdCU-0001fa-Nm for guix-patches@gnu.org; Fri, 05 Jan 2024 00:56:58 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rLdCY-0000yg-QU for guix-patches@gnu.org; Fri, 05 Jan 2024 00:57:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#67903] [PATCH] gnu: libcgroup: Update to 3.1.0. Resent-From: Zheng Junjie Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 05 Jan 2024 05:57:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 67903 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Hilton Chain Cc: 67903@debbugs.gnu.org, Tobias Geerinckx-Rice , Leo Famulari Received: via spool by 67903-submit@debbugs.gnu.org id=B67903.17044341723669 (code B ref 67903); Fri, 05 Jan 2024 05:57:02 +0000 Received: (at 67903) by debbugs.gnu.org; 5 Jan 2024 05:56:12 +0000 Received: from localhost ([127.0.0.1]:56193 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rLdBi-0000x4-CB for submit@debbugs.gnu.org; Fri, 05 Jan 2024 00:56:12 -0500 Received: from smtp81.cstnet.cn ([159.226.251.81]:59800 helo=cstnet.cn) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rLdBd-0000wR-74 for 67903@debbugs.gnu.org; Fri, 05 Jan 2024 00:56:09 -0500 Received: from m (unknown [183.247.5.190]) by APP-03 (Coremail) with SMTP id rQCowACnr7vjmZdlHxKZAw--.51109S2; Fri, 05 Jan 2024 13:55:49 +0800 (CST) References: <696e1a46af20d62029c36f5e2ad2c2ff22c0485f.1702995464.git.hako@ultrarare.space> <1801D85C-6E02-44E8-91B8-C5EF79DD6173@yandex.com> <87o7e05p3p.wl-hako@ultrarare.space> User-agent: mu4e 1.10.8; emacs 30.0.50 From: Zheng Junjie Date: Fri, 05 Jan 2024 13:45:36 +0800 In-reply-to: <87o7e05p3p.wl-hako@ultrarare.space> Message-ID: <87jzoomiho.fsf@iscas.ac.cn> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-CM-TRANSID: rQCowACnr7vjmZdlHxKZAw--.51109S2 X-Coremail-Antispam: 1UD129KBjvJXoWxJr4kWryrGw45Kw4DXF4kXrb_yoW8uFyrp3 yrZFnFka1Fg3yrXwsrtanF9F1Y9r1jkr1rur98Ja4UK39Fvr9YvrW2yr4fCFnrZr1xuw42 vry8A3WSgry5JaDanT9S1TB71UUUUUUqnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDU0xBIdaVrnRJUUUy2b7Iv0xC_KF4lb4IE77IF4wAFF20E14v26r1j6r4UM7CY07I2 0VC2zVCF04k26cxKx2IYs7xG6rWj6s0DM7CIcVAFz4kK6r1j6r18M28lY4IEw2IIxxk0rw A2F7IY1VAKz4vEj48ve4kI8wA2z4x0Y4vE2Ix0cI8IcVAFwI0_Xr0_Ar1l84ACjcxK6xII jxv20xvEc7CjxVAFwI0_Gr0_Cr1l84ACjcxK6I8E87Iv67AKxVW8Jr0_Cr1UM28EF7xvwV C2z280aVCY1x0267AKxVW8Jr0_Cr1UM2AIxVAIcxkEcVAq07x20xvEncxIr21l5I8CrVAC Y4xI64kE6c02F40Ex7xfMcIj6xIIjxv20xvE14v26r1j6r18McIj6I8E87Iv67AKxVWUJV W8JwAm72CE4IkC6x0Yz7v_Jr0_Gr1lF7xvr2IY64vIr41l42xK82IYc2Ij64vIr41l4I8I 3I0E4IkC6x0Yz7v_Jr0_Gr1lx2IqxVAqx4xG67AKxVWUJVWUGwC20s026x8GjcxK67AKxV WUGVWUWwC2zVAF1VAY17CE14v26r126r1DMIIYrxkI7VAKI48JMIIF0xvE2Ix0cI8IcVAF wI0_Jr0_JF4lIxAIcVC0I7IYx2IY6xkF7I0E14v26r1j6r4UMIIF0xvE42xK8VAvwI8IcI k0rVWUJVWUCwCI42IY6I8E87Iv67AKxVWUJVW8JwCI42IY6I8E87Iv6xkF7I0E14v26r1j 6r4UYxBIdaVFxhVjvjDU0xZFpf9x07jOb18UUUUU= X-Originating-IP: [183.247.5.190] X-CM-SenderInfo: x2kh0wxmxqyx3h6l2u1dvotugofq/ X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Spam-Score: -6.27 X-Spam-Score: -6.27 X-Migadu-Queue-Id: 905D9396BA X-Migadu-Scanner: mx11.migadu.com X-TUID: Acl76GZ5vWgD Hilton Chain writes: > Hi, > > On Sun, 24 Dec 2023 13:27:13 +0800, > =E9=83=91=E4=BF=8A=E6=9D=B0 wrote: >> >> >> >> > =E5=9C=A8 2023=E5=B9=B412=E6=9C=8819=E6=97=A5=EF=BC=8C22:51=EF=BC=8CHi= lton Chain via Guix-patches via =E5=86=99=E9=81=93= =EF=BC=9A >> > >> > =EF=BB=BF* gnu/packages/linux.scm (libcgroup): Update to 3.1.0. >> > [arguments]<#:configure-flags>: Disable systemd. >> > >> > Change-Id: I67fe380ebdf91ca254b3365b7f237a3d9ad4f0a5 >> > --- >> > gnu/packages/linux.scm | 7 ++++--- >> > 1 file changed, 4 insertions(+), 3 deletions(-) >> > >> > diff --git a/gnu/packages/linux.scm b/gnu/packages/linux.scm >> > index 3ca756dead..c4c366e21f 100644 >> > --- a/gnu/packages/linux.scm >> > +++ b/gnu/packages/linux.scm >> > @@ -8798,7 +8798,7 @@ (define-public fbgrab >> > (define-public libcgroup >> > (package >> > (name "libcgroup") >> > - (version "2.0.2") >> > + (version "3.1.0") >> > (home-page "https://github.com/libcgroup/libcgroup") >> > (source >> > (origin >> > @@ -8806,14 +8806,15 @@ (define-public libcgroup >> > (uri (string-append home-page "/releases/download/v" >> > version "/" name "-" version ".tar.gz")) >> >> Can we switch to git-fetch? > > Is there any good reason? if use git-fetch, allow `guix build libcgroup --with-{branch,commit,git-url} ...` work. > >> And don=E2=80=99t use home-page in source. > > No problem. > >> > (sha256 >> > - (base32 "1y0c9ncsawamj77raiw6qkbm5cdsyvhjb2mvgma1kxmgw0r3pxlf= ")))) >> > + (base32 "0n0jkvmagw14vgwx3j5b6vv5h25lasrg2a7xihq9h11ww2qw8vlp= ")))) >> > (build-system gnu-build-system) >> > (arguments >> > ;; Tests are virtualized with lxc, it is not very feasible >> > ;; to make them executable under guix build. Also, note that >> > ;; origin is using source tarball release which is prepared >> > ;; after testing. >> > - `(#:tests? #f)) >> > + `(#:tests? #f >> > + #:configure-flags '("--disable-systemd"))) >> >> Maybe use gexp. > > Will add in a later commit. > >> > (native-inputs >> > (list bison flex)) >> > (inputs >> > >> > base-commit: fa92a7c2fe0c5b9e9923ad5f53bafd41aa6dbe66 >> > -- >> > 2.41.0 >> >> Other LGTM > > Thanks for the review!