From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1.migadu.com ([2001:41d0:403:4876::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms8.migadu.com with LMTPS id ICN6GjqFzmU58QAA62LTzQ:P1 (envelope-from ) for ; Thu, 15 Feb 2024 22:42:18 +0100 Received: from aspmx1.migadu.com ([2001:41d0:403:4876::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1.migadu.com with LMTPS id ICN6GjqFzmU58QAA62LTzQ (envelope-from ) for ; Thu, 15 Feb 2024 22:42:18 +0100 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=troyfigiel.com header.s=MBO0001 header.b=GFhF0qVe; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=troyfigiel.com (policy=none) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1708033338; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=x4cLnaoh07p2oZRVlr9G364AmVHqDfhABM2R9RkioVs=; b=scBrCPjNwWn08mB3yju42a/kyOL33OSedCd+SSSQuDHsq+P+iVOv6+SE67UGQTJ/95GAde 0q58q+xLcWZnnAC/sK+aT8V5wmodjb/JFfk99hFIphuOyrtQ/SefWNPyt04AcGrkA20B0O eXbyByWpttSMa486mysK30Y/+BVNzxWMFOldKcHzFV8MN3GIB8SiRA+awh/IYuoHOCOk56 Vmm1mfg8L0K0WQGOkXUcKZs8wpXuLK8vnpUXRBawTFb9xF2ZC5yoScFlPtK+EbTQxxIw0c TfJiPBtFC/RA6ylbM8EydkP+tpxXjt6B7ZNTjg6EvuPFx+NSahVhzZFzhfclcg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=troyfigiel.com header.s=MBO0001 header.b=GFhF0qVe; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=troyfigiel.com (policy=none) ARC-Seal: i=1; s=key1; d=yhetil.org; t=1708033338; a=rsa-sha256; cv=none; b=Xqz2WmaKqqfUKvLMv+AjLYAPftZF0aWfYOWU2+snMYlye7G1rKdcnjKLbs8VzAyRrMi4Al QiF4uV6U//tA87umfzDsC/iJ4AUYceqHqkvQ0zNZHwvRRsK7ijFL6+z5qvsynJ0zk7AM0m rxRa0fbrhr9Zpi0/ZCyVlS1grWVwQkCcij16VkA3lT4RnDvl74SDG3LXdMfScDnlQiPaw8 uN1Cc5fZaL4IOSZUtS9LY1F6ae3CFxvd5eYkVAKnGhqweZZKrH5cWfOv0LPRp3Ywe6wnYY KgpNOuu29CSgtViTtBYQSCOk2yP/9wgjvTNBJ1qmstIA/M0S6Qi8jdb975phuw== Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id ED4D56FF7A for ; Thu, 15 Feb 2024 22:42:17 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rajUN-0005Eh-0M; Thu, 15 Feb 2024 16:41:51 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rajUI-0005EB-42 for guix-patches@gnu.org; Thu, 15 Feb 2024 16:41:46 -0500 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rajUH-0004kI-Ru; Thu, 15 Feb 2024 16:41:45 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rajUX-0006br-KE; Thu, 15 Feb 2024 16:42:01 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#69074] [PATCH] Add python-angr. Resent-From: Troy Figiel Original-Sender: "Debbugs-submit" Resent-CC: lars@6xq.net, marius@gnu.org, me@bonfacemunyoki.com, sharlatanus@gmail.com, jgart@dismail.de, guix-patches@gnu.org Resent-Date: Thu, 15 Feb 2024 21:42:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 69074 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 69074@debbugs.gnu.org Cc: lars@6xq.net, marius@gnu.org, me@bonfacemunyoki.com, sharlatanus@gmail.com, jgart@dismail.de X-Debbugs-Original-Xcc: lars@6xq.net, marius@gnu.org, me@bonfacemunyoki.com, sharlatanus@gmail.com, jgart@dismail.de Received: via spool by 69074-submit@debbugs.gnu.org id=B69074.170803326425344 (code B ref 69074); Thu, 15 Feb 2024 21:42:01 +0000 Received: (at 69074) by debbugs.gnu.org; 15 Feb 2024 21:41:04 +0000 Received: from localhost ([127.0.0.1]:57612 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rajTb-0006ah-RF for submit@debbugs.gnu.org; Thu, 15 Feb 2024 16:41:04 -0500 Received: from mout-p-102.mailbox.org ([80.241.56.152]:37414) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rajTY-0006a3-GT for 69074@debbugs.gnu.org; Thu, 15 Feb 2024 16:41:02 -0500 Received: from smtp102.mailbox.org (smtp102.mailbox.org [10.196.197.102]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-p-102.mailbox.org (Postfix) with ESMTPS id 4TbT4L665Nz9sd9 for <69074@debbugs.gnu.org>; Thu, 15 Feb 2024 22:40:02 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=troyfigiel.com; s=MBO0001; t=1708033202; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=x4cLnaoh07p2oZRVlr9G364AmVHqDfhABM2R9RkioVs=; b=GFhF0qVeTbr/yZtHJ9AjlStJZA6UgPj+vjp9wwIheGxNSnMfy7xp87p3Ox72on6T5wDEPq Hf/4LqVoJmpLgh4MKrfj2L2KfTjNtUMZewX6gNHVG3se9aCecjkbH4WcLQdBbOgAuJYIIP g8WLQd9uwKZMxEiJn0kkkXaE/9SW+fJlfVNAMWnDX8wmeo4M2ZkpKh7cuGOJpwXoN8FuWY bnPOXFiLZBCDClaNtEpZ+xehKtvXCzBqT9XsxKG3un8GE8gF05WKr986HyIdM5exebw8DT tUOXmuCw0pEdPuPxaOIBp90bI+N339N+vJE/bke8b/J3fY68mrNZBELpM+OwhQ== From: Troy Figiel In-Reply-To: (Troy Figiel's message of "Tue, 13 Feb 2024 12:52:41 +0100") References: <2T2LBWR63TVNP.3NFUJ8AHKFC01@8pit.net> Date: Thu, 15 Feb 2024 22:39:39 +0100 Message-ID: <87jzn5be5g.fsf@troyfigiel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Scanner: mx10.migadu.com X-Migadu-Spam-Score: -3.61 X-Spam-Score: -3.61 X-Migadu-Queue-Id: ED4D56FF7A X-TUID: VuXuG8TR3MzJ Hi S=C3=B6ren, A couple points regarding back ports and versions: I see that you back ported some upstream patches. I tend to use patches more as a last resort and whenever possible I stick to upstream versions and commits (in that order of preference). I find this makes the life of future developers easier, as back ports might not apply cleanly to newer versions. I will attach a new patch for python-pysmt as an example. It seems everything still built successfully (please check whether this works as expected). I fixed up the description a bit and set the env variables in a separate phase as well. I believe upgrading to a later commit might work for capstone, python-angr and python-pyvex, which also have back ported patches. For python-angr and python-pyvex, I noticed you set them to version 9.2.46, but this is not the latest version. Is there a reason we cannot upgrade past this version? Could you add a comment mentioning what prevents such an upgrade if so? The versions of all other angr packages you added are also set to 9.2.46. It looks like this is on purpose, or not? If they all need the exact same versions to work, could you add a comment (for each package) that says something like "python-ailment, python-angr, python-archinfo, python-claripy, python-cle and python-pyvex need to be set to the same version"? Some minor points: - AFAIK assoc-ref is the old way of referring to inputs. With G-exps you wo= uld, for example, replace (assoc-ref inputs "binaries") in python-angr by s= omething like #$(this-package-native-input "binaries"). - You can clean up the check phase for python-angr using test flags. I will= add a patch as an example as well. - Regarding binaries, I am honestly not sure how these would be best handle= d. They are binaries, but without them there might not be much to test anyw= ay... A second opinion would be good here. Hope this helps! The rest LGTM. I will ping the Python team, so someone wit= h commit rights can have a look. Best wishes, Troy