From: Richard Sent <richard@freakingpenguin.com>
To: Dariqq <dariqq@posteo.net>
Cc: 71659@debbugs.gnu.org
Subject: [bug#71659] [PATCH] gnu: Add fastfetch.
Date: Thu, 20 Jun 2024 14:34:07 -0400 [thread overview]
Message-ID: <87jzijqx9c.fsf@freakingpenguin.com> (raw)
In-Reply-To: <efed8e86-8141-4415-b8bf-8cb96da6c031@posteo.net> (dariqq@posteo.net's message of "Thu, 20 Jun 2024 18:00:45 +0000")
Hi Dariqq
>> Sounds like yours is a lot more complete. I think it is best to merge
>> your version. What else is left to do?
>>
>
> I would not really like hijacking the patch like this from you. But i'll
> happily share what I have so far:
Gotcha. I'll try to spend some more time on this in the next couple
weeks, but feel free to claim it for yourself! After all, to me it feels
a lot more like I hijacked your patch than the other way around 🙂. No
hard feelings.
> my yyjson package:
>
> I am not sure where to put this? just c.scm? or somewhere else?
> In the debian package they also build html docs. Tried that but they
> were not automatically installed with the standard phases and i am not
> sure if they are worth it. (maybe in a seperate output?)
c.scm sounds like the right place to me. I'll keep the documentation
thing in mind.
> For fastfetch i am following the nixos package to enable everything but
> mesa and directx. Also these are a lot of them and with the wrapper
> guix install fastfetch would need to also download all of the other
> libraries. It would be great to create more modular packages for
> something like this as enabling everything like this will e.g now always
> pull in xfconf (only needed when using xfce), the x11/wayland libraries
> even if one is on a headless server, etc. I guess that is a beneift for
> dlopen but does not really work well on guix system.
I agree, I think this package would benefit from a -minimal version or
some similar structure with variants.
> network-manager
I wonder if adding the network-manager plugin can cause issues on
systems that don't use it. (e.g. connman). I'd be a little worried
they'd start fighting.
>> Is there anything I can help with?
>
> I have built with "-DBINARY_LINK_TYPE=dynamic" to dynamically link the
> dependencies instead. There was an error due to fastfetch wanting a
> newer version of ddcutil. Havent looked into how complicated that is to
> update yet.
>
> On a related note dynamically linking would avoid the (kind of awkward)
> wrapper. Are there benefits/downsides to using that instead?
I'm no expert but dynamic linking sounds like a better solution to me
than a wrapper + dlopen. Disabling runtime linking seems to be a
semi-common thing in packages. Maybe we'll get lucky and ddcutil can be
updated without any breakages.
> I hope the formating turned out ok for the code blocks
Looks great.
--
Take it easy,
Richard Sent
Making my computer weirder one commit at a time.
next prev parent reply other threads:[~2024-06-20 18:35 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-20 2:33 [bug#71659] [PATCH] gnu: Add fastfetch Richard Sent
2024-06-20 15:45 ` Dariqq
2024-06-20 15:59 ` Richard Sent
2024-06-20 18:00 ` Dariqq
2024-06-20 18:34 ` Richard Sent [this message]
2024-06-21 10:56 ` Dariqq
2024-06-28 12:54 ` [bug#71659] Attribution Andreas Enge
2024-06-30 9:00 ` bug#71659: Close Andreas Enge
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87jzijqx9c.fsf@freakingpenguin.com \
--to=richard@freakingpenguin.com \
--cc=71659@debbugs.gnu.org \
--cc=dariqq@posteo.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.