From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1.migadu.com ([2001:41d0:303:e16b::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms13.migadu.com with LMTPS id qFXpGK72jWb5LAEA62LTzQ:P1 (envelope-from ) for ; Wed, 10 Jul 2024 02:49:18 +0000 Received: from aspmx1.migadu.com ([2001:41d0:303:e16b::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1.migadu.com with LMTPS id qFXpGK72jWb5LAEA62LTzQ (envelope-from ) for ; Wed, 10 Jul 2024 04:49:18 +0200 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20230601 header.b="YPr/5+iF"; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1720579758; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=/gtsa9YBCyVKW1zx9CuYP5/QWRVUcLev8cFroY3Ti+s=; b=MhKqBcl5ixYNE5iGTE3ZWgHqZ91judsH3rUxuXLBYFjzLGkibzUittiZ46AOeKpJplmb25 ZNkvu6tQ3peBpRAFKWpn1sw7udWSK6HKz/cxC61ZV5sYnjPcWZHqyuQBWuzR/du8ORN6ET pAR2vL1Lz8y1nyS1cEHj6OjW1OCjKvRYc/ChYZFNr3Di19gJJm5cXjE66e3jQJAf/Fbu1/ G3RX+n5aRwnDr133uuST795G8Io7eCIFvpMJsjL7jp4ORs1TLx+o7AFk5B4pExIux8q48+ uurT2Qd2z697JKBki95//AaRzPVc289El0rGzcsJNvkmbcu8O+/USUajPCnG2g== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20230601 header.b="YPr/5+iF"; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none) ARC-Seal: i=1; s=key1; d=yhetil.org; t=1720579758; a=rsa-sha256; cv=none; b=iIX0Qo7DVUomkwRsGQgEgyzZzQFkEkx3b/1/Srjnog/xT2CzDaTFCxGJDtReyNZMMLy2AF rGgio+qFo7dsk9s7Nj81+Lhywvpd5j086nOTsNaas0a8EP29f1V3Ny8QegjAAsEvWwJ7WW cdYz6leHa5FEfBzDevXuiemawLPnhFckGe87q0EpWcTOEZAfMlntGSyWBWzsdCli6VQEHv O34rESCJrJ8qmdFq7QO2cffSUnMvXw2WMOQAqL6YVCQyudwwE205P5kJUCm67C38V7d+6Y mFyKJHO1VUlxlPydBCaJOpPNiJKdoI5Ph/oHVrAaZTut3QeZAyDzaVxL5wuAKg== Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 017BD14218 for ; Wed, 10 Jul 2024 04:49:17 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sRNO5-0007qQ-SK; Tue, 09 Jul 2024 22:48:57 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sRNO4-0007qC-8Z for guix-patches@gnu.org; Tue, 09 Jul 2024 22:48:56 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sRNO4-0005n7-0T for guix-patches@gnu.org; Tue, 09 Jul 2024 22:48:56 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sRNO9-000772-QV for guix-patches@gnu.org; Tue, 09 Jul 2024 22:49:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#65031] [PATCH v3] gnu: Add syncplay. Resent-From: Maxim Cournoyer Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 10 Jul 2024 02:49:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 65031 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: moreinfo patch To: aurtzy Cc: 65031@debbugs.gnu.org Received: via spool by 65031-submit@debbugs.gnu.org id=B65031.172057969127211 (code B ref 65031); Wed, 10 Jul 2024 02:49:01 +0000 Received: (at 65031) by debbugs.gnu.org; 10 Jul 2024 02:48:11 +0000 Received: from localhost ([127.0.0.1]:54597 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sRNNJ-00074j-A5 for submit@debbugs.gnu.org; Tue, 09 Jul 2024 22:48:11 -0400 Received: from mail-qt1-f178.google.com ([209.85.160.178]:48600) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sRNNE-00073y-5s for 65031@debbugs.gnu.org; Tue, 09 Jul 2024 22:48:07 -0400 Received: by mail-qt1-f178.google.com with SMTP id d75a77b69052e-449537c62d1so4452411cf.1 for <65031@debbugs.gnu.org>; Tue, 09 Jul 2024 19:47:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1720579612; x=1721184412; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=/gtsa9YBCyVKW1zx9CuYP5/QWRVUcLev8cFroY3Ti+s=; b=YPr/5+iFVXzzVd+++uSuY9P57b0DZIRjhxmYOFHA6nMvy/MSzQtCkvOQfnxlJ1Jg/k hjU1gY/8mTx/znWL6RJ0lNnH9Ot38qnU0hdTOb+/R1VARN1ealzNjXvLvTgC5cBGPwUH xwhvouoz0RYHmjVrpynQ/4/MOUqvWtkOvtaKFvFHoEPMzmTFSgbLEY6JwjlmpFlvbwcU 1WZlqix3w+FfNO6Q0b3kdYL0ql7mWVxtZcKg65flvEnzfPRNEsc8+RMEnS50CFl6F1kf 23dJRxb0Aii7/BrWOHm3oASgz/g7/2Vv4+Wog8p0bHzrgz7kiz754a8uN45lmUyahcoa 9ddg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1720579612; x=1721184412; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=/gtsa9YBCyVKW1zx9CuYP5/QWRVUcLev8cFroY3Ti+s=; b=t+LCunU+ztqNMtQelZY5V8e69NC0saken6HnKT/GlKA2ZR9geXL9dk/Efb3vnRF+BS b3a8IOhnhHB95UF9SzhxITkBkiO/X/EPf8lqCyHnm0JMcwrNGaq9xikbqVbqvZsJx8K1 gambiQ6sRRJMNsJiVAcqAQ0yJteceASsXn4jB7ZRB/DWGHTce6099g/ZyljE8dX3UXEm lvqallN6k5FKlDS4eHmEnndtjZNiezgDZOD6Sr3qBCcgSnrSVVLkyV/YUEzkp7Q+lh63 8LbRySyO3hP1phJnIfjbMSCNVbjPnH+rZPpIOBcVETAWg+MId3FyBdMBCc2HhHKP71R3 LmCw== X-Gm-Message-State: AOJu0Yz5UT8ck5Wc1VoVDCCQj1hZ7D9cc6XKosXHP2YGMuu53ShFV4OK gcCpixNuxhAtmyxYB5AAM0L6N72MStak4r1R2tYgBBIZG5U8FUrtaGhiSg== X-Google-Smtp-Source: AGHT+IEp0A8nzeeydPHQBOxfxeQSCwlNEIyqQwU+F9mqNACgDzMgiV+ykMu7iRgEdb8ROwXdME/2nw== X-Received: by 2002:a05:622a:1a9f:b0:446:5538:40e1 with SMTP id d75a77b69052e-447fa86961fmr49027511cf.17.1720579611792; Tue, 09 Jul 2024 19:46:51 -0700 (PDT) Received: from hurd (dsl-205-236-230-124.b2b2c.ca. [205.236.230.124]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-447f9bf8d06sm16109251cf.97.2024.07.09.19.46.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 09 Jul 2024 19:46:51 -0700 (PDT) From: Maxim Cournoyer In-Reply-To: (aurtzy@gmail.com's message of "Sat, 29 Jun 2024 17:37:55 -0400") References: <20230803061517.27336-1-aurtzy@gmail.com> Date: Tue, 09 Jul 2024 22:46:50 -0400 Message-ID: <87jzhuufol.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN X-Migadu-Queue-Id: 017BD14218 X-Migadu-Scanner: mx13.migadu.com X-Migadu-Spam-Score: -5.30 X-Spam-Score: -5.30 X-TUID: Q++/RfvkuXEk Hello! aurtzy writes: > * gnu/packages/video.scm (syncplay): New variable. > > Change-Id: I72cdfa3db2b4b7ef6c3ef0b8585d138c272046a7 > --- > > Hi Maxim, > > Just got around to looking at this package again with a new patch as thin= gs > have changed since my last reply (and I didn't cc you before, oops..). > > In addition to addressing your initial review, notable changes from v2 > include: > > - Update to current latest version of Syncplay (1.7.3). > - Patch is no longer needed. > - This patch puts syncplay in (gnu packages video) instead of the previous > (gnu packages networking) since the latter seemed more concerned with > system-level networking. Does this make sense? It does make sense :-). This sounds good. [...] > gnu/packages/video.scm | 54 ++++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 54 insertions(+) > > diff --git a/gnu/packages/video.scm b/gnu/packages/video.scm > index 411ad4c2bf..57a05f3eff 100644 > --- a/gnu/packages/video.scm > +++ b/gnu/packages/video.scm > @@ -68,6 +68,7 @@ > ;;; Copyright =C2=A9 2023 Saku Laesvuori > ;;; Copyright =C2=A9 2023 Jaeme Sifat > ;;; Copyright =C2=A9 2023 Zheng Junjie <873216071@qq.com> > +;;; Copyright =C2=A9 2024 aurtzy > ;;; > ;;; This file is part of GNU Guix. > ;;; > @@ -6349,3 +6350,56 @@ (define-public svtplay-dl > broadcasters including SVT Play, Sveriges Radio, TV4 Play, along with ma= ny > others.") > (license license:expat))) > + > +(define-public syncplay > + (package > + (name "syncplay") > + (version "1.7.3") > + (source > + (origin > + (method git-fetch) > + (uri (git-reference > + (url "https://github.com/Syncplay/syncplay") > + (commit (string-append "v" version)))) > + (file-name (git-file-name name version)) > + (sha256 > + (base32 "08bgndszja4n2kql2qmzl6qrzawxvcwmywsc69lq0dzjnpdk96la"))= )) > + (build-system python-build-system) > + (arguments > + (list > + #:imported-modules `(,@%python-build-system-modules > + (guix build qt-utils) > + (guix build utils)) > + #:modules '((guix build python-build-system) > + (guix build qt-utils) > + (guix build utils)) > + #:phases #~(modify-phases %standard-phases > + (delete 'check) > + (replace 'install > + (lambda _ > + (invoke "make" "install" "DESTDIR=3D" > + (string-append "PREFIX=3D" > + #$output)))) > + (add-after 'install 'wrap-qt > + (lambda* (#:key inputs #:allow-other-keys) > + (wrap-qt-program "syncplay" > + #:output #$output > + #:inputs inputs > + #:qt-major-version "6")))))) > + (native-inputs (list python-pyside-6)) > + (inputs (list bash-minimal > + python-certifi > + python-idna > + python-service-identity > + python-twisted > + qtwayland)) > + (home-page "https://syncplay.pl") > + (synopsis "Client/server to synchronize media playback on many compu= ters") > + (description > + "Syncplay is a solution to synchronize video playback across multip= le > +instances of media players over the Internet. When one person pauses/un= pauses > +playback or skips to a position in the video, this is replicated across = all > +media players connected to the same server and in the same \"room\" (vie= wing > +session). A built-in text chat for discussing the synced media is also > +included for convenience.") > + (license license:asl2.0))) > > base-commit: 78b881722f08325c76096557313a0faee847c66f This looks well crafted! Thank you! Reviewed-by: Maxim Cournoyer