all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Cayetano Santos via Guix-patches via <guix-patches@gnu.org>
To: control@debbugs.gnu.org,73918@debbugs.gnu.org
Subject: [bug#73918] QA review for 73918
Date: Sat, 02 Nov 2024 09:42:08 +0100	[thread overview]
Message-ID: <87jzdm9gdb.fsf@inventati.org> (raw)
In-Reply-To: <4da104f41f60809288973a250f258ddb724616c3.1729460353.git.jakob.kirsch@web.de>


user guix
usertag 73918 + waiting-on-contributor
thanks

Guix QA review form submission:

- There is a missing dot at the end of commit message in v2 1/2

- If you send a v3, it’s better to include a link to the commit
  introducing the error you’re fixing in the body of the commit message

    https://git.savannah.gnu.org/cgit/guix.git/commit/?id=b32f8bc9da

- [linter yosys] : "bash-minimal" should be in 'inputs' when
  'wrap-program' is used, you’ll need also

    #:use-module (gnu packages bash)

Other than this, it builds and executes with no issue

Thanks for fixing the error !

Items marked as checked: Commit messages, Package builds, Lint warnings




      parent reply	other threads:[~2024-11-02  8:43 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-20 21:39 [bug#73918] [PATCH v1 1/2] gnu: iverilog: Fix yosys tests Jakob Kirsch via Guix-patches via
2024-10-20 21:47 ` [bug#73918] [PATCH v2 " Jakob Kirsch via Guix-patches via
2024-10-20 21:48   ` [bug#73918] [PATCH v2 2/2] gnu: yosys: Update to 0.46 Jakob Kirsch via Guix-patches via
2024-10-26 16:56 ` [bug#73918] [PATCH] " Denis 'GNUtoo' Carikli
2024-10-31 16:38 ` Jakob Kirsch via Guix-patches via
2024-11-01  7:27 ` [bug#73918] (no subject) Cayetano Santos via Guix-patches via
2024-11-02  8:42 ` Cayetano Santos via Guix-patches via [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87jzdm9gdb.fsf@inventati.org \
    --to=guix-patches@gnu.org \
    --cc=73918@debbugs.gnu.org \
    --cc=control@debbugs.gnu.org \
    --cc=csantosb@inventati.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.