From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1.migadu.com ([2001:41d0:403:4876::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms13.migadu.com with LMTPS id YNKBAB9zR2ct1wAA62LTzQ:P1 (envelope-from ) for ; Wed, 27 Nov 2024 19:29:35 +0000 Received: from aspmx1.migadu.com ([2001:41d0:403:4876::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1.migadu.com with LMTPS id YNKBAB9zR2ct1wAA62LTzQ (envelope-from ) for ; Wed, 27 Nov 2024 20:29:35 +0100 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=debbugs.gnu.org header.s=debbugs-gnu-org header.b=fs93u0hf; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20230601 header.b=AJt1oSF4; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Seal: i=1; s=key1; d=yhetil.org; t=1732735774; a=rsa-sha256; cv=none; b=oVAvPJBEVUVdu2WXrb5wP0uSdJ8mW1hYUgO29yzAN7eitoGdip/1pS9XZ7cdexLEDQDcvR 3jok8dSNSR5yyAtSS9OYeUTPnYsAedl8N1IJnehx3HjGDR1djYO9+d9jJ8fXwpdK/xXSKG Asbfq8oD1+0GuwS+uqi9Fo51OY9OFnI2a+n2FfIOEm/ieOHJOcB3GFOdzn+4LLBuJe12bo ivllNZy6kPuK1F80b6028nDYLM2wdHsD1+E9Ozzf6DrF/j+wLhHFbOIjU4Qz0ZaGt4uZAn GRgy/N5wXi8LrbrafRrRXPRE57pJS86MW7r5XRXGnd4LUlWnLP7SNbUQNbFvyg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=debbugs.gnu.org header.s=debbugs-gnu-org header.b=fs93u0hf; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20230601 header.b=AJt1oSF4; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1732735774; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=gawhJ4UWRFnxq9RrdJD5Ps+UQWRm5ZINsjsINaN63rM=; b=LSvCERmDTPWYZqqq5hbj9kbkazFXGM9UDCkMA5k/ont3r3YV5pdXSw5eUFFFJ1UAMcI13Q NHBnh917DeoLrZNw251hMo+xxbHqJGIkQhsbvHXaX7WfcDARZDh8AzOA2CuJXKAWd9ZweL oEXblXWVxIShqSYQBK6XwRr5/x92Ym7exvyXBPoWRLWQi5U7WYzyORLxdJVJh3ZrXcmjnN f3A3DdcHWL6pAueU+2t3spasqYME8KKrWlubacXEQ3LZipHu8yghiiwJ3qJzodugeUnylR D/5QJI1aMI+03C6BEOtMVUwRycaUvjhECeZbDrVs/l7sukusxwzILc5v/Cw2hg== Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id C295E79118 for ; Wed, 27 Nov 2024 20:29:33 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tGNip-0004Wz-VB; Wed, 27 Nov 2024 14:29:12 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tGNii-0004W0-JV for guix-patches@gnu.org; Wed, 27 Nov 2024 14:29:04 -0500 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tGNii-0001BH-AP for guix-patches@gnu.org; Wed, 27 Nov 2024 14:29:04 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-Version:Date:References:In-Reply-To:From:To:Subject; bh=gawhJ4UWRFnxq9RrdJD5Ps+UQWRm5ZINsjsINaN63rM=; b=fs93u0hff+DHtp7i9MQZfOF01EAY+zOWqy657M/e6Fma5FRcC2W6doC8/f65LqhVyh0m2y1vhs8Y3jgVk52FkTk7JkulGkz+WjiQqe7FtaMwltiDcoiW1InVIkcbrH7vGWqKOPZ8y8Wo/je1jTG+HM1f4KlA8CD7wU625avfNQoDclIOBk3rwjd1sGmkz/b+GtvAXo7SFxF560kPLG/nNXAwU/fTVvqZWNAwkP4+qKfuGudGCfiqbZkms4bpwGxHvUNAJ7MWY/Obx2JtOXSs2Mv09Ddg7qKXjjrR+LZliE8hu+X0My4/BVR9M/w/nhNvRyBccsjp5nsWiGFOo716PA==; Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1tGNih-0005yv-5O for guix-patches@gnu.org; Wed, 27 Nov 2024 14:29:03 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#74542] [PATCH 06/11] guix build: Add =?UTF-8?Q?=E2=80=98--dependents=E2=80=99.?= Resent-From: Simon Tournier Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 27 Nov 2024 19:29:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 74542 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Ludovic =?UTF-8?Q?Court=C3=A8s?= , 74542@debbugs.gnu.org Cc: Josselin Poiret , Maxim Cournoyer , Mathieu Othacehe , Ludovic Court?s , Tobias Geerinckx-Rice , Christopher Baines Received: via spool by 74542-submit@debbugs.gnu.org id=B74542.173273571822906 (code B ref 74542); Wed, 27 Nov 2024 19:29:03 +0000 Received: (at 74542) by debbugs.gnu.org; 27 Nov 2024 19:28:38 +0000 Received: from localhost ([127.0.0.1]:34597 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tGNiH-0005xI-NN for submit@debbugs.gnu.org; Wed, 27 Nov 2024 14:28:38 -0500 Received: from mail-wm1-f47.google.com ([209.85.128.47]:56825) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tGNiC-0005wv-67 for 74542@debbugs.gnu.org; Wed, 27 Nov 2024 14:28:32 -0500 Received: by mail-wm1-f47.google.com with SMTP id 5b1f17b1804b1-434a14d6bf4so160105e9.1 for <74542@debbugs.gnu.org>; Wed, 27 Nov 2024 11:28:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1732735651; x=1733340451; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:from:to:cc:subject:date:message-id :reply-to; bh=gawhJ4UWRFnxq9RrdJD5Ps+UQWRm5ZINsjsINaN63rM=; b=AJt1oSF47SssnE1iGVGJ/N2b+Yjz7v6OtAS43Y7bN4X/3n/ZPcyJ4WGU0UPgSlQPAI LNzjFhU0knEPDrHSsGOVlrbPiZ+x+zGssGHLUBhUr/gfYQeqYc3/LT3Ec9quuaeurgaK TP3H/JNtq+CirUUewh9cZG+F1Zt1C+tLzcIyMGmuVXaZyzDA+QvYcS3p5u/et/PmVhJl gBvIgRkeNraQ7OI/uLjezx43Aosh8yDfzJIwxL5bpH07VJiAt3HiZJBB2/8dIT5E3qqP pYqm1NEcy4f1ME9l24BVe9OF9MHhe4+p+bC6qa+2v8sFf4LqMX/nCFmfg74t0zxsL6f6 Y3Bw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1732735651; x=1733340451; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=gawhJ4UWRFnxq9RrdJD5Ps+UQWRm5ZINsjsINaN63rM=; b=mCQYsNAISZdh/BwIKAUE0e5l7sA0JcmxEOreCgAXT7drm7rb5UCXIes1z9PqKANsTn LAKL+S+nMq6asLl9m6b1vyk/y930QIocGciZ/8I1KgHC5Bb3HLVXlSgfzkwLR9gliWtB IbnepZ6BCAQOGRXDCZUGqdZjbDxFHurOSgsGLdK8KRjEpEKJLffoLF+WqaH8ZjvuiLOF ftcwzgjFiz+TrGM4Fx6qTv6so/OjhoH9CYYYk2aUsWqRAtAwCdLQ9W/W6qBIhEsyyWl5 okGVNaU66t4hoUOQy4TgKIjeEO8/kVAFiBVPmO3KdUHzLq07xUveZ7eUTzY787v2ig99 gTXg== X-Forwarded-Encrypted: i=1; AJvYcCVj8jJ1Ltf7Ik73qOujNKprop1mTmwvWzj63hOhXLhnZ0GCn6Iv/135gsbamRP352m2AvLeqA==@debbugs.gnu.org X-Gm-Message-State: AOJu0YzWMm+WZCT6QL3Do/7uM2b8yCaJnWufke/RSuQK7NwNBfORQYYN PbJtdFSAWOzSNMKsuzDS6+kkZpt8+k30dssSy1khUEGK1Ihhoy8i/7qsiQ== X-Gm-Gg: ASbGncsdE0sX45FxT2dSP46TVVBCyA6TPy5pASBsp2nm1y7ehqnBln7/jQhCxAsCDaK s1LM90xNzgrYJ5xFvBZ6THVEPm615W+dGg6rMqr1p2EKVm7hYhCWVpP0N/TXBYEO1+t4IimncHX BsvWXH09n082na71pl3TXX+b2XLVGz8wvrVPL6f+hQWfFz9d444u2faBJn5C3Oi779RvcFhDvvT vBoMW+HP0wTxiuvLA9g+bWbNjpFopHyEXj8MoyV2pY5DjNVdIWx9zIMOr4CTE4nNymH7P6tSeXn McadSZ15j9wUQTNyYmrdBIyGJ5qgpqXKzhY= X-Google-Smtp-Source: AGHT+IH4XuVQJAGRViI3yw5ZuXgxbv/X5bc1UqL/B0wWvJJo9hEiEaSYsqr9zi4zoYXWmFCWoLkKkw== X-Received: by 2002:a05:600c:54ed:b0:434:9c60:95a3 with SMTP id 5b1f17b1804b1-434a9dc14b1mr39257475e9.11.1732735651239; Wed, 27 Nov 2024 11:27:31 -0800 (PST) Received: from lili (roam-nat-fw-prg-194-254-61-40.net.univ-paris-diderot.fr. [194.254.61.40]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-434aa6e929csm31675505e9.0.2024.11.27.11.27.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 27 Nov 2024 11:27:30 -0800 (PST) From: Simon Tournier In-Reply-To: References: Date: Wed, 27 Nov 2024 20:12:27 +0100 Message-ID: <87jzco4hk4.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN X-Migadu-Spam-Score: -1.64 X-Spam-Score: -1.64 X-Migadu-Queue-Id: C295E79118 X-Migadu-Scanner: mx10.migadu.com X-TUID: zEAR11g0O/p3 Hi, On Tue, 26 Nov 2024 at 11:33, Ludovic Court=C3=A8s wrote: > +@item --dependents[=3D@var{depth}] > +@itemx -T [@var{depth}] Cosmetic: argh, =E2=80=99-M=E2=80=99 is already taken under =E2=80=9Cguix b= uild=E2=80=9D! Because it would be nice to have something similar as with =E2=80=9Cguix graph --max-depth=E2=80=9D. Yes, both depths does not have the same meaning but that=E2=80=99s still a =E2=80=99max depth=E2=80=99 for both cases. ;-) Well=E2=80=A6 > +The list of dependents is computed in the same way as with @command{guix > +refresh --list-dependent} (@pxref{Invoking guix refresh}). =E2=80=A6 =E2=80=9Cguix refresh=E2=80=9D already uses =E2=80=99-T=E2=80=99 = but for another meaning (--list-transitive). Therefore, I think something other than =E2=80=99-T= =E2=80=99 should be better. Maybe =E2=80=99-D=E2=80=99 since it cannot conflict with= =E2=80=9Cguix shell=E2=80=9D.. > + -T, --dependents[=3DN] build dependents of the following package, up= to > + depth N")) As said, =E2=80=99-T=E2=80=99 might be confusing with =E2=80=9Cguix refresh= -T=E2=80=9D especially when =E2=80=99dependents=E2=80=99 is more or less connected with =E2=80=9Cguix r= efresh -l=E2=80=9D. > + (option '(#\T "dependents") #f #t > + (lambda (opt name arg result) > + (alist-cons 'dependents > + (or (and=3D> arg string->number*) +inf.0) > + result))) Idem. > +(define (options->things-to-build store opts) [...] > - (map transform (options->things-to-build opts))) > + (map transform (options->things-to-build store opts))) I thought =E2=80=99store=E2=80=99 could have been hidden, but not. Since i= t=E2=80=99s already passed to =E2=80=99options->derivations=E2=80=99. :-) Well, aside the cosmetic, LGTM. Cheers, simon