From: ludo@gnu.org (Ludovic Courtès)
To: Federico Beffa <beffa@ieee.org>
Cc: Guix-devel <guix-devel@gnu.org>
Subject: Re: [PATCH] gnu: Add numpy.
Date: Mon, 01 Dec 2014 21:34:10 +0100 [thread overview]
Message-ID: <87iohvjeil.fsf@gnu.org> (raw)
In-Reply-To: <CAKrPhPO2oX3-h3p9mgAHE-e9r=5sDKvw0tM4kz0oQrBN4AL6hQ@mail.gmail.com> (Federico Beffa's message of "Mon, 1 Dec 2014 18:17:14 +0100")
Federico Beffa <beffa@ieee.org> skribis:
> From cdf0c1a3193d1855d8b1a512042f91a56c82ea28 Mon Sep 17 00:00:00 2001
> From: Federico Beffa <beffa@fbengineering.ch>
> Date: Mon, 1 Dec 2014 13:28:24 +0100
> Subject: [PATCH] gnu: Add numpy.
>
> * gnu/packages/python.scm (python-numpy, python2-numpy): New variables.
[...]
> + ;; Generation of the info file fails.
Please add FIXME or XXX. ↑
> + (map (lambda (file)
> + (copy-file (string-append "build/latex" file)
> + (string-append doc file)))
> + '("/numpy-ref.pdf" "/numpy-user.pdf"))
Please use ‘for-each’ instead of ‘map’ (because it’s a for-effect
iteration), and align the file list with “(lambda”.
> + (map (lambda (file)
‘for-each’ as well.
OK to push with these changes.
Thanks!
Ludo’.
prev parent reply other threads:[~2014-12-01 20:34 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-01 17:17 [PATCH] gnu: Add numpy Federico Beffa
2014-12-01 20:34 ` Ludovic Courtès [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87iohvjeil.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=beffa@ieee.org \
--cc=guix-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.