From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=)
Subject: Re: [PATCH 4/4] import: cpan: Sort inputs, use mirror url,
	adjust licenses.
Date: Sat, 14 Feb 2015 00:17:03 +0100
Message-ID: <87iof51jww.fsf@gnu.org>
References: <1423756695-13378-1-git-send-email-bavier@member.fsf.org>
	<1423756695-13378-5-git-send-email-bavier@member.fsf.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:38976)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1YMPTz-0007Gm-9B
	for guix-devel@gnu.org; Fri, 13 Feb 2015 18:17:12 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1YMPTu-0000zt-5I
	for guix-devel@gnu.org; Fri, 13 Feb 2015 18:17:11 -0500
In-Reply-To: <1423756695-13378-5-git-send-email-bavier@member.fsf.org> (Eric
	Bavier's message of "Thu, 12 Feb 2015 09:58:15 -0600")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: Eric Bavier <bavier@member.fsf.org>
Cc: guix-devel@gnu.org

Eric Bavier <bavier@member.fsf.org> skribis:

> * guix/import/cpan.scm (string->license): Add artistic2.0.  Use
>   '(package-license perl) for "perl_5" as in our convention.
>   (cpan-module->sexp)[convert-inputs]: Sort returned list of inputs.
>   [source-url]: Substitute cpan mirror url.

LGTM, but please commit as 3 different patches since the 3 changes are
unrelated.

Thanks,
Ludo=E2=80=99.