Re: [PATCHES] Fix samba rpaths, add mplayer2

[ludo@gnu.org (Ludovic Courtès)]

taylanbayirli@gmail.com (Taylan Ulrich "Bayırlı/Kammer") skribis:

> I could "manually" try to find out which of the bug reports are closed
> by this, but I guess the smartest approach is to push the patch, wait
> for the build farm to rebuild all samba-depending packages, do a "guix
> package -u", "guix package -d <something>" and "guix gc" to prune the
> old versions from the store, then reuse my method to find all the
> dangling .so references in my store and see which ones disappeared.

Yes, makes sense.

> From 2cc56efd1cb7c6cfee6ed216d559780529dfb111 Mon Sep 17 00:00:00 2001
> From: =?UTF-8?q?Taylan=20Ulrich=20Bay=C4=B1rl=C4=B1/Kammer?=
>  <taylanbayirli@gmail.com>
> Date: Tue, 10 Mar 2015 19:37:57 +0100
> Subject: [PATCH 1/2] gnu: samba: Augment dynamic library rpaths.
>
> * gnu/packages/samba.scm (samba): Augment the rpath of files in lib/ in
>   addition to those in bin/ and sbin/.

OK.  (Not related, but I noticed that Samba has weird sub-directories in
its $prefix, such as private/ and swat/, and var/ shouldn’t be here.)

> From 817afcaf698658fcba9750521a17e54ec5665986 Mon Sep 17 00:00:00 2001
> From: =?UTF-8?q?Taylan=20Ulrich=20Bay=C4=B1rl=C4=B1/Kammer?=
>  <taylanbayirli@gmail.com>
> Date: Wed, 4 Mar 2015 16:29:08 +0100
> Subject: [PATCH 2/2] gnu: Add mplayer2.
>
> * gnu/packages/video.scm (mplayer2): New variable.
> * gnu/packages/patches/mplayer2-theora-fix.patch: New file.
> * gnu-system.am (dist_patch_DATA): Add it.

LGTM.

Thanks!

Ludo’.