From: Mark H Weaver <mhw@netris.org>
To: Andy Wingo <wingo@pobox.com>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH] Add upower
Date: Sun, 05 Apr 2015 11:07:43 -0400 [thread overview]
Message-ID: <87ioda62bk.fsf@netris.org> (raw)
In-Reply-To: <87egnz4qgt.fsf@pobox.com> (Andy Wingo's message of "Sat, 04 Apr 2015 21:56:50 +0200")
Hi Andy!
Here are some more comments to add to David's:
Andy Wingo <wingo@pobox.com> writes:
> From 4725d267b7c18bc4ba4294f90336871311386bb2 Mon Sep 17 00:00:00 2001
> From: Andy Wingo <wingo@pobox.com>
> Date: Sat, 4 Apr 2015 21:48:01 +0200
> Subject: [PATCH 2/3] Add upower package.
By our conventions, we write this first line as: "gnu: Add upower."
> * gnu/packages/gnome.scm (upower): New variable.
> * gnu/packages/patches/upower-builddir.patch: New patch.
The patch also needs to be added to 'dist_patch_DATA' in gnu-system.am.
David Thompson <dthompson2@worcester.edu> wrote:
> Could you add a comment about the upstream status of this patch, perhaps
> with a URL pointing to the relevant bug tracker, if applicable?
Agreed, but I think this should go in the top of the patch file rather
than in the package definition itself.
Thanks!
Mark
next prev parent reply other threads:[~2015-04-05 15:07 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-04 19:56 [PATCH] Add upower Andy Wingo
2015-04-05 14:55 ` David Thompson
2015-04-05 20:33 ` Making service values transparent Ludovic Courtès
2015-04-12 21:01 ` [PATCH] Add upower Ludovic Courtès
2015-04-05 15:07 ` Mark H Weaver [this message]
2015-04-12 22:05 ` Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ioda62bk.fsf@netris.org \
--to=mhw@netris.org \
--cc=guix-devel@gnu.org \
--cc=wingo@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.