From mboxrd@z Thu Jan 1 00:00:00 1970 From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=) Subject: Re: [PATCH] Add skalibs, execline. Date: Sun, 28 Jun 2015 22:37:48 +0200 Message-ID: <87ioa7sh5v.fsf@gnu.org> References: Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:56397) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z9JKv-0001Sm-5c for guix-devel@gnu.org; Sun, 28 Jun 2015 16:37:58 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Z9JKq-0001XX-I1 for guix-devel@gnu.org; Sun, 28 Jun 2015 16:37:57 -0400 In-Reply-To: ("Claes Wallin \=\?utf-8\?B\?KOmfi+WYieiqoCkiJ3M\=\?\= message of "Fri, 26 Jun 2015 02:28:03 +0200") List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: =?utf-8?B?Q2xhZXMgV2FsbGluICjpn4vlmInoqqAp?= Cc: guix-devel "Claes Wallin (=E9=9F=8B=E5=98=89=E8=AA=A0)" skribis: > From 9a290c4e798a4668cae65126d48d301b44b96a69 Mon Sep 17 00:00:00 2001 > From: Claes Wallin > Date: Thu, 25 Jun 2015 12:00:06 +0200 > Subject: [PATCH 1/3] gnu: Add skalibs. > > * gnu/package/skarnet.scm (skalibs): New file. > * gnu-system.am (GNU_SYSTEM_MODULES): Add it. [...] > + (search-paths > + (list (search-path-specification > + (variable "CPATH") > + (files '("include"))) > + (search-path-specification > + (variable "LIBRARY_PATH") > + (files '("lib"))))) This is not needed here (=E2=80=98gcc=E2=80=99 handles that.) > + (synopsis "Common libraries for skarnet.org software") > + (description > + "General-purpose libraries for minimalist C development, used by all > + skarnet.org software.") ^^^^^^ Please remove extra space here. Also, what about something like: This package provides lightweight C libraries for . They are used by skarnet.org software. > From 75b13e87271f8b8b0f54562a46aa6e7e437aacb9 Mon Sep 17 00:00:00 2001 > From: Claes Wallin > Date: Thu, 25 Jun 2015 14:47:41 +0200 > Subject: [PATCH 2/3] gnu: Add execline. > > * gnu/package/skarnet.scm (execline): New variable. ^ Extra space. > diff --git a/gnu/packages/patches/execline-fix-gen-deps.patch b/gnu/packa= ges/patches/execline-fix-gen-deps.patch > new file mode 100644 > index 0000000..79bdc95 > --- /dev/null > +++ b/gnu/packages/patches/execline-fix-gen-deps.patch > @@ -0,0 +1,12 @@ Please start the .patch with a brief description of what it does, and its upstream status (like =E2=80=9CUpstream commit XYZ=E2=80=9D, or =E2=80= =9CSubmitted upstream at http://...=E2=80=9D.) > + #:modules ((guix build utils) > + (guix build gnu-build-system) > + (ice-9 popen)) Replace the first two with: ,@%gnu-build-system-modules and use a backquote instead of a quote in =E2=80=98arguments.=E2=80=99 > + "Execline is a (non-interactive) scripting language, like sh, but i= ts > +syntax is quite different from a traditional shell syntax. The execlineb > +program is used strictly as a parser for a text file and generates a sin= gle > +command execution with the entire script stored in the argument array. > +The language is a library of binaries useful for the tail call or=20 > +chain execution style that the parser requires. > + > +It is as powerful as a shell: It features conditional loops, > +getopt-style option handling, filename globbing, and more. Meanwhile, i= ts > +syntax is unambiguous and simple, allowing a minimal parser, which doesn= 't > +even stay in memory when parsing is done and execution starts."))) s/filename/file name/ It would be nice to make it a couple of lines shorter. > From e39ab44b8464aa14b25fc8554facd34411b926eb Mon Sep 17 00:00:00 2001 > From: Claes Wallin > Date: Fri, 26 Jun 2015 00:45:41 +0200 > Subject: [PATCH 3/3] gnu: make execline commands trivially available to a= ll > execline scripts > > * gnu/package/skarnet.scm (execline): wrap execlineb to have its own > .../bin first in PATH LGTM, but please merge it with the previous patch. Could you send updated patches? Thank you! Ludo=E2=80=99.