From mboxrd@z Thu Jan  1 00:00:00 1970
From: Alex Kost <alezost@gmail.com>
Subject: Re: [PATCH] gnu: pdf: Fix installing desktop files of zathura
	packages.
Date: Tue, 07 Jul 2015 20:39:51 +0300
Message-ID: <87io9vj28o.fsf@gmail.com>
References: <87twtgicz4.fsf@gmail.com> <87zj380zxg.fsf@netris.org>
Mime-Version: 1.0
Content-Type: text/plain
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:37593)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <alezost@gmail.com>) id 1ZCWqd-0005uj-J0
	for guix-devel@gnu.org; Tue, 07 Jul 2015 13:40:00 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <alezost@gmail.com>) id 1ZCWqZ-0004ul-Cx
	for guix-devel@gnu.org; Tue, 07 Jul 2015 13:39:59 -0400
Received: from mail-la0-x22d.google.com ([2a00:1450:4010:c03::22d]:33059)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <alezost@gmail.com>) id 1ZCWqZ-0004ua-49
	for guix-devel@gnu.org; Tue, 07 Jul 2015 13:39:55 -0400
Received: by laar3 with SMTP id r3so205562439laa.0
	for <guix-devel@gnu.org>; Tue, 07 Jul 2015 10:39:54 -0700 (PDT)
In-Reply-To: <87zj380zxg.fsf@netris.org> (Mark H. Weaver's message of "Tue, 07
	Jul 2015 11:07:07 -0400")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: Mark H Weaver <mhw@netris.org>
Cc: guix-devel@gnu.org

Mark H Weaver (2015-07-07 18:07 +0300) wrote:

[...]
>>      (arguments
>>       `(#:make-flags
>>         `(,(string-append "DESTDIR=" (assoc-ref %outputs "out"))
>> -          "PLUGINDIR=/lib/zathura" "CC=gcc")
>> +          "PREFIX=" "PLUGINDIR=/lib/zathura" "CC=gcc")
>
> It would be better to leave DESTDIR empty and set PREFIX=<%output>, so:

It wouldn't work for these packages.

>> -       `(,(string-append "DESTDIR=" (assoc-ref %outputs "out"))
>> +       `(,(string-append "PREFIX=" (assoc-ref %outputs "out"))
>
> There is a conceptual difference between PREFIX and DESTDIR: at install
> time, files are copied to ${DESTDIR}${PREFIX}, and then at run time
> files are expected to be at ${PREFIX}.  So in general, we don't want to
> use DESTDIR in Guix, and we want to set PREFIX to the output directory.

I know, but these zathura plugins do not provide configure stages, and
PREFIX is not even used in the manually written "Makefile"s.  PREFIX is
used in "config.mk" (which is included in a Makefile) to define LIBDIR
and DESKTOPPREFIX.

And due to Makefile things are installed in ${DESTDIR}${PLUGINDIR} and
${DESTDIR}${DESKTOPPREFIX}.

-- 
Alex