From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andy Wingo Subject: Re: [PATCH v2 3/7] gnu: Allow OS configurations to add PAM session modules Date: Tue, 25 Aug 2015 18:00:14 +0200 Message-ID: <87io834aup.fsf@igalia.com> References: <95cd06d0b1639449fffa2ded823e54d0f26afbb6.1440062095.git.wingo@pobox.com> <87d1ybmn85.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:55400) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZUGe9-00043L-QT for guix-devel@gnu.org; Tue, 25 Aug 2015 12:00:30 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZUGe5-0002oV-17 for guix-devel@gnu.org; Tue, 25 Aug 2015 12:00:25 -0400 In-Reply-To: <87d1ybmn85.fsf@gnu.org> ("Ludovic =?utf-8?Q?Court=C3=A8s=22'?= =?utf-8?Q?s?= message of "Tue, 25 Aug 2015 16:55:38 +0200") List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: Ludovic =?utf-8?Q?Court=C3=A8s?= Cc: guix-devel@gnu.org On Tue 25 Aug 2015 16:55, ludo@gnu.org (Ludovic Court=C3=A8s) writes: > Andy Wingo skribis: > >> * gnu/services/base.scm (mingetty-service): >> * gnu/services/xorg.scm (slim-service): >> * gnu/services/ssh.scm (lsh-service): >> * gnu/system/linux.scm (unix-pam-service, base-pam-services): Add >> #:additional-session-modules keyword argument. > > I wonder if we really need #:additional-session-modules passed around. > > My first suggestion would be to do =E2=80=98unix-pam-service=E2=80=99 or > =E2=80=98base-pam-services=E2=80=99 in the OS declaration along these lin= es: > > (operating-system > ;; ... > (pam-services (map (lambda (service) > (pam-service > (inherit service) > (session (cons ...)))) > (base-pam-services)))) > > But maybe that turned out to be inconvenient? If so, perhaps we could > solve it by introducing helper procedures, like > =E2=80=98add-pam-service-session=E2=80=99 or something? > > Or am I missing something? :-) > > BTW, I realize we should rename (gnu system linux) to (gnu system pam) > and then document it in the manual. How would that work for other services like slim, mingetty, etc?