[PATCH] gnu: Add cscope

[PATCH] gnu: Add cscope

[Jeff Mickey]

[-- Attachment #1: Type: text/plain, Size: 205 bytes --]

Needed this recently, sending upstream :)

The contrib/ folder in cscope yet, but it only includes outdated
versions of tools that should be found elsewhere (cscope-indexer and
xcscope.el)

  //  codemac


[-- Attachment #2: 0001-gnu-Add-cscope.patch --]
[-- Type: text/x-patch, Size: 3211 bytes --]

From 64a74d39d1d58c12806f3991afd5443d8d75bcd5 Mon Sep 17 00:00:00 2001
From: Jeff Mickey <j@codemac.net>
Date: Tue, 29 Sep 2015 18:07:44 -0700
Subject: [PATCH] gnu: Add cscope

* gnu/packages/cscope.scm: New file.
* gnu-system.am (GNU_SYSTEM_MODULES): Add it.
---
 gnu-system.am           |  1 +
 gnu/packages/cscope.scm | 49 +++++++++++++++++++++++++++++++++++++++++++++++++
 2 files changed, 50 insertions(+)
 create mode 100644 gnu/packages/cscope.scm

diff --git a/gnu-system.am b/gnu-system.am
index 98634a0..feb6cf6 100644
--- a/gnu-system.am
+++ b/gnu-system.am
@@ -73,6 +73,7 @@ GNU_SYSTEM_MODULES =				\
   gnu/packages/cross-base.scm			\
   gnu/packages/crypto.scm			\
   gnu/packages/cryptsetup.scm			\
+  gnu/packages/cscope.scm			\
   gnu/packages/cups.scm				\
   gnu/packages/curl.scm				\
   gnu/packages/cursynth.scm			\
diff --git a/gnu/packages/cscope.scm b/gnu/packages/cscope.scm
new file mode 100644
index 0000000..890cdfa
--- /dev/null
+++ b/gnu/packages/cscope.scm
@@ -0,0 +1,49 @@
+;;; GNU Guix --- Functional package management for GNU
+;;; Copyright © 2015 Jeff Mickey <j@codemac.net>
+;;;
+;;; This file is part of GNU Guix.
+;;;
+;;; GNU Guix is free software; you can redistribute it and/or modify it
+;;; under the terms of the GNU General Public License as published by
+;;; the Free Software Foundation; either version 3 of the License, or (at
+;;; your option) any later version.
+;;;
+;;; GNU Guix is distributed in the hope that it will be useful, but
+;;; WITHOUT ANY WARRANTY; without even the implied warranty of
+;;; MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+;;; GNU General Public License for more details.
+;;;
+;;; You should have received a copy of the GNU General Public License
+;;; along with GNU Guix.  If not, see <http://www.gnu.org/licenses/>.
+
+
+(define-module (gnu packages cscope)
+  #:use-module ((guix licenses) #:prefix license:)
+  #:use-module (guix packages)
+  #:use-module (guix download)
+  #:use-module (guix build-system gnu)
+  #:use-module (gnu packages ncurses))
+
+(define-public cscope
+  (package
+    (name "cscope")
+    (version "15.8a")
+    (source (origin
+              (method url-fetch)
+              (uri (string-append "http://downloads.sourceforge.net/"
+                                  name "/" name "-" version ".tar.gz"))
+              (sha256
+               (base32 "07jdhxvp3dv7acvp0pwsdab1g2ncxjlcf838lj7vxgjs1p26lwzb"))))
+    (build-system gnu-build-system)
+    (arguments
+     `(#:configure-flags (list (string-append "--with-ncurses=" (assoc-ref %build-inputs "ncurses")))))
+    (inputs `(("ncurses" ,ncurses)))
+    (home-page "http://cscope.sourceforge.net")
+    (synopsis "Tool for browsing source code, with ncurses and editor interfaces")
+    (description "A tool for browsing source code. It has an information
+database generated for faster searches and later reference, a fuzzy parser
+that supports C, but is flexible enough to be useful for C++ and Java, and has
+a command line mode for inclusion in scripts or as a backend to a
+GUI/frontend.")
+    (license license:bsd-3)))
+
-- 
2.5.0

Re: [PATCH] gnu: Add cscope

[Jeff Mickey]

*Haven't packaged [the ...]

* Jeff Mickey <j@codemac.net> [2015-09-29 18:13]:
> The contrib/ folder in cscope yet, but it only includes outdated
> versions of tools that should be found elsewhere (cscope-indexer and
> xcscope.el)

  //  codemac

Re: [PATCH] gnu: Add cscope

[Ludovic Courtès]

Jeff Mickey <j@codemac.net> skribis:

> From 64a74d39d1d58c12806f3991afd5443d8d75bcd5 Mon Sep 17 00:00:00 2001
> From: Jeff Mickey <j@codemac.net>
> Date: Tue, 29 Sep 2015 18:07:44 -0700
> Subject: [PATCH] gnu: Add cscope
>
> * gnu/packages/cscope.scm: New file.
> * gnu-system.am (GNU_SYSTEM_MODULES): Add it.

Could you move it to (gnu packages code), and also make sure doesn’t
complain (lines too long, two spaces after period, description must
contain sentences not just “A tool for foo.”).

TIA!

Ludo’.

Re: [PATCH] gnu: Add cscope

[Mark H Weaver]

ludo@gnu.org (Ludovic Courtès) writes:

> Jeff Mickey <j@codemac.net> skribis:
>
>> From 64a74d39d1d58c12806f3991afd5443d8d75bcd5 Mon Sep 17 00:00:00 2001
>> From: Jeff Mickey <j@codemac.net>
>> Date: Tue, 29 Sep 2015 18:07:44 -0700
>> Subject: [PATCH] gnu: Add cscope
>>
>> * gnu/packages/cscope.scm: New file.
>> * gnu-system.am (GNU_SYSTEM_MODULES): Add it.
>
> Could you move it to (gnu packages code), and also make sure doesn’t
> complain (lines too long, two spaces after period, description must
> contain sentences not just “A tool for foo.”).

I think that should read: make sure "guix lint" doesn't complain [...]

     Mark

Re: [PATCH] gnu: Add cscope

[Ricardo Wurmus]

Hi,

> From 64a74d39d1d58c12806f3991afd5443d8d75bcd5 Mon Sep 17 00:00:00 2001
> From: Jeff Mickey <j@codemac.net>
> Date: Tue, 29 Sep 2015 18:07:44 -0700
> Subject: [PATCH] gnu: Add cscope

> * gnu/packages/cscope.scm: New file.
> * gnu-system.am (GNU_SYSTEM_MODULES): Add it.

I think this could better be added to the code.scm module rather than
getting its own module.  What do you think?

> +(define-public cscope
> +  (package
> +    (name "cscope")
> +    (version "15.8a")
> +    (source (origin
> +              (method url-fetch)
> +              (uri (string-append "http://downloads.sourceforge.net/"

Please use “mirror://sourceforge...” if possible.

> +                                  name "/" name "-" version ".tar.gz"))
> +              (sha256
> +               (base32 "07jdhxvp3dv7acvp0pwsdab1g2ncxjlcf838lj7vxgjs1p26lwzb"))))

This line is too long.  I’m using fci-mode in Emacs to draw a line at
the position of the fill column, so it’s easy to tell if lines are too
long.

> +    (build-system gnu-build-system)
> +    (arguments
> +     `(#:configure-flags (list (string-append "--with-ncurses=" (assoc-ref %build-inputs "ncurses")))))

This line is also quite a bit too long.  You could easily break this up.

> +    (inputs `(("ncurses" ,ncurses)))
> +    (home-page "http://cscope.sourceforge.net")
> +    (synopsis "Tool for browsing source code, with ncurses and editor interfaces")

This synopsis is also a tad too long.

> +    (description "A tool for browsing source code. It has an information
> +database generated for faster searches and later reference, a fuzzy parser
> +that supports C, but is flexible enough to be useful for C++ and Java, and has
> +a command line mode for inclusion in scripts or as a backend to a
> +GUI/frontend.")

Please use two spaces between sentences.  Also, the first sentence
fragment should be a full sentence, such as

   “CScope is a tool for browsing source code...”

not

   “A tool for browsing source code.”

(I should say that to me it’s not obvious what this tool actually does.
Is it something like ctags?)

> +    (license license:bsd-3)))
> +

Okay.

~~ Ricardo