From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=)
Subject: Re: [PATCH] gnu: openblas: Fix configure flags on armhf and take
	target
Date: Thu, 01 Oct 2015 15:25:30 +0200
Message-ID: <87io6qoh4l.fsf@gnu.org>
References: <20151001084613.GA6497@debian>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:35467)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1Zhdrh-0004v4-2M
	for guix-devel@gnu.org; Thu, 01 Oct 2015 09:25:41 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1Zhdrb-00066E-2q
	for guix-devel@gnu.org; Thu, 01 Oct 2015 09:25:40 -0400
In-Reply-To: <20151001084613.GA6497@debian> (Andreas Enge's message of "Thu, 1
	Oct 2015 10:46:13 +0200")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: Andreas Enge <andreas@enge.fr>
Cc: guix-devel@gnu.org

Andreas Enge <andreas@enge.fr> skribis:

>>From 8802c118fed2c93ee60d90a5cc883c1c3328d531 Mon Sep 17 00:00:00 2001
> From: Andreas Enge <privat@xobs-novena>
> Date: Thu, 1 Oct 2015 10:32:29 +0200
> Subject: [PATCH] gnu: openblas: Fix configure flags on armhf and take tar=
get
>  system into   account for cross building.
>
> * gnu/packages/maths.scm (openblas)[arguments]: Make package substitutable
>   and enable runtime cpu detection only on x86 systems. Take the target
>   system into account when cross compiling.

[...]

> +             ,@(let ((system (or (%current-target-system) (%current-syst=
em))))
> +              (if (or (string-prefix? "x86_64" system)
                 ^
Please indent like the previous =E2=80=98let=E2=80=99.

Other than that LGTM, thank you!

Ludo=E2=80=99.