From: Paul van der Walt <paul@denknerd.org>
To: Mark H Weaver <mhw@netris.org>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH] gnu: Add dosbox x86 emulator.
Date: Thu, 22 Oct 2015 11:13:46 +0200 [thread overview]
Message-ID: <87io5zs1th.fsf@denknerd.org> (raw)
In-Reply-To: <87bnbrn8v2.fsf@netris.org>
Hi Mark,
On 2015-10-22 at 00:40, quoth Mark H Weaver:
>> + (arguments
>> + `(#:phases (modify-phases %standard-phases
>> + (add-before
>> + 'configure 'autogen.sh
>> + (lambda _
>> + (zero? (system* "sh" "autogen.sh")))))))
>
> For future reference, phases like the one above, that generates the
> configure script, should always be put after 'unpack' instead of before
> 'configure'. The reason is that there are some phases between the
> 'unpack' and 'configure' phases that are needed to fix things up in the
> generated 'configure' script for non-Intel platforms, especially
> 'patch-usr-bin-file' which is typically needed on MIPS.
>
> I went ahead and made this change in commit e0a7d36458.
Right, sorry about that, and thank you very much!
p.
prev parent reply other threads:[~2015-10-22 9:13 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-19 13:25 [PATCH] gnu: Add dosbox x86 emulator Paul van der Walt
2015-10-21 19:41 ` Ludovic Courtès
2015-10-21 20:12 ` Paul van der Walt
2015-10-21 22:40 ` Mark H Weaver
2015-10-22 9:13 ` Paul van der Walt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87io5zs1th.fsf@denknerd.org \
--to=paul@denknerd.org \
--cc=guix-devel@gnu.org \
--cc=mhw@netris.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.