Re: [PATCH] gnu: ffmpeg: Move flags into their own argument.

[ludo@gnu.org (Ludovic Courtès)]

Andy Patterson <ajpatter@uwaterloo.ca> skribis:

> The reason I wanted to do this was so that I could enable TLS support
> for ffmpeg locally. The comment in the configure flags specifies that
> the tests fail with gnutls support enabled. The tests are currently
> working for me with gnutls enabled, on AMD64. I'd like to send another
> patch to enable it. Does anyone have any concerns about doing so?

It turns out that FFmpeg already depends on GnuTLS via libquvi, per:

  guix graph -t references ffmpeg | dot -Tps > t.ps

So I would say that you can add it in a separate patch without any
problems.

> From c78491cc816d936722ec403e8bd498162abcf962 Mon Sep 17 00:00:00 2001
> From: Andy Patterson <ajpatter@uwaterloo.ca>
> Date: Wed, 28 Oct 2015 22:42:42 -0400
> Subject: [PATCH] gnu: ffmpeg: Move flags into their own argument.
>
> * gnu/packages/video.scm (ffmpeg)[arguments]: Move the configurable
>   configure flag literals into the configure-flags argument. Call
>   configure with these flags from the configure phase.

Applied, thanks!

Ludo’.