From mboxrd@z Thu Jan  1 00:00:00 1970
From: Mathieu Lirzin <mthl@gnu.org>
Subject: Re: [PATCH] gnu: parted: Update to 3.2.
Date: Sat, 21 Nov 2015 13:32:12 +0100
Message-ID: <87io4v4joz.fsf@gnu.org>
References: <87wptc2nv1.fsf@gnu.org> <878u5rd4zv.fsf@gnu.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:59039)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mthl@gnu.org>) id 1a07L3-0002ig-G6
	for guix-devel@gnu.org; Sat, 21 Nov 2015 07:32:22 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mthl@gnu.org>) id 1a07L2-0007WQ-DX
	for guix-devel@gnu.org; Sat, 21 Nov 2015 07:32:21 -0500
In-Reply-To: <878u5rd4zv.fsf@gnu.org> ("Ludovic
	\=\?utf-8\?Q\?Court\=C3\=A8s\=22'\?\=
	\=\?utf-8\?Q\?s\?\= message of "Sat, 21 Nov 2015 11:24:52 +0100")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: Ludovic =?utf-8?Q?Court=C3=A8s?= <ludo@gnu.org>
Cc: guix-devel@gnu.org

Hi,

ludo@gnu.org (Ludovic Court=C3=A8s) writes:

> Mathieu Lirzin <mthl@gnu.org> skribis:
>
>> From a43f69d7f57df7ca2fb156ab75a845a68cc43d02 Mon Sep 17 00:00:00 2001
>> From: Mathieu Lirzin <mthl@gnu.org>
>> Date: Sat, 21 Nov 2015 01:07:03 +0100
>> Subject: [PATCH] gnu: parted: Update to 3.2.
>>
>> * gnu/packages/disk.scm (parted): Update to 3.2.
>> [inputs]: Add lvm2 and remove check.  Replace readline-6.2 with its
>> latest version.
>> [native-inputs]: Add perl and python for the tests.
>> [arguments]: Use `modify-phases' and adapt to the new tests.
>> [home-page]: Use https.
>
> Thanks for tackling this.  I think the reason this wasn=E2=80=99t done be=
fore is
> that there were various issues, notably:
>
>   https://lists.gnu.org/archive/html/bug-parted/2014-08/msg00001.html
>   https://lists.gnu.org/archive/html/bug-parted/2014-08/msg00002.html
>
> and then I dropped the ball.  :-)

It helps alot to have some background.  Thanks for this pointers.

>> +                      (substitute* "tests/t0251-gpt-unicode.sh"
>> +                        (("C.UTF-8") "en_US.UTF-8")) ;not in Glibc loca=
les
>
> Rather =E2=80=9Cen_US.utf8=E2=80=9D, because =E2=80=9Cutf8=E2=80=9D is th=
e =E2=80=9Cnormalized codeset=E2=80=9D.

Done.

>> +    (inputs `(("lvm2"       ,lvm2)
>> +              ("readline"   ,readline)
>> +              ("util-linux" ,util-linux)))
>
> I=E2=80=99d prefer to avoid this alignment style.  No big deal though.

Fixed.  Your nitpicking is always appreciated! ;)

I will avoid this in my future package definitions.

> OK with the above change, thank you!

Pushed in 1b933e62dcc8521e383a78e5d7952a194e47a4ec.

Thanks,

--
Mathieu Lirzin