From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=)
Subject: Re: [PATCH 1/2] gnu: Add cuetools.
Date: Wed, 30 Dec 2015 00:26:19 +0100
Message-ID: <87io3gzvj8.fsf@gnu.org>
References: <cover.1451280624.git.leo@famulari.name>
	<cover.1451280624.git.leo@famulari.name>
	<0266be5311e6f02cb2dd73e87a7cdd05a7a59f69.1451280624.git.leo@famulari.name>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:38700)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1aE3er-0003Bu-Uq
	for guix-devel@gnu.org; Tue, 29 Dec 2015 18:26:26 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1aE3en-0006kG-UT
	for guix-devel@gnu.org; Tue, 29 Dec 2015 18:26:25 -0500
In-Reply-To: <0266be5311e6f02cb2dd73e87a7cdd05a7a59f69.1451280624.git.leo@famulari.name>
	(Leo Famulari's message of "Mon, 28 Dec 2015 00:32:39 -0500")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: Leo Famulari <leo@famulari.name>
Cc: guix-devel@gnu.org

Leo Famulari <leo@famulari.name> skribis:

> * gnu/packages/audio.scm (cuetools): New variable.

[...]

> +        (modify-phases %standard-phases
> +          (add-after 'unpack 'bootstrap
> +                     (lambda _ (zero? (system* "autoreconf" "-vfi")))))))

Note that, as per a recent rule, the =E2=80=9C(lambda=E2=80=9D should be al=
igned with
the =E2=80=98d=E2=80=99 of =E2=80=98add-after=E2=80=99.

> +    (home-page "https://github.com/svend/cuetools")
> +    (license license:gpl2)))

AFAICS, source file headers do not mention a specific GPL version; thus,
it should be =E2=80=98gpl2+=E2=80=99.

Otherwise LGTM, thanks!

Ludo=E2=80=99.