[PATCH 1/6] gnu: Add emacs-scheme-complete.

[PATCH 1/6] gnu: Add emacs-scheme-complete.

[Federico Beffa]

[-- Attachment #1: Type: text/plain, Size: 279 bytes --]

Hi,

I'm not sure about the license of this package. It just sates:

;;; This code is written by Alex Shinn and placed in the Public
;;; Domain.  All warranties are disclaimed.

This is the same declaration (and author) as the file
'match.upstream.scm' in guile.


Regards,
Fede

[-- Attachment #2: 0001-gnu-Add-emacs-scheme-complete.patch --]
[-- Type: text/x-diff, Size: 3549 bytes --]

From fc9b0980ab81ae89a80fe1892e928853723d9809 Mon Sep 17 00:00:00 2001
From: Federico Beffa <beffa@fbengineering.ch>
Date: Thu, 24 Dec 2015 11:53:12 +0100
Subject: [PATCH 1/6] gnu: Add emacs-scheme-complete.

* gnu/packages/emacs.scm (emacs-scheme-complete): New variable.
* gnu/packages/patches/emacs-scheme-complete-scheme-r5rs-info.patch: New patch.
* gnu-system.am (dist_patch_DATA): Add the new patch.
---
 gnu-system.am                                      |  1 +
 gnu/packages/emacs.scm                             | 26 ++++++++++++++++++++++
 .../emacs-scheme-complete-scheme-r5rs-info.patch   | 11 +++++++++
 3 files changed, 38 insertions(+)
 create mode 100644 gnu/packages/patches/emacs-scheme-complete-scheme-r5rs-info.patch

diff --git a/gnu-system.am b/gnu-system.am
index 0039246..83a7e92 100644
--- a/gnu-system.am
+++ b/gnu-system.am
@@ -449,6 +449,7 @@ dist_patch_DATA =						\
   gnu/packages/patches/duplicity-test_selection-tmp.patch	\
   gnu/packages/patches/elfutils-tests-ptrace.patch		\
   gnu/packages/patches/emacs-exec-path.patch			\
+  gnu/packages/patches/emacs-scheme-complete-scheme-r5rs-info.patch	\
   gnu/packages/patches/eudev-rules-directory.patch		\
   gnu/packages/patches/evilwm-lost-focus-bug.patch		\
   gnu/packages/patches/expat-CVE-2015-1283.patch		\
diff --git a/gnu/packages/emacs.scm b/gnu/packages/emacs.scm
index 7d95f55..28b3ca0 100644
--- a/gnu/packages/emacs.scm
+++ b/gnu/packages/emacs.scm
@@ -1177,3 +1177,29 @@ for quotation marks, dashes, and ellipses.  For example, typing @kbd{\"}
 automatically inserts a Unicode opening or closing quotation mark, depending
 on context.")
     (license license:gpl3+)))
+
+(define-public emacs-scheme-complete
+  (package
+    (name "emacs-scheme-complete")
+    (version "20151223.9b5cf224bf")
+    (source
+     (origin
+       (method git-fetch)
+       (uri (git-reference
+             (url "https://github.com/ashinn/scheme-complete.git")
+             (commit "9b5cf224bf2a5994bc6d5b152ff487517f1a9bb5")))
+       (sha256
+        (base32
+         "141wn9l0m33w0g3dqmx8nxbfdny1r5xbr6ak61rsz21bk0qafs7x"))
+       (patches
+        (list (search-patch "emacs-scheme-complete-scheme-r5rs-info.patch")))))
+    (build-system emacs-build-system)
+    (home-page "https://github.com/ashinn/scheme-complete")
+    (synopsis
+     "Smart tab completion for Scheme in Emacs")
+    (description
+     "This file provides a single function, `scheme-smart-complete',
+which you can use for intelligent, context-sensitive completion for any Scheme
+implementation in Emacs.  To use it just load this file and bind that function
+to a key in your preferred mode.")
+    (license license:gpl3+))) ;; check license
diff --git a/gnu/packages/patches/emacs-scheme-complete-scheme-r5rs-info.patch b/gnu/packages/patches/emacs-scheme-complete-scheme-r5rs-info.patch
new file mode 100644
index 0000000..3e5d071
--- /dev/null
+++ b/gnu/packages/patches/emacs-scheme-complete-scheme-r5rs-info.patch
@@ -0,0 +1,11 @@
+--- scheme-complete-master/scheme-complete.el.orig	2015-12-25 21:59:09.896909029 +0100
++++ scheme-complete-master/scheme-complete.el	2015-12-25 21:59:17.924993998 +0100
+@@ -591,7 +591,7 @@
+            '((exact->inexact (lambda (z) z))
+              (inexact->exact (lambda (z) z)))
+            (mapcar #'(lambda (x)
+-                       (list x (scheme-env-lookup *scheme-r7rs-info* x)))
++                       (scheme-env-lookup *scheme-r7rs-info* x))
+                    *scheme-r5rs-bindings*))))
+   *scheme-r5rs-info*)
+ 
-- 
2.6.3

Re: [PATCH 1/6] gnu: Add emacs-scheme-complete.

[Federico Beffa]

[-- Attachment #1: Type: text/plain, Size: 422 bytes --]

On Wed, Dec 30, 2015 at 6:32 PM, Federico Beffa <beffa@ieee.org> wrote:
> Hi,
>
> I'm not sure about the license of this package. It just sates:
>
> ;;; This code is written by Alex Shinn and placed in the Public
> ;;; Domain.  All warranties are disclaimed.
>
> This is the same declaration (and author) as the file
> 'match.upstream.scm' in guile.

I added a 'file-name' field to the origin here as well.

Regards,
Fede

[-- Attachment #2: 0001-gnu-Add-emacs-scheme-complete.patch --]
[-- Type: text/x-diff, Size: 3602 bytes --]

From 61df8f50bd86fe14549095ab848ba887c5bb4185 Mon Sep 17 00:00:00 2001
From: Federico Beffa <beffa@fbengineering.ch>
Date: Thu, 24 Dec 2015 11:53:12 +0100
Subject: [PATCH 1/6] gnu: Add emacs-scheme-complete.

* gnu/packages/emacs.scm (emacs-scheme-complete): New variable.
* gnu/packages/patches/emacs-scheme-complete-scheme-r5rs-info.patch: New patch.
* gnu-system.am (dist_patch_DATA): Add the new patch.
---
 gnu-system.am                                      |  1 +
 gnu/packages/emacs.scm                             | 27 ++++++++++++++++++++++
 .../emacs-scheme-complete-scheme-r5rs-info.patch   | 11 +++++++++
 3 files changed, 39 insertions(+)
 create mode 100644 gnu/packages/patches/emacs-scheme-complete-scheme-r5rs-info.patch

diff --git a/gnu-system.am b/gnu-system.am
index 0039246..83a7e92 100644
--- a/gnu-system.am
+++ b/gnu-system.am
@@ -449,6 +449,7 @@ dist_patch_DATA =						\
   gnu/packages/patches/duplicity-test_selection-tmp.patch	\
   gnu/packages/patches/elfutils-tests-ptrace.patch		\
   gnu/packages/patches/emacs-exec-path.patch			\
+  gnu/packages/patches/emacs-scheme-complete-scheme-r5rs-info.patch	\
   gnu/packages/patches/eudev-rules-directory.patch		\
   gnu/packages/patches/evilwm-lost-focus-bug.patch		\
   gnu/packages/patches/expat-CVE-2015-1283.patch		\
diff --git a/gnu/packages/emacs.scm b/gnu/packages/emacs.scm
index 7d95f55..0cb8dc7 100644
--- a/gnu/packages/emacs.scm
+++ b/gnu/packages/emacs.scm
@@ -1177,3 +1177,30 @@ for quotation marks, dashes, and ellipses.  For example, typing @kbd{\"}
 automatically inserts a Unicode opening or closing quotation mark, depending
 on context.")
     (license license:gpl3+)))
+
+(define-public emacs-scheme-complete
+  (package
+    (name "emacs-scheme-complete")
+    (version "20151223.9b5cf224bf")
+    (source
+     (origin
+       (file-name (string-append name "-" version))
+       (method git-fetch)
+       (uri (git-reference
+             (url "https://github.com/ashinn/scheme-complete.git")
+             (commit "9b5cf224bf2a5994bc6d5b152ff487517f1a9bb5")))
+       (sha256
+        (base32
+         "141wn9l0m33w0g3dqmx8nxbfdny1r5xbr6ak61rsz21bk0qafs7x"))
+       (patches
+        (list (search-patch "emacs-scheme-complete-scheme-r5rs-info.patch")))))
+    (build-system emacs-build-system)
+    (home-page "https://github.com/ashinn/scheme-complete")
+    (synopsis
+     "Smart tab completion for Scheme in Emacs")
+    (description
+     "This file provides a single function, `scheme-smart-complete',
+which you can use for intelligent, context-sensitive completion for any Scheme
+implementation in Emacs.  To use it just load this file and bind that function
+to a key in your preferred mode.")
+    (license license:gpl3+))) ;; check license
diff --git a/gnu/packages/patches/emacs-scheme-complete-scheme-r5rs-info.patch b/gnu/packages/patches/emacs-scheme-complete-scheme-r5rs-info.patch
new file mode 100644
index 0000000..3e5d071
--- /dev/null
+++ b/gnu/packages/patches/emacs-scheme-complete-scheme-r5rs-info.patch
@@ -0,0 +1,11 @@
+--- scheme-complete-master/scheme-complete.el.orig	2015-12-25 21:59:09.896909029 +0100
++++ scheme-complete-master/scheme-complete.el	2015-12-25 21:59:17.924993998 +0100
+@@ -591,7 +591,7 @@
+            '((exact->inexact (lambda (z) z))
+              (inexact->exact (lambda (z) z)))
+            (mapcar #'(lambda (x)
+-                       (list x (scheme-env-lookup *scheme-r7rs-info* x)))
++                       (scheme-env-lookup *scheme-r7rs-info* x))
+                    *scheme-r5rs-bindings*))))
+   *scheme-r5rs-info*)
+ 
-- 
2.6.3

Re: [PATCH 1/6] gnu: Add emacs-scheme-complete.

[Ludovic Courtès]

Federico Beffa <beffa@ieee.org> skribis:

> On Wed, Dec 30, 2015 at 6:32 PM, Federico Beffa <beffa@ieee.org> wrote:
>> Hi,
>>
>> I'm not sure about the license of this package. It just sates:
>>
>> ;;; This code is written by Alex Shinn and placed in the Public
>> ;;; Domain.  All warranties are disclaimed.

So this should be ‘public-domain’ from (guix licenses).

> From 61df8f50bd86fe14549095ab848ba887c5bb4185 Mon Sep 17 00:00:00 2001
> From: Federico Beffa <beffa@fbengineering.ch>
> Date: Thu, 24 Dec 2015 11:53:12 +0100
> Subject: [PATCH 1/6] gnu: Add emacs-scheme-complete.
>
> * gnu/packages/emacs.scm (emacs-scheme-complete): New variable.
> * gnu/packages/patches/emacs-scheme-complete-scheme-r5rs-info.patch: New patch.
> * gnu-system.am (dist_patch_DATA): Add the new patch.

[...]

> +(define-public emacs-scheme-complete
> +  (package
> +    (name "emacs-scheme-complete")
> +    (version "20151223.9b5cf224bf")
> +    (source
> +     (origin
> +       (file-name (string-append name "-" version))
> +       (method git-fetch)
> +       (uri (git-reference
> +             (url "https://github.com/ashinn/scheme-complete.git")
> +             (commit "9b5cf224bf2a5994bc6d5b152ff487517f1a9bb5")))

Could you factorize the commit ID, as done by ‘libuv-julia’ for
instance?

> +    (synopsis
> +     "Smart tab completion for Scheme in Emacs")

Please move to previous line.

> +    (description
> +     "This file provides a single function, `scheme-smart-complete',

@code{scheme-smart-complete}

> +which you can use for intelligent, context-sensitive completion for any Scheme
> +implementation in Emacs.  To use it just load this file and bind that function
> +to a key in your preferred mode.")
> +    (license license:gpl3+))) ;; check license

license:public-domain

> diff --git a/gnu/packages/patches/emacs-scheme-complete-scheme-r5rs-info.patch b/gnu/packages/patches/emacs-scheme-complete-scheme-r5rs-info.patch
> new file mode 100644
> index 0000000..3e5d071
> --- /dev/null
> +++ b/gnu/packages/patches/emacs-scheme-complete-scheme-r5rs-info.patch

Please add a sentence explaining what this does, and possibly a link to
the upstream patch, bug report, or discussion.

OK with these changes, thanks!

Ludo’.