From mboxrd@z Thu Jan 1 00:00:00 1970 From: Al McElrath Subject: Re: [PATCH] gnu: Add pianobar. Date: Thu, 11 Feb 2016 13:36:13 -0800 Message-ID: <87io1vlyk2.fsf@atonesir.com> References: <87lh6rn0zf.fsf@atonesir.com> <871t8jvf3o.fsf@elephly.net> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:54557) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aTyug-0002xO-11 for guix-devel@gnu.org; Thu, 11 Feb 2016 16:36:35 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aTyue-0007Co-AH for guix-devel@gnu.org; Thu, 11 Feb 2016 16:36:33 -0500 Received: from [2600:3c01::f03c:91ff:fe73:aaa] (port=37789 helo=mail.atonesir.com) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aTyud-0007A2-UC for guix-devel@gnu.org; Thu, 11 Feb 2016 16:36:32 -0500 In-Reply-To: <871t8jvf3o.fsf@elephly.net> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: Ricardo Wurmus Cc: guix-devel@gnu.org --=-=-= Content-Type: text/plain Revised patch is attached. I updated/expanded the description and fixed the license. Thanks! --=-=-= Content-Type: text/x-diff; charset=utf-8 Content-Disposition: inline; filename=0001-gnu-Add-pianobar.patch Content-Transfer-Encoding: quoted-printable >From 91d5c428428eed605c981a39022fe90e6f98be6d Mon Sep 17 00:00:00 2001 From: Al McElrath Date: Fri, 11 Dec 2015 21:22:33 -0800 Subject: [PATCH] gnu: Add pianobar. * gnu/packages/music.scm (pianobar): New variable. --- gnu/packages/music.scm | 38 ++++++++++++++++++++++++++++++++++++++ 1 file changed, 38 insertions(+) diff --git a/gnu/packages/music.scm b/gnu/packages/music.scm index a60ba4b..1382b0a 100644 --- a/gnu/packages/music.scm +++ b/gnu/packages/music.scm @@ -2,6 +2,7 @@ ;;; Copyright =C2=A9 2014 Eric Bavier ;;; Copyright =C2=A9 2015, 2016 Ricardo Wurmus ;;; Copyright =C2=A9 2015 Paul van der Walt +;;; Copyright =C2=A9 2016 Al McElrath ;;; ;;; This file is part of GNU Guix. ;;; @@ -39,6 +40,7 @@ #:use-module (gnu packages code) #:use-module (gnu packages check) #:use-module (gnu packages compression) + #:use-module (gnu packages curl) #:use-module (gnu packages docbook) #:use-module (gnu packages doxygen) #:use-module (gnu packages flex) @@ -46,6 +48,7 @@ #:use-module (gnu packages fonts) #:use-module (gnu packages fontutils) #:use-module (gnu packages gcc) + #:use-module (gnu packages gnupg) #:use-module (gnu packages gettext) #:use-module (gnu packages ghostscript) #:use-module (gnu packages gl) @@ -1078,3 +1081,38 @@ computer's keyboard.") JACK for audio and ALSA sequencer for MIDI as multimedia infrastructures a= nd follows a traditional multi-track tape recorder control paradigm.") (license license:gpl2+))) + +(define-public pianobar + (package + (name "pianobar") + (version "2015.11.22") + (source (origin + (method url-fetch) + (uri (string-append "https://github.com/PromyLOPh/" + name "/archive/" version ".tar.gz")) + (file-name (string-append name "-" version ".tar.gz")) + (sha256 + (base32 + "022df19bhxqvkhy0qy21xahba5s1fm17b13y0p9p9dnf2yl44wfv")))) + (build-system gnu-build-system) + (arguments + `(#:tests? #f ; no tests + #:make-flags (list "CC=3Dgcc" "CFLAGS=3D-std=3Dc99" + (string-append "PREFIX=3D" %output)) + #:phases (modify-phases %standard-phases + (delete 'configure)))) + (inputs + `(("ao" ,ao) + ("curl" ,curl) + ("libgcrypt" ,libgcrypt) + ("json-c" ,json-c) + ("ffmpeg" ,ffmpeg))) + (native-inputs + `(("pkg-config" ,pkg-config))) + (home-page "http://6xq.net/projects/pianobar/") + (synopsis "Console-based pandora.com player") + (description "pianobar is a console-based music player for the +personalized online radio pandora.com. It has configurable keys for playi= ng +and managing stations, can be controlled remotely via fifo, and can run +event-based scripts for scrobbling, notifications, etc.") + (license license:expat))) --=20 2.5.0 --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Ricardo Wurmus writes: > Al McElrath writes: > >> Another new package. Feedback appreciated. > > Thank you for the patch! > >> This is free software, but it >> only works with a non-free music service, Pandora. Is that acceptable? > > The concept of =E2=80=9Cnon-free=E2=80=9D doesn=E2=80=99t directly apply = to services. See > =E2=80=9CUntangling the SaaSS Issue from the Proprietary Software Issue= =E2=80=9D here: > > https://www.gnu.org/philosophy/who-does-that-server-really-serve.en.html > > and also this: > > https://www.gnu.org/philosophy/network-services-arent-free-or-nonfree.h= tml > > I don=E2=80=99t know anything about Pandora (I do know my mythology, thou= gh), so > I=E2=80=99m not in a position to anticipate and answer questions about it= . In > general I think that if =E2=80=9Cpianobar=E2=80=9D itself is free softwar= e (which you > say it is) and you do not need to use non-free software to set it up in > the first place then it is probably acceptable. > > Now, on to a review of the patch! > >> From 4f477999635b4a16f19ef0833727abcf899dbb69 Mon Sep 17 00:00:00 2001 >> From: Al McElrath >> Date: Fri, 11 Dec 2015 21:22:33 -0800 >> Subject: [PATCH] gnu: Add pianobar. > >> * gnu/packages/music.scm (pianobar): New variable. >> --- >> gnu/packages/music.scm | 36 ++++++++++++++++++++++++++++++++++++ >> 1 file changed, 36 insertions(+) > >> diff --git a/gnu/packages/music.scm b/gnu/packages/music.scm >> index a60ba4b..c5a6dc5 100644 >> --- a/gnu/packages/music.scm >> +++ b/gnu/packages/music.scm >> @@ -2,6 +2,7 @@ >> ;;; Copyright =C2=A9 2014 Eric Bavier >> ;;; Copyright =C2=A9 2015, 2016 Ricardo Wurmus >> ;;; Copyright =C2=A9 2015 Paul van der Walt >> +;;; Copyright =C2=A9 2016 Al McElrath >> ;;; >> ;;; This file is part of GNU Guix. >> ;;; >> @@ -39,6 +40,7 @@ >> #:use-module (gnu packages code) >> #:use-module (gnu packages check) >> #:use-module (gnu packages compression) >> + #:use-module (gnu packages curl) >> #:use-module (gnu packages docbook) >> #:use-module (gnu packages doxygen) >> #:use-module (gnu packages flex) >> @@ -46,6 +48,7 @@ >> #:use-module (gnu packages fonts) >> #:use-module (gnu packages fontutils) >> #:use-module (gnu packages gcc) >> + #:use-module (gnu packages gnupg) >> #:use-module (gnu packages gettext) >> #:use-module (gnu packages ghostscript) >> #:use-module (gnu packages gl) >> @@ -1078,3 +1081,36 @@ computer's keyboard.") >> JACK for audio and ALSA sequencer for MIDI as multimedia infrastructure= s and >> follows a traditional multi-track tape recorder control paradigm.") >> (license license:gpl2+))) >> + >> +(define-public pianobar >> + (package >> + (name "pianobar") >> + (version "2015.11.22") >> + (source (origin >> + (method url-fetch) >> + (uri (string-append "https://github.com/PromyLOPh/" >> + name "/archive/" version ".tar.gz")) >> + (file-name (string-append name "-" version ".tar.gz")) >> + (sha256 >> + (base32 >> + "022df19bhxqvkhy0qy21xahba5s1fm17b13y0p9p9dnf2yl44wfv")= ))) >> + (build-system gnu-build-system) >> + (arguments >> + `(#:tests? #f ; no tests >> + #:make-flags (list "CC=3Dgcc" "CFLAGS=3D-std=3Dc99" >> + (string-append "PREFIX=3D" %output)) >> + #:phases (modify-phases %standard-phases >> + (delete 'configure)))) >> + (inputs >> + `(("ao" ,ao) >> + ("curl" ,curl) >> + ("libgcrypt" ,libgcrypt) >> + ("json-c" ,json-c) >> + ("ffmpeg" ,ffmpeg))) >> + (native-inputs >> + `(("pkg-config" ,pkg-config))) >> + (home-page "http://6xq.net/projects/pianobar/") >> + (synopsis "Console-based pandora.com player") >> + (description "pianobar is a free/open-source, console-based client = for the >> +personalized online radio Pandora.") > > Everything in Guix qualifies as free software, so we do not need to > explicitly mention that it is free software. Maybe the description is a > little bit short =E2=80=94 could you possibly incorporate parts of the fe= ature > list? > >> + (license license:x11))) > > I think it=E2=80=99s the Expat license, not X11. I only compared these > texts: > > https://github.com/PromyLOPh/pianobar/blob/master/COPYING > http://directory.fsf.org/wiki/License:Expat > http://directory.fsf.org/wiki/License:X11 > > Thanks again and welcome! > > ~~ Ricardo > > --=-=-=--