From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=)
Subject: Re: [PATCH 4/9] gnu: Add brotli.
Date: Wed, 13 Apr 2016 23:44:58 +0200
Message-ID: <87inzlb2ud.fsf@gnu.org>
References: <1459917181-19626-1-git-send-email-ericbavier@openmailbox.org>
	<1459917181-19626-4-git-send-email-ericbavier@openmailbox.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:53715)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1aqSav-0003hB-US
	for guix-devel@gnu.org; Wed, 13 Apr 2016 17:45:06 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1aqSav-0003W7-5G
	for guix-devel@gnu.org; Wed, 13 Apr 2016 17:45:05 -0400
In-Reply-To: <1459917181-19626-4-git-send-email-ericbavier@openmailbox.org>
	(ericbavier@openmailbox.org's message of "Tue, 5 Apr 2016 23:32:56
	-0500")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: ericbavier@openmailbox.org
Cc: guix-devel@gnu.org, Eric Bavier <bavier@member.fsf.org>

ericbavier@openmailbox.org skribis:

> From: Eric Bavier <bavier@member.fsf.org>
>
> * gnu/packages/compression.scm (brotli): New variable.

[...]

> +  (let ((commit "e992cce7a174d6e2b3486616499d26bb0bad6448"))
> +    (package
> +      (name "brotli")
> +      (version "0.1")

Please use a version string as noted in the guidelines (info "(guix)
Version Numbers").


[...]

> +       `(#:phases (modify-phases %standard-phases
> +                    (add-after 'unpack 'autogen
> +                      (lambda _
> +                        (mkdir "m4")
> +                        (system* "autoreconf" "-vfi"))))))

(zero? (system* =E2=80=A6))

> +      (synopsis "Brotli encoder/decoder libraries")

Maybe =E2=80=9CImplementation of the Brotli compression algorithm=E2=80=9D =
or something
like this to hint at the application domain?

> +      (description
> +       "This package provides Brotli encoder and decoder libraries: libb=
rotlienc
> +and libbrotlidec, respectively.")

Could you expound the description a little bit?  :-)

Thanks,
Ludo=E2=80=99.