From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=)
Subject: Re: [PATCH] Add Piranha.
Date: Wed, 27 Apr 2016 14:30:19 +0200
Message-ID: <87inz32q04.fsf@gnu.org>
References: <idj8u008nru.fsf@bimsb-sys02.mdc-berlin.net>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:60795)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1avObs-00068P-8C
	for guix-devel@gnu.org; Wed, 27 Apr 2016 08:30:29 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1avObm-0002xx-Cm
	for guix-devel@gnu.org; Wed, 27 Apr 2016 08:30:28 -0400
In-Reply-To: <idj8u008nru.fsf@bimsb-sys02.mdc-berlin.net> (Ricardo Wurmus's
	message of "Tue, 26 Apr 2016 16:09:41 +0200")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de>
Cc: "guix-devel@gnu.org" <guix-devel@gnu.org>

Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de> skribis:

> From 8ebcd50666e13407d2b74907c9bc5e37ee420192 Mon Sep 17 00:00:00 2001
> From: Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de>
> Date: Tue, 26 Apr 2016 16:08:47 +0200
> Subject: [PATCH] gnu: Add Piranha.
>
> * gnu/packages/bioinformatics.scm (piranha): New variable.

[...]

> +         (add-after 'unpack 'copy-smithlab-cpp
> +           (lambda* (#:key inputs #:allow-other-keys)
> +             (mkdir "src/smithlab_cpp")
> +             (for-each (lambda (file)
> +                         (copy-file file
> +                                    (string-append "./src/smithlab_cpp/"
> +                                                   (basename file))))

Rather:

  (install-file file "src/smithlab_cpp")

> +        ,(origin
> +           (method git-fetch)
> +           (uri (git-reference
> +                 (url "https://github.com/smithlabcode/smithlab_cpp.git")
> +                 (commit "3723e2d")))
> +           (file-name "smithlab_cpp-3723e2d-checkout")

Either remove the commit ID from =E2=80=98file-name=E2=80=99 or introduce a=
 =E2=80=98commit=E2=80=99
variable to avoid repetition.

> +    (home-page "https://github.com/smithlabcode/piranha")
> +    (synopsis "Peak-caller for CLIP-seq and RIP-seq data")
> +    (description
> +     "Piranha is a peak-caller for CLIP-seq and RIP-seq data.")

Could you expound a bit (info "(guix) Synopses and Descriptions")?  :-)

OK with these changes.

Thanks!

Ludo=E2=80=99.