Re: [PATCH] Add Piranha.

[ludo@gnu.org (Ludovic Courtès)]

Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de> skribis:

> From 8ebcd50666e13407d2b74907c9bc5e37ee420192 Mon Sep 17 00:00:00 2001
> From: Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de>
> Date: Tue, 26 Apr 2016 16:08:47 +0200
> Subject: [PATCH] gnu: Add Piranha.
>
> * gnu/packages/bioinformatics.scm (piranha): New variable.

[...]

> +         (add-after 'unpack 'copy-smithlab-cpp
> +           (lambda* (#:key inputs #:allow-other-keys)
> +             (mkdir "src/smithlab_cpp")
> +             (for-each (lambda (file)
> +                         (copy-file file
> +                                    (string-append "./src/smithlab_cpp/"
> +                                                   (basename file))))

Rather:

  (install-file file "src/smithlab_cpp")

> +        ,(origin
> +           (method git-fetch)
> +           (uri (git-reference
> +                 (url "https://github.com/smithlabcode/smithlab_cpp.git")
> +                 (commit "3723e2d")))
> +           (file-name "smithlab_cpp-3723e2d-checkout")

Either remove the commit ID from ‘file-name’ or introduce a ‘commit’
variable to avoid repetition.

> +    (home-page "https://github.com/smithlabcode/piranha")
> +    (synopsis "Peak-caller for CLIP-seq and RIP-seq data")
> +    (description
> +     "Piranha is a peak-caller for CLIP-seq and RIP-seq data.")

Could you expound a bit (info "(guix) Synopses and Descriptions")?  :-)

OK with these changes.

Thanks!

Ludo’.