Re: udev rules and system configuration

[ludo@gnu.org (Ludovic Courtès)]

Ricardo Wurmus <rekado@elephly.net> skribis:

> Ludovic Courtès <ludo@gnu.org> writes:
>
>> Hello!
>>
>> Ricardo Wurmus <rekado@elephly.net> skribis:
>>
>>> For my AVR programmers I have this in my system configuration:
>>>
>>> ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>>> (define avrispmkii-udev-rule
>>>   (udev-rule "90-avrispmkii.rules"
>>>              "\
>>> SUBSYSTEM!=\"usb\", ACTION!=\"add\", GOTO=\"avrisp_end\"
>>>
>>> # Atmel Corp. JTAG ICE mkII
>>> ATTR{idVendor}==\"03eb\", ATTR{idProduct}==\"2103\", MODE=\"660\", GROUP=\"dialout\"
>>> # Atmel Corp. AVRISP mkII
>>> ATTR{idVendor}==\"03eb\", ATTR{idProduct}==\"2104\", MODE=\"660\", GROUP=\"dialout\"
>>> # Atmel Corp. Dragon
>>> ATTR{idVendor}==\"03eb\", ATTR{idProduct}==\"2107\", MODE=\"660\", GROUP=\"dialout\"
>>>
>>> LABEL=\"avrisp_end\"\n"))
>>>
>>> (operating-system
>>>   …
>>>   (services (cons* (modify-services %desktop-services
>>>                      (udev-service-type config =>
>>>                                         (udev-configuration
>>>                                          (inherit config)
>>>                                          (rules (append (udev-configuration-rules config)
>>>                                                         (list avrispmkii-udev-rule))))))))
>>> ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>>
>> Should we add this as an optional service or to the default set of udev
>> rules?
>
> I don’t think this should be the default.  This rule is only useful for
> those who own one of Atmel’s USB programmer devices.  There is a
> multitude of programmers for AVRs and users may want to use different
> rules for different devices.
>
> However, I’ve been wondering if we shouldn’t introduce nicer
> abstractions for udev rules and make loading them a little less verbose.
> It’s a bit unfortunate that while on other systems users are often told
> to just dump a file somewhere in “/etc” to make device access work
> without root on GuixSD it’s quite a bit more involved to achieve the
> same.

Yeah, it doesn’t support the quick-hack style of doing things, which can
be frustrating.

> Our documentation is also a little lacking in this respect.  The manual
> has very little to say about the “udev-service” and how to extend it (or
> any of the other services, really), making it hard for users coming from
> other systems to find where they need to change something to make the
> udev rules work that they were told to add somewhere.

Yeah.

> Here’s an idea, which might be bad: how about adding a feature to load
> and merge a directory tree of configuration files as they are?  For
> example, if I had a directory “/etc/guix/system/udev/rules.d” then all
> files therein would automatically be considered part of the system
> configuration, maybe after adding “/etc/guix/system” as a prefix path to
> some new field in the “operating-system” declaration.
>
> I have a feeling that this will be considered a bad idea, but it also
> seems to me that it would make the configuration of some parts of the
> system easier than embedding file contents as strings in variables in
> “/etc/config.scm” and modifying services manually.

It’s a bad idea!  :-)

Seriously, I think having a directory that is automatically picked up is
a bad idea in the sense that it would defeat one of the main goals of
GuixSD, which is to support reproducibility.  The hypothetical
/etc/guix/udev directory would not be controlled by GuixSD, so rolling
back wouldn’t be enough to return to the previous state, copying the
GuixSD config file wouldn’t be enough to duplicate the system state on
another machine, and so on.

However, what we can do is improve the interface.  Things that come to
mind:

  1. Change or remove the ‘udev-rule’ procedure; we should be using
     file-like objects instead, so one could store them alongside
     config.scm and write:

       (local-file "./my-udev-rule")

  2. Add a ‘extra-udev-rule’ procedure that you could use like this:

       (operating-system
         ;; …
         (services (extra-udev-rule (local-file "./my-udev-rule"))
                   …))

     thus avoiding the verbose ‘modify-services’ stanza.

  3. (Instead of #2) Introduce a ‘udev-rules’ field in
     ‘operating-system’, just like we do for firmware.

WDYT?

I don’t deny that this is still more heavyweight than dropping a file in
/etc.  We should think about other ways to improve on that (what would
be the equivalent of C-M-x for GuixSD?), but for now it’s the only way I
can think of to preserve reproducibility.

Ludo’.