From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ricardo Wurmus <rekado@elephly.net>
Subject: Re: [PATCH 2/3] gnu: Add r-svglite.
Date: Wed, 06 Jul 2016 07:30:32 +0200
Message-ID: <87inwjl4ef.fsf@elephly.net>
References: <20160705130635.668-1-donttrustben@gmail.com>
	<20160705130635.668-3-donttrustben@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:52799)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rekado@elephly.net>) id 1bKfQ1-0008SN-On
	for guix-devel@gnu.org; Wed, 06 Jul 2016 01:30:42 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <rekado@elephly.net>) id 1bKfPy-0003V9-Dq
	for guix-devel@gnu.org; Wed, 06 Jul 2016 01:30:41 -0400
Received: from sender163-mail.zoho.com ([74.201.84.163]:24884)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rekado@elephly.net>) id 1bKfPy-0003V5-5H
	for guix-devel@gnu.org; Wed, 06 Jul 2016 01:30:38 -0400
In-reply-to: <20160705130635.668-3-donttrustben@gmail.com>
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: Ben Woodcroft <donttrustben@gmail.com>
Cc: guix-devel@gnu.org


Ben Woodcroft <donttrustben@gmail.com> writes:

> * gnu/packages/statistics.scm (r-svglite): New variable.
> ---
>  gnu/packages/statistics.scm | 25 +++++++++++++++++++++++++
>  1 file changed, 25 insertions(+)
>
> diff --git a/gnu/packages/statistics.scm b/gnu/packages/statistics.scm
> index 24fbabe..6f27aa6 100644
> --- a/gnu/packages/statistics.scm
> +++ b/gnu/packages/statistics.scm
> @@ -634,6 +634,31 @@ aesthetic attributes.")
>  and to generate base64 encoded string from raster matrix.")
>      (license license:gpl3)))
>  
> +(define-public r-svglite
> +  (package
> +    (name "r-svglite")
> +    (version "1.1.0")
> +    (source
> +     (origin
> +       (method url-fetch)
> +       (uri (cran-uri "svglite" version))
> +       (sha256
> +        (base32
> +         "11ryicjglfi6jvkk4jgg5kra42qbs5z2zid7jjhlslpjcljfwc70"))))
> +    (build-system r-build-system)
> +    (native-inputs  `(("r-rcpp" ,r-rcpp)))
> +    (propagated-inputs
> +     `(("r-bh" ,r-bh)
> +       ("r-gdtools" ,r-gdtools)))
> +    (home-page "https://github.com/hadley/svglite")
> +    (synopsis "An 'SVG' Graphics Device")

How about just “SVG graphics device”?

> +    (description
> +     "@code{svglite} is a graphics device that produces clean SVG (Scalable
> +Vector Graphics) output, suitable for use on the web, or hand
> editing.

How about

    @dfn{SVG} (Scalable Vector Graphics)

?

> +Compared to the built-in @code{svg()}, @code{svglite} is considerably faster,
> +produces smaller files, and leaves text as is.")
> +    (license license:gpl2+)))
> +

The rest looks fine.

~~ Ricardo