From mboxrd@z Thu Jan 1 00:00:00 1970 From: ng0 Subject: Re: [PATCH]: gnu: gnurl: Update to 7.50.1. Date: Sun, 14 Aug 2016 09:18:11 +0000 Message-ID: <87inv3r9nw.fsf@we.make.ritual.n0.is> References: <87h9azqncs.fsf@we.make.ritual.n0.is> <87y44bclh5.fsf@we.make.ritual.n0.is> <20160805154952.GA19656@jasmine> <87eg636vvq.fsf@we.make.ritual.n0.is> <87invfxels.fsf@we.make.ritual.n0.is> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:55151) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bYrYe-00017U-LK for guix-devel@gnu.org; Sun, 14 Aug 2016 05:18:17 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bYrYc-0002cO-Ai for guix-devel@gnu.org; Sun, 14 Aug 2016 05:18:15 -0400 Received: from mithlond.libertad.in-berlin.de ([2001:67c:1400:2490::1]:51835 helo=beleriand.n0.is) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bYrYb-0002cC-TX for guix-devel@gnu.org; Sun, 14 Aug 2016 05:18:14 -0400 Received: by beleriand.n0.is (OpenSMTPD) with ESMTPSA id e6f0bd1e TLS version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO for ; Sun, 14 Aug 2016 09:18:12 +0000 (UTC) In-Reply-To: <87invfxels.fsf@we.make.ritual.n0.is> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: guix-devel@gnu.org ng0 writes: > ng0 writes: > >> Leo Famulari writes: >> >>> On Fri, Aug 05, 2016 at 02:57:10PM +0000, ng0 wrote: >>>> From 81f605a551a3cfcfe48fae27fd7aa5d9affa4bd2 Mon Sep 17 00:00:00 2001 >>>> From: ng0 >>>> Date: Fri, 5 Aug 2016 14:44:38 +0000 >>>> Subject: [PATCH] gnu: gnurl: Update to 7.50.1. >>>> >>>> * gnu/packages/gnunet.scm (gnurl): Update to 7.50.1. >>>> [configure-flags]: Configure with --disable-smb. >>>> Disable test1139. >>> >>> Can you add a comment explaining why test1139 is disabled? Just saying >>> that it won't work doesn't tell those reading the package why it is >>> disabled. >> >> My assumption: files or lines of code are searched which will not exist >> in gnurl. If this is not just us (sadly in Gentoo i have test/checks >> disabled for this package), I will fix this upstream. >> If your perl knowledge is better look at the failing test yourself. This >> is my best judgment with the little perl knowledge I have. >> It was just ruling out what could cause the test failure. > > Is this okay? Can someone tell me if this is okay or if it needs further changes? I'd like to update this. > From 8b99ce31e269334aa339af27c3e78577f73052ce Mon Sep 17 00:00:00 2001 > From: ng0 > Date: Fri, 5 Aug 2016 14:44:38 +0000 > Subject: [PATCH] gnu: gnurl: Update to 7.50.1. > > * gnu/packages/gnunet.scm (gnurl): Update to 7.50.1. > [configure-flags]: Configure with --disable-smb. > Disable test1139. > --- > gnu/packages/gnunet.scm | 19 +++++++++++++------ > 1 file changed, 13 insertions(+), 6 deletions(-) > > diff --git a/gnu/packages/gnunet.scm b/gnu/packages/gnunet.scm > index 4d888bd..36aa8c0 100644 > --- a/gnu/packages/gnunet.scm > +++ b/gnu/packages/gnunet.scm > @@ -153,7 +153,7 @@ and support for SSL3 and TLS.") > (define-public gnurl > (package > (name "gnurl") > - (version "7.48.0") > + (version "7.50.1") > (source (origin > (method url-fetch) > (uri (let ((version-with-underscores > @@ -162,7 +162,7 @@ and support for SSL3 and TLS.") > name "-" version-with-underscores ".tar.bz2"))) > (sha256 > (base32 > - "14gch4rdibrc8qs4mijsczxvl45dsclf234g17dk6c8nc2s4bm0a")))) > + "0irb8df3lqd9w1pb627q260hn448vbkh0sn4l6p6jh0q8lqscv84")))) > (build-system gnu-build-system) > (inputs `(("gnutls" ,gnutls) > ("libidn" ,libidn) > @@ -183,17 +183,24 @@ and support for SSL3 and TLS.") > "--disable-ldap" "--disable-rtsp" "--disable-dict" > "--disable-telnet" "--disable-tftp" "--disable-pop3" > "--disable-imap" "--disable-smtp" "--disable-gopher" > - "--disable-file" "--disable-ftp") > + "--disable-file" "--disable-ftp" "--disable-smb") > #:test-target "test" > #:parallel-tests? #f > - ;; We have to patch runtests.pl in tests/ directory > #:phases > + ;; We have to patch runtests.pl in tests/ directory > (alist-cons-before > 'check 'patch-runtests > (lambda _ > (substitute* "tests/runtests.pl" > - (("/bin/sh") (which "sh")))) > - %standard-phases))) > + (("/bin/sh") (which "sh")))) > + ;; This test is disabled because of some reduction in code gnurl > + ;; implies, it can not succeed when some functions it expects are > + ;; not built. > + (alist-cons-before > + 'check 'delete-failing-test1139 > + (lambda _ > + (delete-file "tests/data/test1139")) > + %standard-phases)))) > (synopsis "Microfork of cURL with support for the HTTP/HTTPS/GnuTLS subset of cURL") > (description > "Gnurl is a microfork of cURL, a command line tool for transferring data > -- > 2.9.2 > > > > -- > ♥Ⓐ ng0 > Current Keys: https://we.make.ritual.n0.is/ng0.txt > For non-prism friendly talk find me on http://www.psyced.org -- ♥Ⓐ ng0 For non-prism friendly talk find me on http://www.psyced.org