From: Alex Kost <alezost@gmail.com>
To: ng0 <ng0@we.make.ritual.n0.is>
Cc: guix-devel <guix-devel@gnu.org>
Subject: Re: pre-release [PATCH] git-service [v2]
Date: Sat, 27 Aug 2016 23:09:16 +0300 [thread overview]
Message-ID: <87inumdleb.fsf@gmail.com> (raw)
In-Reply-To: <87mvjykypr.fsf@we.make.ritual.n0.is> (ng0@we.make.ritual.n0.is's message of "Sat, 27 Aug 2016 15:39:44 +0000")
ng0 (2016-08-27 18:39 +0300) wrote:
[...]
> (eval-when (expand load eval) (set! %load-path (cons "/gnu/store/8s6z5k9nfp3fyfj39vq6js8sfhxkn0y6-module-import" %load-path))
> (set! %load-compiled-path (cons "/gnu/store/lc0bj2nlmdgyqkkpd008hcnrpl068yr8-module-import-compiled"
> %load-compiled-path)))(begin (use-modules (shepherd service) (oop goops)
> (guix build utils) (guix build syscalls)) (make <service> #:docstring
> (quote "Git daemon server for git repositories") #:provides (quote
> (git)) #:requires (quote (networking syslogd)) #:respawn? (quote #t)
> #:start (make-forkexec-constructor (list (string-append "/gnu/store/f6b2a4ic4lzjv48s1w0kn6m5mxkj0qs4-git-2.9.3" "/bin/git")
> "daemon" "--syslog" "--informative-errors" "--port=" "9418" "--base-path=" "/var/git/repositories")) #:stop (make-kill-destructor)))
> ^______^ ^_____________^
> those two should be
> combined, same for the
> two afterwards?
Indeed! See how useful it is to look at the result .scm file :-)
You can be assured that the above thing doesn't work by running
something like this in a guile REPL:
(system* "git" "daemon" "--port=" "9418" "--base-path=/tmp/git-daemon-dir")
while this works (assuming that "/tmp/git-daemon-dir" exists):
(system* "git" "daemon" "--port=9418" "--base-path=/tmp/git-daemon-dir")
So you need to 'string-append' the port and base-path as you did for the
git command.
(I didn't try the service, so I don't know if there are other problems,
but you are getting closer, keep going!)
--
Alex
next prev parent reply other threads:[~2016-08-27 20:09 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-08 15:53 pre-release [PATCH] git-service ng0
2016-07-08 18:24 ` Thompson, David
2016-07-08 20:41 ` Ricardo Wurmus
2016-07-09 1:08 ` ng0
2016-07-13 10:23 ` ng0
2016-07-13 16:37 ` pre-release [PATCH] git-service [v2] ng0
2016-07-14 9:07 ` ng0
2016-08-11 15:55 ` ng0
2016-08-19 9:02 ` ng0
2016-08-22 8:03 ` Alex Kost
2016-08-25 9:55 ` ng0
2016-08-26 4:50 ` Alex Kost
2016-08-27 15:39 ` ng0
2016-08-27 20:09 ` Alex Kost [this message]
2016-08-27 20:44 ` ng0
2016-08-28 0:04 ` ng0
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87inumdleb.fsf@gmail.com \
--to=alezost@gmail.com \
--cc=guix-devel@gnu.org \
--cc=ng0@we.make.ritual.n0.is \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.