From mboxrd@z Thu Jan 1 00:00:00 1970 From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=) Subject: Re: [PATCH (3)] gnu: Add NFS related services (moved idmap.conf out of /etc, added texinfo markup to documentation, s/dir/directory) Date: Thu, 06 Oct 2016 21:49:36 +0200 Message-ID: <87int5i7fz.fsf@gnu.org> References: <87shshoasi.fsf@gnu.org> <1475719718-3369-1-git-send-email-jmd@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:36793) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bsEfo-0000DH-F1 for guix-devel@gnu.org; Thu, 06 Oct 2016 15:49:45 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bsEfk-0000Pb-Pg for guix-devel@gnu.org; Thu, 06 Oct 2016 15:49:43 -0400 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:60098) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bsEfk-0000PD-MW for guix-devel@gnu.org; Thu, 06 Oct 2016 15:49:40 -0400 In-Reply-To: <1475719718-3369-1-git-send-email-jmd@gnu.org> (John Darrington's message of "Thu, 6 Oct 2016 04:08:38 +0200") List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: John Darrington Cc: guix-devel@gnu.org Hi! John Darrington skribis: > * gnu/services/nfs.scm (pipefs-service-type): New Variable, > (gss-service-type): New Variable, (idmap-service-type) New Variable. > > * doc/guix.texi (Network File system): New Node. Minor issues, and a suggestion for the pipefs service: > +The @code{(gnu services nfs)} module provides the following services, > +which are most commonly used in relation to mounting or exporting NFS > +file systems. Rather something like: =E2=80=9Cmounting or exporting directory trees as @dfn{network file systems= } (NFS).=E2=80=9D > @subsubheading RPC Bind Service > @cindex rpcbind >=20=20 > -The @code{(gnu services nfs)} module provides the following: > +The RPC Bind service provides a facility to map program numbers into s/program numbers/ONC@tie{}RPC program numbers/ > +universal addresses. =E2=80=9CIP addresses=E2=80=9D? + =E2=80=9C (RPC stands for @dfn{remote procedure call})=E2=80=9D > + (shepherd-service > + (documentation "Mount the pipefs pseudo filesystem.") ^ Extra space. > + (provision '(rpc-pipefs)) > + > + (start #~(lambda () > + (mkdir-p #$pipefs-directory) > + (mount "rpc_pipefs" #$pipefs-directory "rpc_pipefs"))) > + (stop #~(lambda (pid . args) > + (umount #$pipefs-directory MNT_DETACH))))))) There=E2=80=99s the problem that =E2=80=98start=E2=80=99 must return a trut= h value (to tell the Shepherd that the service was correctly =E2=80=9Cstarted=E2=80=9D), so it= =E2=80=99s better to add an explicit #t at the end; conversely, =E2=80=98stop=E2=80=99 must retu= rn #f to denote a successful stop. However, as mentioned at , I think it would be best to achieve this by extending =E2=80=98file-system-service-type=E2=80=99. Could you try that? If it works, I don=E2=80=99t have any further comments. > + (define idmap-command > + #~(list (string-append #$nfs-utils "/sbin/rpc.idmapd") "-f" #$(file-append nfs-utils "/sbin/rpc.idmapd") > + (shepherd-service > + (documentation "Start the RPC IDMAP daemon.") ^ Missing space this time. :-) Thank you! Ludo=E2=80=99.