From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=)
Subject: Re: [PATCH 05/15] gnu: Add chez-matchable.
Date: Mon, 17 Oct 2016 15:54:40 +0200
Message-ID: <87insr9j47.fsf@gnu.org>
References: <CAKrPhPPQm49Y7cnkLbzHYUgOB-RHMAZRxJCeVkkXQBKUDeJ7Bw@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:45142)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1bw8NK-0002gJ-Jo
	for guix-devel@gnu.org; Mon, 17 Oct 2016 09:54:47 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1bw8NG-00052D-PW
	for guix-devel@gnu.org; Mon, 17 Oct 2016 09:54:46 -0400
In-Reply-To: <CAKrPhPPQm49Y7cnkLbzHYUgOB-RHMAZRxJCeVkkXQBKUDeJ7Bw@mail.gmail.com>
	(Federico Beffa's message of "Sun, 16 Oct 2016 17:31:44 +0200")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: Federico Beffa <beffa@ieee.org>
Cc: Guix-devel <guix-devel@gnu.org>

Federico Beffa <beffa@ieee.org> skribis:

> From 5821d3e41e37df01492141f128a0a09b5e70498f Mon Sep 17 00:00:00 2001
> From: Federico Beffa <beffa@fbengineering.ch>
> Date: Sun, 16 Oct 2016 16:08:33 +0200
> Subject: [PATCH 05/15] gnu: Add chez-matchable.
>
> * gnu/packages/chez.scm (chez-matchable): New variable.

[...]

> +;; Help function for Chez Scheme to add the current path to
> +;; CHEZSCHEMELIBDIRS.
> +(define chez-configure
> +  '(lambda _
> +     (let ((chez-env (getenv "CHEZSCHEMELIBDIRS")))
> +       (setenv "CHEZSCHEMELIBDIRS"
> +               (if chez-env
> +                   (string-append ".:" chez-env)
> +                   "."))
> +       #t)))

Would it make sense to define a chez-build-system?

> +;; Help function to define make flags for some Chez Scheme custom make
> +;; files.
> +(define (chez-make-flags name version)
> +  `(let ((out (assoc-ref %outputs "out")))
> +     (list (string-append "PREFIX=3D" out)
> +           (string-append "DOCDIR=3D" out "/share/doc/"
> +                          ,name "-" ,version))))
> +
> +(define-public chez-matchable
> +  (package
> +    (name "chez-matchable")
> +    (version "20160306")
> +    (source
> +     (origin
> +       (method url-fetch)
> +       (uri (string-append
> +             "https://github.com/fedeinthemix/chez-matchable/archive"

It=E2=80=99s a good idea to define =E2=80=98home-page=E2=80=99 above and re=
use it here.

> +    (description "This package provides a superset of the popular
> +Scheme 'match' package by Andrew Wright, written in fully portable
> +'syntax-rules' and thus preserving hygiene.")

@code{match} and @code{syntax-rules}.

Otherwise LGTM, thanks!

Ludo=E2=80=99.