Re: [PATCH 05/15] gnu: Add chez-matchable.

[ludo@gnu.org (Ludovic Courtès)]

Federico Beffa <beffa@ieee.org> skribis:

> From 5821d3e41e37df01492141f128a0a09b5e70498f Mon Sep 17 00:00:00 2001
> From: Federico Beffa <beffa@fbengineering.ch>
> Date: Sun, 16 Oct 2016 16:08:33 +0200
> Subject: [PATCH 05/15] gnu: Add chez-matchable.
>
> * gnu/packages/chez.scm (chez-matchable): New variable.

[...]

> +;; Help function for Chez Scheme to add the current path to
> +;; CHEZSCHEMELIBDIRS.
> +(define chez-configure
> +  '(lambda _
> +     (let ((chez-env (getenv "CHEZSCHEMELIBDIRS")))
> +       (setenv "CHEZSCHEMELIBDIRS"
> +               (if chez-env
> +                   (string-append ".:" chez-env)
> +                   "."))
> +       #t)))

Would it make sense to define a chez-build-system?

> +;; Help function to define make flags for some Chez Scheme custom make
> +;; files.
> +(define (chez-make-flags name version)
> +  `(let ((out (assoc-ref %outputs "out")))
> +     (list (string-append "PREFIX=" out)
> +           (string-append "DOCDIR=" out "/share/doc/"
> +                          ,name "-" ,version))))
> +
> +(define-public chez-matchable
> +  (package
> +    (name "chez-matchable")
> +    (version "20160306")
> +    (source
> +     (origin
> +       (method url-fetch)
> +       (uri (string-append
> +             "https://github.com/fedeinthemix/chez-matchable/archive"

It’s a good idea to define ‘home-page’ above and reuse it here.

> +    (description "This package provides a superset of the popular
> +Scheme 'match' package by Andrew Wright, written in fully portable
> +'syntax-rules' and thus preserving hygiene.")

@code{match} and @code{syntax-rules}.

Otherwise LGTM, thanks!

Ludo’.