Re: [PATCH] gnu: Add hdf-eos2.

[ludo@gnu.org (Ludovic Courtès)]

Hi!

Thomas Danckaert <post@thomasdanckaert.be> skribis:

> this patch adds HDF-EOS2 (which, somewhat confusingly, is completely
> independent from HDF-EOS5).
>
> I'm not sure what the best version name is.  The tarball is
> HDF-EOS2.19v1.00.tar.Z, but documentation sometimes refers to it as
> “version 2.19”.  The 2 is part of the library name, though, so I went
> with (version "19.1.0") in the end :-).  Is there a policy for version
> labeling in Guix, and would (version "19v1.00") be ok?

There’s no policy for weird cases like this.  :-)  I personally prefer
“19.1.0”.

> From 53f69f5b4f0931b259ddd41ef25fc88a2ec6c26a Mon Sep 17 00:00:00 2001
> From: Thomas Danckaert <thomas.danckaert@gmail.com>
> Date: Fri, 30 Sep 2016 09:59:08 +0200
> Subject: [PATCH] gnu: Add hdf-eos2.
>
> * gnu/packages/maths.scm (hdf-eos2): New variable.
> * gnu/packages/patches/hdf-eos2-build-shared.patch: New file.
> * gnu/packages/patches/hdf-eos2-remove-gctp.patch: New file.
> * gnu/packages/patches/hdf-eos2-fortrantests.patch: New file.
> * gnu/local.mk (dist_patch_DATA): Add patches.
> +    (synopsis "HDF4-based data format for NASA's Earth Observing System")
> +    (description "HDF-EOS2 is a software library built on HDF4 which supports
> +the construction of data structures used in NASA's Earth Observing
> +system (Grid, Point and Swath).")
   ^
Capital S?

> --- /dev/null
> +++ b/gnu/packages/patches/hdf-eos2-build-shared.patch
> @@ -0,0 +1,23 @@

Please add a comment at the beginning of this patch.

> --- /dev/null
> +++ b/gnu/packages/patches/hdf-eos2-fortrantests.patch
> @@ -0,0 +1,329 @@
> +Fix multi-line string formatting in fortran test programs (reported upstream).

If there’s a URL for the bug report or upstream commit, could you add it
here?

The rest LGTM.

Could you send an updated patch?

Thanks!

Ludo’.