From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ricardo Wurmus Subject: Re: [PATCH 08/16] gnu: Add python-bleach. Date: Fri, 4 Nov 2016 11:32:23 +0100 Message-ID: <87ins3a62w.fsf@mdc-berlin.de> References: <20161101122046.751-1-ricardo.wurmus@mdc-berlin.de> <20161101122046.751-9-ricardo.wurmus@mdc-berlin.de> <87a8djmhbt.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:54106) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c2bnW-0000MC-IO for guix-devel@gnu.org; Fri, 04 Nov 2016 06:32:35 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1c2bnT-0003cn-9r for guix-devel@gnu.org; Fri, 04 Nov 2016 06:32:34 -0400 In-Reply-To: <87a8djmhbt.fsf@gnu.org> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Roel Janssen Cc: guix-devel@gnu.org Roel Janssen writes: > Ricardo Wurmus writes: > >> * gnu/packages/python.scm (python-bleach, python2-bleach): New >> variables. >> --- >> gnu/packages/python.scm | 26 ++++++++++++++++++++++++++ >> 1 file changed, 26 insertions(+) >> >> diff --git a/gnu/packages/python.scm b/gnu/packages/python.scm >> index 590ba43..a2d3d3c 100644 >> --- a/gnu/packages/python.scm >> +++ b/gnu/packages/python.scm >> @@ -6693,6 +6693,32 @@ Jupyter Notebook format and Python APIs for wor= king with notebooks.") >> (define-public python2-nbformat >> (package-with-python2 python-nbformat)) >> =20 >> +(define-public python-bleach >> + (package >> + (name "python-bleach") >> + (version "1.4.3") >> + (source >> + (origin >> + (method url-fetch) >> + (uri (pypi-uri "bleach" version)) >> + (sha256 >> + (base32 >> + "0jvg3jxrvnx7xmm9gj262v60ib452xlnwlb0navyp7jsvcd0d4qj")))) >> + (build-system python-build-system) >> + (propagated-inputs >> + `(("python-html5lib" ,python-html5lib-0.9) > > If you add the following snippet, it does not need this older version o= f > html5lib to build. > > (arguments > `(#:phases > (modify-phases %standard-phases > (add-after 'unpack 'fix-html5lib-version > (lambda* (#:key inputs #:allow-other-keys) > (substitute* "setup.py" > (("'html5lib>=3D0.999,<0.99999999',") "'html5lib',")))))= )) > > I don't know whether this modification is problematic later on when > running Jupyter (I'm not there yet). I=E2=80=99d rather not do this, because they purposefully restricted the = range. It used to be less restrictive, so I=E2=80=99m assuming that there=E2=80=99= s a good reason for not using the latest version of html5lib. ~~ Ricardo