[PATCH] import/cpan: Maybe coerce version to string

[PATCH] import/cpan: Maybe coerce version to string

[Alex Sassmannshausen]

Hello,

Sometimes json-fetch returns a number for version in the CPAN importer, when a
string is expected.

This simple patch performs a match on the value returned by json-fetch, to
coerce the number to string if necessary.

WDYT?

Alex

Alex Sassmannshausen (1):
  import/cpan: Maybe coerce version to string.

 guix/import/cpan.scm | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

-- 
2.10.1

[PATCH] import/cpan: Maybe coerce version to string.

[Alex Sassmannshausen]

* guix/import/cpan.scm (cpan-module->sexp) <version>: Test if version in
  meta is string or number.  If it is number, coerce to string.
---
 guix/import/cpan.scm | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/guix/import/cpan.scm b/guix/import/cpan.scm
index 5b7c475..d244969 100644
--- a/guix/import/cpan.scm
+++ b/guix/import/cpan.scm
@@ -128,7 +128,9 @@ META."
         (string-append "perl-" (string-downcase name))))
 
   (define version
-    (assoc-ref meta "version"))
+    (match (assoc-ref meta "version")
+      ((? number? vrs) (number->string vrs))
+      ((? string? vrs) vrs)))
 
   (define core-module?
     (let ((perl-version (package-version perl))
-- 
2.10.1

Re: [PATCH] import/cpan: Maybe coerce version to string.

[Ludovic Courtès]

Alex Sassmannshausen <alex.sassmannshausen@gmail.com> skribis:

> * guix/import/cpan.scm (cpan-module->sexp) <version>: Test if version in
>   meta is string or number.  If it is number, coerce to string.

LGTM, thanks!

Ludo’.