all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: ludo@gnu.org (Ludovic Courtès)
To: iyzsong@openmailbox.org
Cc: guix-devel@gnu.org
Subject: Re: [PATCH]: tests: Add opensmtpd-service-type test
Date: Sat, 26 Nov 2016 23:21:19 +0100	[thread overview]
Message-ID: <87inr9naqo.fsf@gnu.org> (raw)
In-Reply-To: <161f9ae82e6ff5a8@localhost> (iyzsong@openmailbox.org's message of "Sat, 26 Nov 2016 09:52:41 +0000 (UTC)")

iyzsong@openmailbox.org skribis:

> My first system test patch, TIA for review!
>
> From 6107b011ee9f0fc445aeceeab38b963c6cf84b3a Mon Sep 17 00:00:00 2001
> From: =?UTF-8?q?=E5=AE=8B=E6=96=87=E6=AD=A6?= <iyzsong@member.fsf.org>
> Date: Sat, 26 Nov 2016 13:51:58 +0800
> Subject: [PATCH] tests: Add 'opensmtpd-service-type' test.
>
> * gnu/tests/mail.scm: New file.
> * gnu/local.mk (GNU_SYSTEM_MODULES): Add it.

I wasn’t able to run it because of missing substitutes for QEMU and lack
of patience ;-), but it looks very good to me!  It even seems to be
generic and applicable to any MTA, should other MTAs be added in the
future.

Thank you!

Ludo’.

  reply	other threads:[~2016-11-26 22:21 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-26  9:52 [PATCH]: tests: Add opensmtpd-service-type test iyzsong
2016-11-26 22:21 ` Ludovic Courtès [this message]
2016-11-27  2:21   ` 宋文武

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87inr9naqo.fsf@gnu.org \
    --to=ludo@gnu.org \
    --cc=guix-devel@gnu.org \
    --cc=iyzsong@openmailbox.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.