From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ricardo Wurmus <rekado@elephly.net>
Subject: Re: [PATCH] gnu: python-pyqt: Fix build by explicitly setting the
	stubsdir.
Date: Sat, 03 Dec 2016 17:12:17 +0100
Message-ID: <87inr1dmam.fsf@elephly.net>
References: <1480698614-20481-1-git-send-email-h.goebel@crazy-compilers.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:43307)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rekado@elephly.net>) id 1cDCw3-0000kV-5J
	for guix-devel@gnu.org; Sat, 03 Dec 2016 11:13:12 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <rekado@elephly.net>) id 1cDCvy-000087-Ud
	for guix-devel@gnu.org; Sat, 03 Dec 2016 11:13:11 -0500
Received: from sender163-mail.zoho.com ([74.201.84.163]:21332)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32)
	(Exim 4.71) (envelope-from <rekado@elephly.net>) id 1cDCvy-00007A-NU
	for guix-devel@gnu.org; Sat, 03 Dec 2016 11:13:06 -0500
In-reply-to: <1480698614-20481-1-git-send-email-h.goebel@crazy-compilers.com>
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: Hartmut Goebel <h.goebel@crazy-compilers.com>
Cc: guix-devel@gnu.org


Hartmut Goebel <h.goebel@crazy-compilers.com> writes:

> Without this option the stub files are tried to be installed into
> the python package's site-package directory.
>
> * gnu/packages.qt.scm (python-pyqt, python2-pyqt)[arguments]: In phase
> 'configure' pass option --stubsdir.
> ---
>  gnu/packages/qt.scm | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/gnu/packages/qt.scm b/gnu/packages/qt.scm
> index b442356..92c6d4b 100644
> --- a/gnu/packages/qt.scm
> +++ b/gnu/packages/qt.scm
> @@ -982,13 +982,15 @@ module provides support functions to the automatically generated code.")
>                          "."))
>                      (lib (string-append out "/lib/python"
>                                          python-major+minor
> -                                        "/site-packages")))
> +                                        "/site-packages"))
> +                    (stubs (string-append lib "/PyQt5")))
>                 (zero? (system* "python" "configure.py"
>                                 "--confirm-license"
>                                 "--bindir" bin
>                                 "--destdir" lib
>                                 "--designer-plugindir" designer
>                                 "--qml-plugindir" qml
> +                               "--stubsdir" stubs  ; PEP 484 Type Hints stubs
>                                 "--sipdir" sip))))))))
>      (home-page "https://www.riverbankcomputing.com/software/pyqt/intro")
>      (synopsis "Python bindings for Qt")

The patch looks okay to me, but I’d prefer to see your comment about why
this is needed inline above the option.  “PEP 484…” doesn’t tell me
anything, whereas your description in this email was very clear.

-- 
Ricardo

GPG: BCA6 89B6 3655 3801 C3C6  2150 197A 5888 235F ACAC
http://elephly.net