From mboxrd@z Thu Jan 1 00:00:00 1970 From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=) Subject: bug#25094: Add comments to archive keys and acls Date: Sun, 04 Dec 2016 00:55:58 +0100 Message-ID: <87inr08t4h.fsf@gnu.org> References: <5841B184.4050802@crazy-compilers.com> <20161202181351.GA30572@jasmine> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:55962) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cDKAz-0000Um-Es for bug-guix@gnu.org; Sat, 03 Dec 2016 18:57:06 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cDKAw-0005o5-Ax for bug-guix@gnu.org; Sat, 03 Dec 2016 18:57:05 -0500 Received: from debbugs.gnu.org ([208.118.235.43]:36315) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cDKAw-0005nq-7P for bug-guix@gnu.org; Sat, 03 Dec 2016 18:57:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1cDKAv-0006kz-UX for bug-guix@gnu.org; Sat, 03 Dec 2016 18:57:01 -0500 Sender: "Debbugs-submit" Resent-Message-ID: In-Reply-To: <20161202181351.GA30572@jasmine> (Leo Famulari's message of "Fri, 2 Dec 2016 13:13:51 -0500") List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org Sender: "bug-Guix" To: Leo Famulari Cc: Hartmut Goebel , 25094@debbugs.gnu.org Leo Famulari skribis: > On Fri, Dec 02, 2016 at 06:38:12PM +0100, Hartmut Goebel wrote: >> Hi, >>=20 >> the keys for authenticating an archive currently do not hold any >> comment. This makes it hard to track acls and remove certain keys if >> required. > > Indeed, this makes key management a little harder than it needs to be. Agreed. The crux of the problem is that libgcrypt=E2=80=99s canonical sexp parser does not recognize comments. does not specify comments, which may be the reason, but other implementations of canonical sexps (such as lsh and Nettle) do recognize them, so we should just get libgcrypt to follow suit. >> Please implement some way to add and change the comment on keys in >> /etc/guix/ and in /etc/guix/acl. >>=20 >> Proposed usage when generating the key: >> guix archive --generate-key=3D=E2=80=A6 --comment "store.example.com" >>=20 >> Proposed usage when importing the key and overwriting any existing comme= nt >>=20 >> guix archive --authorize --comment "store.example.com" >>=20 >> For now, since we have no commands for key management, these would be >> enough IMO. Existing commenty an easily be changed in the file, so for >> now we do not need a tool for this. > > I think that the comment should either be signed somehow, or the field > name should be "untrusted-comment". I think it=E2=80=99s no different than the optional comment in OpenSSH publ= ic keys, and it should be clear that it=E2=80=99s free from and untrusted by definition (the sexp syntax at least makes it clear that it=E2=80=99s a com= ment, as opposed to the OpenSSH public key format). Ludo=E2=80=99.