From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marius Bakke Subject: Re: [PATCH 1/6] gnu: Add python-rst2ansi Date: Wed, 08 Feb 2017 23:27:06 +0100 Message-ID: <87inokb9ol.fsf@kirby.i-did-not-set--mail-host-address--so-tickle-me> References: <1486490441-3995-1-git-send-email-fredmanglis@gmail.com> Mime-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:56080) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cbaho-0003bp-Il for guix-devel@gnu.org; Wed, 08 Feb 2017 17:27:17 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cbahl-0001ip-E1 for guix-devel@gnu.org; Wed, 08 Feb 2017 17:27:16 -0500 Received: from out1-smtp.messagingengine.com ([66.111.4.25]:60129) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1cbahl-0001iC-3G for guix-devel@gnu.org; Wed, 08 Feb 2017 17:27:13 -0500 In-Reply-To: <1486490441-3995-1-git-send-email-fredmanglis@gmail.com> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: guix-devel@gnu.org Cc: Muriithi Frederick Muriuki --=-=-= Content-Type: text/plain Hi Muriithi, Thank you for these patches! I will respond to them individually. They look good for the most part, but need some tiny tweaks that breaks the patch context. In particular, descriptions should end with a period, but if I add that to one patch, the next does not apply! Normally I would simply amend these commits while applying them, so please excuse the nit-picking. Could you also add a copyright notice for yourself at the top of python.scm with the first commit? Muriithi Frederick Muriuki writes: > * gnu/packages/python.scm (python-rst2ansi): New variable. > --- > gnu/packages/python.scm | 23 +++++++++++++++++++++++ > 1 file changed, 23 insertions(+) > > diff --git a/gnu/packages/python.scm b/gnu/packages/python.scm > index d53eea1..b57e9a7 100644 > --- a/gnu/packages/python.scm > +++ b/gnu/packages/python.scm > @@ -12536,3 +12536,26 @@ console.") > This implementation is slow (hence the project name) but still useful when > faster ones are not available.") > (license license:asl2.0))) > + > +(define-public python-rst2ansi > + (package > + (name "python-rst2ansi") > + (version "0.1.5") > + (source > + (origin > + (method url-fetch) > + (uri (pypi-uri "rst2ansi" version)) > + (sha256 > + (base32 > + "0vzy6gd60l79ff750scl0sz48r1laalkl6md6dwzah4dcadgn5qv")))) > + (build-system python-build-system) > + (native-inputs > + `(("python-docutils" ,python-docutils))) This should be a propagated-input, since rst2ansi needs docutils at runtime. > + (home-page > + "https://github.com/Snaipe/python-rst-to-ansi") The newline here is not necessary. > + (synopsis > + "Python rst converter to ansi-decorated console output") "Convert RST to ANSI-decorated console output". > + (description > + "Python module dedicated to rendering RST (reStructuredText) documents to > + ansi-escaped strings suitable for display in a terminal") All descriptions should end with a "." as mentioned above. `guix lint python-rst2ansi` should warn about this. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEu7At3yzq9qgNHeZDoqBt8qM6VPoFAlibmzsACgkQoqBt8qM6 VPqiSAf+KPSvuTFWgsnvibWQ0rdJ8fRWqCpiC+wyzQOutT5ku/IQwAqyTYg/bqAa 5kWqWpjiSrU99krDEyj55GBRb1ii1Zqx9WFJASNkqjVP9WW1ymHw87kGM2JbMleI D1a4ha6Aqxh8uxCQXeBtGA2oIRjPnPT0E8xu0SwV5MehLj5T/pUlNl4CoCeHlmAL pC2gQ+nOjHRohOO64fj5keBsv8faha+nuzbqHvG3J0qacngHCaW0elo1to+aAxtO YpOIvfbqO2TNlXQaUMhkAhvvqIn0aSnVa0JhcUbWz9PWZ6PdrO37V4La4JaSE5kI lFO9lhpkf6v91D2obSkvHsj7PIc/HA== =F6BE -----END PGP SIGNATURE----- --=-=-=--