bug#26271: 'guix system' does not support common build option '--root'

[Chris Marusich <cmmarusich@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 1107 bytes --]

ludo@gnu.org (Ludovic Courtès) writes:

> Hi Chris,
>
> Chris Marusich <cmmarusich@gmail.com> skribis:
>
>> The manual says ((guix) Invoking guix system) that the options to 'guix
>> system' "can contain any of the common build options".  Although some
>> common build options (e.g. '--fallback') do seem to work, I have noticed
>> that the '--root' option does not.  Consider the following:
>
> That’s because ‘--root’ is not a “common build option” in the sense of
> "(guix) Common Build Options".  :-)
>
> That said, I agree we should either make it a common option (i.e., add
> it to ‘%standard-build-options’ in (guix scripts build)) or add it
> explicitly to ‘guix system’.  The latter may be simpler.
>
> Thoughts?

As long as 'guix system' will create an indirect gc root as expected,
regardless of whether '--root' was specified in the environment variable
for build options or as a command-line option for the 'guix system'
command, adding it explicitly to 'guix system' seems OK to me.

I'll see if I can submit a patch later this week.

-- 
Chris

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]