From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50006) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ctZRr-0000Co-2g for guix-patches@gnu.org; Thu, 30 Mar 2017 08:45:11 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ctZRm-0004Zw-Sl for guix-patches@gnu.org; Thu, 30 Mar 2017 08:45:07 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:53820) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ctZRm-0004ZQ-P2 for guix-patches@gnu.org; Thu, 30 Mar 2017 08:45:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ctZRm-0008GA-DF for guix-patches@gnu.org; Thu, 30 Mar 2017 08:45:02 -0400 Subject: bug#26108: [PATCH 6/7] gnu: Add mia. Resent-Message-ID: References: <1489608324-23632-1-git-send-email-jmd@gnu.org> <1489608324-23632-6-git-send-email-jmd@gnu.org> From: Ricardo Wurmus In-reply-to: <1489608324-23632-6-git-send-email-jmd@gnu.org> Date: Thu, 30 Mar 2017 15:15:51 +0200 Message-ID: <87inmq52ig.fsf@elephly.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: John Darrington Cc: 26108@debbugs.gnu.org John Darrington writes: > * gnu/packages/image-processing.scm (mia): New variable. […] > + > +(define-public mia > + (package > + (name "mia") > + (version "2.4.3") > + (source (origin > + ;; There are too many issues with the released version which > + ;; prevent a clean build and test under Guix. So until the next > + ;; release I suggest we use this git checkout. That’s okay. Could you please wrap the “(package …)“ expression in a let expression where ‘commit’ is bound to "d91cade30a10f179bba8c8e48b84983a296d2c33" and ‘revision’ to "1". Then the version field should be changed to (string-append "2.4.3-" revision "." (string-take commit 7)) because this is not exactly version "2.4.3”. > + (method git-fetch) > + (uri (git-reference > + (url "https://git.code.sf.net/p/mia/mia2") > + (commit > "d91cade30a10f179bba8c8e48b84983a296d2c33"))) After wrapping the thing in a let binding you can use “(commit commit)” here. > + (sha256 > + (base32 > + "0y8ihqbliqy21fph3dm5h6k2nvjbajx4y0mn351x990r9y0767vz")) > + (file-name (string-append name "-" version)))) Usually, we append “-checkout” to git clones. > + (build-system cmake-build-system) > + (arguments `(#:configure-flags `("-DMIA_CREATE_NIPYPE_INTERFACES=0" > + ,(string-append "-DCMAKE_INSTALL_LIBDIR=" > + (assoc-ref %outputs "out") > + "/lib") > + ;; According to upstream this is necessary > + ;; with g++-4.9.x because the std::regex > + ;; library doesn't work reliably. > + "-DMIA_USE_BOOST_REGEX=ON" > + > "-DCMAKE_CXX_FLAGS=-fpermissive"))) I have a slight preference to adding a line break after “arguments”. > + (inputs `(("boost" ,boost) > + ("dcmtk" ,dcmtk) > + ("doxygen" ,doxygen) I think this should be a native input. Please also add a line break after “inputs”. > + ("eigen" ,eigen) > + ("fftw" ,fftw) > + ("fftwf" ,fftwf) > + ("gsl" ,gsl) > + ("gts" ,gts) > + ("hdf5" ,hdf5) > + ("itpp" ,itpp) > + ("libjpeg" ,libjpeg) > + ("libpng" ,libpng) > + ("libtiff" ,libtiff) > + ("libxml" ,libxml2) > + ("libxml++" ,libxml++) > + ("maxflow" ,maxflow) > + ("niftilib" ,niftilib) > + ("nlopt" ,nlopt) > + ("openexr" ,openexr) > + ("python-lxml" ,python2-lxml) > + ("vtk" ,vtk@6.3))) > + (native-inputs `(("pkg-config" ,pkg-config) > + ("python" ,python-2))) Please add a line break after “native-inputs” (for consistency). Please also collapse the spaces after "pkg-config". > + (synopsis "Toolkit for gray scale medical image analysis") > + (description "MIA provides a combination of command line tools, plug-ins, > +and libraries that make it possible run image processing tasks interactively > +in a command shell and to prototype using the shell's scripting > +language. It is built around a plug-in structure that makes it easy to add > +functionality without compromising the original code base and it makes use of a > +wide variety of external libraries that provide additional functionality.") > + (home-page "http://mia.sourceforge.net") > + (license license:gpl3+))) The rest looks good to me (I did not check the license). Would you like to push an updated version or would you like me to make the changes myself? -- Ricardo GPG: BCA6 89B6 3655 3801 C3C6 2150 197A 5888 235F ACAC https://elephly.net