Re: [PATCH] qjackctl

[Mark Meyer <mark@ofosos.org>]

[-- Attachment #1: Type: text/plain, Size: 943 bytes --]

>>>>> "LC" == Ludovic Courtès <ludo@gnu.org> writes:

    LC> Could you try to come up with a ChangeLog-style commit message
    LC> that follows our convention?  You can see ‘git log’ for examples
    LC> of what to type, and
    LC> <https://gnu.org/software/guix/manual/html_node/Submitting-Patches.html>.

I think I fixed that, I looked up the GNU guidelines and included the
following line:

* gnu/packages/audio.scm (qjackctl): Add new package.

    LC> The propose synopsis is too long, and the original string was OK
    LC> as a synopsis; see
    LC> <https://www.gnu.org/software/guix/manual/html_node/Synopses-and-Descriptions.html>.

Got confused with the `synopsis' and `description'.

    LC> Could you send an updated patch for qjackctl?  Make sure to run

    LC>   ./pre-inst-env guix lint qjackctl

    LC> before and to address any issues it reports.

Lint reports no errors.

Cheers, Mark


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: qjackctl patch --]
[-- Type: text/x-patch, Size: 1640 bytes --]

From 22b1c2a835c818d6e9d502260ddfa4de11a8a88a Mon Sep 17 00:00:00 2001
From: Mark Meyer <mark@ofosos.org>
Date: Mon, 3 Apr 2017 19:58:49 +0200
Subject: [PATCH] 2017-04-03 Mark Meyer <mark@ofosos.org>

* gnu/packages/audio.scm (qjackctl): Add new package.
---
 gnu/packages/audio.scm | 30 ++++++++++++++++++++++++++++++
 1 file changed, 30 insertions(+)

diff --git a/gnu/packages/audio.scm b/gnu/packages/audio.scm
index 2b11a32ca..b835b44dc 100644
--- a/gnu/packages/audio.scm
+++ b/gnu/packages/audio.scm
@@ -1783,6 +1783,36 @@ buffers, and audio capture.")
 and ALSA.")
     (license license:gpl3+)))
 
+(define-public qjackctl
+  (package
+    (name "qjackctl")
+    (version "0.4.4")
+    (source (origin
+              (method url-fetch)
+              (uri
+               (string-append
+                "https://downloads.sourceforge.net/project/qjackctl/qjackctl/"
+                version "/qjackctl-" version ".tar.gz"))
+              (sha256
+               (base32
+                "19bbljb3iz5ss4s5fmra1dxabg2fnp61sa51d63zsm56xkvv47ak"))))
+    (build-system gnu-build-system)
+    (arguments
+     `(#:tests? #f)) ; no check target
+
+    (inputs
+     `(("jack-2" ,jack-2)
+       ("qt" ,qt)))
+    (native-inputs
+     `(("pkg-config" ,pkg-config)
+       ("qttools" ,qttools)))
+    (home-page "https://qjackctl.sourceforge.io/")
+    (synopsis "Jack server control application")
+    (description "Control a Jack server.  Allows you to plug various sources
+into various outputs and to start, stop and configure jackd")
+    (license license:gpl2+)))
+
+
 (define-public raul
   (package
     (name "raul")
-- 
2.12.1