From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52923) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d5CbR-0007uA-8k for guix-patches@gnu.org; Mon, 01 May 2017 10:47:06 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1d5CbO-0003iw-5w for guix-patches@gnu.org; Mon, 01 May 2017 10:47:05 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:51538) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1d5CbN-0003iq-Q3 for guix-patches@gnu.org; Mon, 01 May 2017 10:47:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1d5CbN-0001GH-J0 for guix-patches@gnu.org; Mon, 01 May 2017 10:47:01 -0400 Subject: bug#26722: [PATCH 1/3] gnu: Add python-sockjs-tornado. Resent-Message-ID: From: Marius Bakke In-Reply-To: <20170430214415.3029-1-mail@cbaines.net> References: <20170430214415.3029-1-mail@cbaines.net> Date: Mon, 01 May 2017 16:46:22 +0200 Message-ID: <87inlkhby9.fsf@fastmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Christopher Baines , 26722@debbugs.gnu.org --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Hello Chris! Christopher Baines writes: > * gnu/packages/python.scm (python-sockjs-tornado): New variable. [...] > +(define-public python-sockjs-tornado > + (package > + (name "python-sockjs-tornado") > + (version "1.0.3") > + (source > + (origin > + (method url-fetch) > + (uri (string-append > + "https://pypi.python.org/packages/source/" > + "s/sockjs-tornado/sockjs-tornado-" version ".tar.gz")) Please use 'pypi-uri' here. > + (sha256 > + (base32 > + "16cff40nniqsyvda1pb2j3b4zwmrw7y2g1vqq78lp20xpmhnwwkd")))) > + (build-system python-build-system) > + (inputs > + `(("python-tornado" ,python-tornado))) Python does not have a good mechanism for specifying exact versions of runtime dependencies, so they should normally be propagated. If the package does not import this at runtime (e.g. only needed for tests) it should be a 'native-input'. LGTM with those changes. > + (home-page "http://github.com/mrjoes/sockjs-tornado/") > + (synopsis > + "SockJS python server implementation on top of Tornado framework") > + (description > + "SockJS-tornado provides the server side counterpart to a SockJS cl= ient > +library, through the Tornado framework. > + > +SockJS provides a low latency, full duplex, cross-domain communication c= hannel > +between a web browser and web server.") > + (license license:expat))) > + > +(define-public python2-sockjs-tornado > + (package-with-python2 python-sockjs-tornado)) > + > (define-public python-socksipy-branch > (package > (name "python-socksipy-branch") > --=20 > 2.12.2 --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEu7At3yzq9qgNHeZDoqBt8qM6VPoFAlkHSj4ACgkQoqBt8qM6 VPrUQwf+IJf216rTagr/QBdVoMdMaNwa/9kbzMVgbXWLM0tm+msIybcTg7ZFGP4S Xb2B6sW48Spj9s9yr/9F3TZBicwgT6hRldUKm906VzKTh3h50GyCQmWB01Kgzj3A c/QUIOjxydk0dzukXA8Jr42rLpwvm37MJR7btVE7nltwAqmahGcDsm4m/rH4VPej 3gmvwLoUf7g3pGsPDGb310HysvFjgMMCN+KBXHALl4t6HjZG5HYLIVB0hAviHGtD R7wEmy34xCAqlXjH3c9UbP8eZ+UESzI8ntyAMbronHjN1Z/kI7LTghVfDw71k3pC gkBgGOPVj0BgsaQEQpje9l7j3D9f2Q== =F/Xv -----END PGP SIGNATURE----- --=-=-=--