all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: ludo@gnu.org (Ludovic Courtès)
To: Sergei Trofimovich <slyfox@inbox.ru>
Cc: 26805@debbugs.gnu.org
Subject: bug#26805: [PATCH] gs-fonts: add missing podule imports
Date: Thu, 11 May 2017 22:49:05 +0200	[thread overview]
Message-ID: <87inl7nmpq.fsf@gnu.org> (raw)
In-Reply-To: <20170510214141.60fe16d4@sf> (Sergei Trofimovich's message of "Wed, 10 May 2017 21:41:41 +0100")

Hi!

Sergei Trofimovich <slyfox@inbox.ru> skribis:

> On Wed, 10 May 2017 13:53:41 +0200
> ludo@gnu.org (Ludovic Courtès) wrote:
>
>> What about adding (srfi srfi-1) to ‘%default-modules’ in (guix
>> build-system gnu)?  It’s generally useful anyway.
>> 
>> (Alternately, we could rename SRFI-1’s ‘delete’ in (guix build utils),
>> so we’d still be matching a literal, but we’d have problems in places
>> that use both (guix build utils) and (srfi srfi-1).)
>
> I'd personally say the less magic reexports - the better. It's ok to go
> through all of core-updates and fix missing imports.

I wouldn’t call it “magic”.  It’s just about providing a useful set of
bindings in ‘%default-modules’, to save typing essentially.

Also, for this ‘delete’ issue, I’m pretty sure we’re going to miss many
occurrences no matter what (same problem as with the ‘_’ binding from
(guix ui), which wasn’t resolved until I finally realized that renaming
it would have saved a lot of time…)

Note that there’s also the second solution above.

Thoughts?

> Would be nice the all those syntactic errors could be caught with something
> lighter-weight than full 'guix build'.

The problem is that this is “build-side code” and we can’t really tell
much about it until we’ve assembled it in on of those -guile-builder
files.

> I'm afraid I have no idea how symbol visibility works in guix as I'm
> still struggling to find which code builds and evaluates '*-guile-builder' files.
>
> For example what is the difference between
>     (use-modules ....
> and
>     (arguments '(#:modules
> ?

Hopefully the intro of the “G-Expressions” section can shed some light
on this, specifically on the build-side vs. host-side story.  Otherwise
let me know.  :-)

“(arguments '(#:modules …))” specifies modules in scope on the build
side.

HTH!

Ludo’.

  reply	other threads:[~2017-05-11 20:50 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-06 15:40 bug#26805: [PATCH] gs-fonts: add missing podule imports Sergei Trofimovich
2017-05-07 19:06 ` bug#26805: [PATCH] gs-fonts: add missing module imports Danny Milosavljevic
2017-05-09 10:20 ` bug#26805: [PATCH] gs-fonts: add missing podule imports Ludovic Courtès
2017-05-09 20:36   ` Sergei Trofimovich
2017-05-10 11:53     ` Ludovic Courtès
2017-05-10 20:41       ` Sergei Trofimovich
2017-05-11 20:49         ` Ludovic Courtès [this message]
2017-05-14 16:31           ` Sergei Trofimovich
2017-05-14 20:02             ` Ludovic Courtès
2017-05-14 23:15               ` Sergei Trofimovich
2017-05-26 13:02                 ` bug#26805: Re-exporting ‘delete’ from (guix build utils) Ludovic Courtès

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87inl7nmpq.fsf@gnu.org \
    --to=ludo@gnu.org \
    --cc=26805@debbugs.gnu.org \
    --cc=slyfox@inbox.ru \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.